On core diff in the mobile view the thank button flashes on screen before being replaced with the "thanked" text. The "thank" and "thanked" elements have different heights, which causes reflow on page load, which is pretty distracting. The non-codex version of core diff (eg. the current desktop experience) also swaps state from "thank" to "thanked", but there is no reflow.
- load a diff
- thank the user
- reload, or navigate away, then come back
What happens?:
the enabled thank button appears and clicking it causes the "You thanked x" message to appear
What should have happened instead?:
the disabled "thanked" button should appear instead since the editor has already been thanked for the edit
Software version (skip for WMF-hosted wikis like Wikipedia):
N/A
Other information (browser name/version, screenshots, etc.):
animated gif of me navigating between two edits in my local environment and repeatedly thanking
Steps to replicate the issue (include links if applicable):
- load a core diff using the mobile domain (eg. $wgMFUseDesktopDiffPage = true if working locally)
What happens?:
flashing and reflow
What should have happened instead?:
the thanked state should not impact page layout
Software version (skip for WMF-hosted wikis like Wikipedia):
N/A
Other information (browser name/version, screenshots, etc.):
animated gif of me repeated loading a diff to demonstrate reflow
