Page MenuHomePhabricator

Core diff on mobile buggy codex thank button
Open, MediumPublicBUG REPORT

Description

On core diff in the mobile view the thank button flashes on screen before being replaced with the "thanked" text. The "thank" and "thanked" elements have different heights, which causes reflow on page load, which is pretty distracting. The non-codex version of core diff (eg. the current desktop experience) also swaps state from "thank" to "thanked", but there is no reflow.

  • load a diff
  • thank the user
  • reload, or navigate away, then come back

What happens?:
the enabled thank button appears and clicking it causes the "You thanked x" message to appear

What should have happened instead?:
the disabled "thanked" button should appear instead since the editor has already been thanked for the edit

Software version (skip for WMF-hosted wikis like Wikipedia):

N/A

Other information (browser name/version, screenshots, etc.):

animated gif of me navigating between two edits in my local environment and repeatedly thanking

thank-mobilefrontend.gif (300×431 px, 150 KB)

Steps to replicate the issue (include links if applicable):

  • load a core diff using the mobile domain (eg. $wgMFUseDesktopDiffPage = true if working locally)

What happens?:

flashing and reflow

What should have happened instead?:

the thanked state should not impact page layout

Software version (skip for WMF-hosted wikis like Wikipedia):

N/A

Other information (browser name/version, screenshots, etc.):

animated gif of me repeated loading a diff to demonstrate reflow

thank-codex.gif (260×920 px, 177 KB)

Related Objects

StatusSubtypeAssignedTask
OpenBUG REPORTNone
OpenNone
StalledNone
OpenNone
OpenNone
DuplicateNone
OpenFeatureNone
OpenFeatureNone
DuplicateNone
ResolvedNone
OpenNone
OpenNone
OpenFeatureNone
OpenNone
ResolvedNone
ResolvedNone
OpenFeatureNone
OpenNone
ResolvedHalfak
OpenNone
OpenNone
OpenFeatureNone
StalledNone
OpenNone
OpenNone
OpenNone
ResolvedPetrb
OpenNone
OpenNone
Resolvedtstarling
OpenNone
DeclinedNone
ResolvedBUG REPORTJdlrobson
ResolvedNone
ResolvedNone
OpenJdlrobson
OpenBUG REPORTNone

Event Timeline

jsn.sherman renamed this task from MobileDiff / core diff on mobile buggy thank button to MobileDiff / core diff on mobile buggy codex thank button.Dec 8 2023, 3:02 PM
jsn.sherman updated the task description. (Show Details)

I think this code lives in the Thanks extension. Hopefully we will only need to worry about the desktop version of this page if we can prioritize T117279.

Currently:

Screenshot_20240105_134322_Chrome.jpg (2×1 px, 336 KB)

Proposed:

Screenshot 2024-01-05 at 2.00.24 PM.png (491×675 px, 54 KB)

Jdlrobson updated the task description. (Show Details)

Change 988103 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Style thanks confirmable panel on mobile

https://gerrit.wikimedia.org/r/988103

Change 988103 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Style thanks confirmable panel on mobile

https://gerrit.wikimedia.org/r/988103

Jdlrobson changed the task status from Open to Stalled.EditedJan 12 2024, 5:09 PM

I suggest stalling this for now until we have one diff view to rule them all (T350181)

Jdlrobson raised the priority of this task from High to Needs Triage.Jan 12 2024, 5:09 PM
Jdlrobson triaged this task as Medium priority.
Jdlrobson renamed this task from MobileDiff / core diff on mobile buggy codex thank button to Core diff on mobile buggy codex thank button.Feb 23 2024, 2:09 AM
Jdlrobson changed the task status from Stalled to Open.
Jdlrobson updated the task description. (Show Details)