Page MenuHomePhabricator
Create Task
Maniphest T57793

Scoring should perhaps take into account added text rather than all text
Closed, ResolvedPublic
Actions

Description

suggested enhancement: At the moment, an edit will (as far as I can tell, and forgive me if I'm wrong) be scored if there is a trigger word anywhere in the diff, even if it was not added in the edit in question. As a suggestion, if it is not easy to identify "added text", one could use the heuristic of "in the 'after' text but not in the 'before' text".

Version: trunk
Severity: enhancement
URL: https://github.com/huggle/huggle3-qt-lx/issues/20

Details

Reference
bz55793

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT94370 Implement a mechanism that recognizes syntax errors of wikicode as a Huggle extension
 ResolvedPetrbT57793 Scoring should perhaps take into account added text rather than all text
 OpenNoneT56328 Provide intraline diff format in API action=compare
 ResolvedNoneT117279 [EPIC] Core should provide inline diffs as well as side by side (Move InlineDifferenceEngine into core / remove MobileDiff)
 ResolvedovasilevaT101796 MobileDiff appears strangely empty if previous revision is hidden
 ResolvedJdlrobsonT222562 Special:MobileDiff doesn't correctly handle diff=0 if the diff would cover multiple revisions
 ResolvedAmmarpadT224430 Improve appearance of Special:MobileDiff when looking for invalid revision (Maybe because it's deleted)
 OpenNoneT194830 Refactor DifferenceEngine
 ResolvedJdlrobsonT238331 Option for hiding changes should be added to AMC diff display
 ResolvedJdlrobsonT240608 Standardise a control for switching diff types from side by side to inline/visual
 ResolvedphuedxT240622 [Technical debt payoff] Remove InlineDiffFormatter and InlineDifferenceEngine from MobileFrontend
 ResolvedJdlrobsonT240624 Style desktop Minerva diff page to look like Special:MobileDiff
ResolvedovasilevaT242310 Regression: issues with MobileDiff
 Resolved• marcellaT242351 HTML for VisualDiff mode button appears in mobile diff pages (disabled by hack)
 ResolvedmatmarexT244673 VisualDiff feature on mobile has an inconsistent style/layout
 ResolvedBUG REPORT• EsandersT245172 VisualDiff toggle buttons appear in mobile when the relevant page doesn't have wikitext content model
 ResolvedovasilevaT243783 MobileDiff drops whitespaces from edits
 ResolvedovasilevaT243235 Regression: Desktop diff styles for moved paragraphs load alongside mobile
 ResolvedJdlrobsonT171726 MobileDiff with inconsistent linebreaks within words
 InvalidNoneT199307 Determine treatment for empty lines in diffs
 Resolved• jkrollT197729 wikidiff2 creating ins and del elements with single empty character element
 OpenFeatureNoneT298174 Diffs should show change tags at lower resolutions
 OpenNoneT218428 Mobile diff is not clear about move direction
 ResolvedJdlrobsonT191706 It's not possible to undo/rollback edits from diff on Mobile
 ResolvedJdlrobsonT347779 Show editor groups and edit count on diff pages
 ResolvedJdlrobsonT347780 Include previous and next links outside the diff columns
 DeclinedNoneT348179 Show bytes added on diff pages
 ResolvedNoneT350181 Enable desktop diff page on mobile site
 ResolvedBUG REPORTSBissonT353404 Wikistory showing on mobile diff page
 ResolvedJdlrobsonT353407 Diff footer is overlaying the text when visual diff is clicked
 ResolvedBUG REPORTJdlrobsonT353478 Diff tables collapse incorrectly on tablet breakpoint
 ResolvedJSengupta-WMFT353479 Diff legend does not display in mobile HTML
 OpenBUG REPORTNoneT361176 visualdiff legend colors are mismatched
 OpenBUG REPORTNoneT353062 Core diff on mobile buggy codex thank button
 ResolvedJdlrobsonT357079 Wrong digit on bnwiki mobile diff
 DuplicateNoneT218779 Expose structured diffs in Wikibase API

Event Timeline

• bzimport raised the priority of this task from to Lowest.Nov 22 2014, 2:40 AM
• bzimport added a project: Huggle.
• bzimport set Reference to bz55793.
Petrb created this task.Oct 16 2013, 3:44 PM
Petrb added a comment.Oct 16 2013, 3:45 PM

Problem here is that mediawiki doesn't make a difference between old and new. Mediawiki should be able to provide only a new text of a diff so that this check can be done against it.

Please open a feature request for that in product "MediaWiki" and link it as a blocker of this bug

Petrb added a comment.Oct 16 2013, 3:47 PM

this ticket was moved from github, originally created by someone else, see linked ticket

Petrb added a comment.Nov 29 2013, 2:29 PM

currently this is blocked by upstream bug, I am lowering priority until the blocking bug is fixed

Petrb removed Petrb as the assignee of this task.Nov 25 2014, 9:30 AM
Petrb set Security to None.
Petrb moved this task from Backlog to Ready to Go on the Huggle board.Nov 25 2014, 3:07 PM
Petrb moved this task from Ready to Go to Doing on the Huggle board.
Petrb moved this task from Doing to Need volunteer on the Huggle board.
Petrb moved this task from Need volunteer to Waiting on the Huggle board.
Ricordisamoa subscribed.Mar 27 2015, 10:41 PM
Petrb added a parent task: T94370: Implement a mechanism that recognizes syntax errors of wikicode as a Huggle extension.Mar 29 2015, 10:35 PM
Petrb closed this task as Resolved.Mar 30 2015, 1:19 PM
Petrb claimed this task.

this temporarily fixes the problem https://github.com/huggle/extension-splitter-helper

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits