⚓ T244673 VisualDiff feature on mobile has an inconsistent style/layout

Subject	Repo	Branch	Lines +/-
SpecialMobileDiff: Re-enable div.content wrapper	mediawiki/extensions/MobileFrontend	master	+12 -3
mobilediff: Fix added/deleted content colors to not apply inside visual diffs	mediawiki/extensions/MobileFrontend	master	+8 -4
Add .mw-parser-output to historical visual diffs	mediawiki/extensions/VisualEditor	master	+1 -0

Status	Subtype	Assigned	Task
Declined		dchen	T118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
Open		None	T115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
Open		None	T115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
Duplicate		None	T115864 Figure out if the description of the image can be used as the caption on-wiki
Open	Feature	None	T53032 When inserting an image, set its caption by default to be the Commons image description
Open	BUG REPORT	None	T12863 Links on commons upload summaries do not link to commons
Open		None	T5498 Image history is confusing
Stalled		None	T96384 Integrate file revisions with description page history
Open	Feature	None	T39534 Wikimedia Commons should support searching by color
Duplicate		None	T39535 Wikimedia Commons should support filtering by color
Resolved		None	T19503 Provide metadata support on Wikimedia Commons
Open		None	T122038 Moving/Deleting a video file does not move/delete subtitles files, nor does it inform the file mover of their existence
Open		None	T135221 Make TimedText content an integral part of the File page
Open	Feature	None	T2167 Use a dedicated interface for adding meta-data like interwiki links, rather than wikitext
Open		None	T132072 Integrate page meta-data as a new content model revision slot for consistency and atomicity
Resolved		None	T51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
Resolved		None	T68108 [Epic] Store media information for files on Wikimedia Commons as structured data
Open	Feature	None	T14963 allow per-page exceptions to spam blacklist
Open		None	T203157 Make the spam whitelist its own slot
Resolved		Halfak	T252280 Improve Wikilabels UI
Open		None	T105518 Make Wiki Labels mobile compatible
Open		None	T104072 Implement single column diff option (from mobile app)
Open	Feature	None	T56140 Move TemplateData to its own JSON-content namespace and associate with Template-namespace, or to its own TemplateData content model and revision slot
Stalled		None	T174043 Deploy Multi-Content Revisions
Open		None	T174022 Implement multi-content revisions
Open		None	T189220 Ensure that relevant extensions are MCR-aware
Open		None	T94370 Implement a mechanism that recognizes syntax errors of wikicode as a Huggle extension
Resolved		Petrb	T57793 Scoring should perhaps take into account added text rather than all text
Open		None	T100082 Provide useful diffs to high-volume consumers of recent changes
Open		None	T56328 Provide intraline diff format in API action=compare
Resolved		tstarling	T339184 MW core diff review/reorg/refactor
Open		None	T202763 Update extensions which customize content diff rendering
Declined		None	T162210 [EPIC] Upstream MobileFrontend components to core and other extensions (tracking)
Resolved	BUG REPORT	Jdlrobson	T238507 MobileFrontend sometimes goes to diff page instead of pending changes review page
Resolved		None	T117279 [EPIC] Core should provide inline diffs as well as side by side (Move InlineDifferenceEngine into core / remove MobileDiff)
Resolved		ovasileva	T242310 Regression: issues with MobileDiff
Resolved		• marcella	T242351 HTML for VisualDiff mode button appears in mobile diff pages (disabled by hack)
Resolved		matmarex	T244673 VisualDiff feature on mobile has an inconsistent style/layout

Masumrezarock100 removed • marcella as the assignee of this task.Feb 9 2020, 8:56 PM

Masumrezarock100 removed a project: MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).

Masumrezarock100 added a subscriber: • marcella.

Masumrezarock100 updated the task description. (Show Details)Feb 9 2020, 8:59 PM

Masumrezarock100 mentioned this in T242351: HTML for VisualDiff mode button appears in mobile diff pages (disabled by hack).Feb 9 2020, 9:01 PM

It looks like Readers Web is taking this on so the Editing team is moving it from our current work board.

@ovasileva the parent task is tagged with "Web-Team-Backlog (Tracking)". So I used the same tag. Could you clarify whether Readers is taking this on and prioritize accordingly?

@JTannerWMF I don't think reading web have any plans to work on this. It's tagged with #readers-web-backlog-tracking. The associated extension is not one we maintain and this is a beta feature (I don't know which team owns it).

Masumrezarock100 updated the task description. (Show Details)Feb 11 2020, 12:03 AM

In T244673#5870517, @Jdlrobson wrote:

@JTannerWMF I don't think reading web have any plans to work on this. It's tagged with #readers-web-backlog-tracking. The associated extension is not one we maintain and this is a beta feature (I don't know which team owns it).

VisualDiff is a part of the VisualEditor extension. It looks like it is maintained by the Editing team, at least https://www.mediawiki.org/wiki/Extension:VisualEditor#References says so.

I think the scope of this is unclear…

If this task is about consolidating the design of the two diffs, then it seems to me that neither Editing nor Reading are interested in working on that at the moment.

If this task is only about fixing actually wrong rendering (e.g. list items in the mobile visual diffs don't have the bullets and are not indented), then I'd like to work on that, and hopefully will convince someone from Editing to review the fixes.

Change 571571 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Add .mw-parser-output to historical visual diffs

https://gerrit.wikimedia.org/r/571571

Change 571572 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/MobileFrontend@master] mobilediff: Fix added/deleted content colors to not apply inside visual diffs

https://gerrit.wikimedia.org/r/571572

Change 571573 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/MobileFrontend@master] SpecialMobileDiff: Re-enable div.content wrapper

https://gerrit.wikimedia.org/r/571573

I believe these patches result in an acceptable state.

Example diff:

Before (mobile)	After (mobile)	Desktop (for reference)	Desktop, wikitext (for reference)

matmarex edited projects, added Editing-team (Q3 2019-2020 Kanban Board); removed Editing-team (Tracking).Feb 11 2020, 9:29 PM

matmarex moved this task from Needs Discussion / Investigation to Code Review on the Editing-team (Q3 2019-2020 Kanban Board) board.

Change 571571 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Add .mw-parser-output to historical visual diffs

https://gerrit.wikimedia.org/r/571571

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.20; 2020-02-18).Feb 11 2020, 11:00 PM

matmarex moved this task from To Triage to Triaged on the VisualEditor board.Feb 12 2020, 5:21 PM

Masumrezarock100 reassigned this task from ovasileva to matmarex.Feb 12 2020, 5:23 PM

The patch in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/571573/ causes alignment issues:

Screen Shot 2020-02-14 at 11.52.42 AM.png (1×666 px, 102 KB)

I've replied on the ticket.

Jdlrobson moved this task from Needs triage to Triaged on the Mobile board.Feb 21 2020, 6:49 PM

Change 571572 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] mobilediff: Fix added/deleted content colors to not apply inside visual diffs

https://gerrit.wikimedia.org/r/571572

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.22; 2020-03-03); removed MW-1.35-notes (1.35.0-wmf.20; 2020-02-18).Feb 26 2020, 8:01 PM

Change 571573 abandoned by Bartosz Dziewoński:
SpecialMobileDiff: Re-enable div.content wrapper

https://gerrit.wikimedia.org/r/571573

I am not planning to work on this any more, sorry.

The current state is that I fixed all of the conflicts between the two sets of diff styles, but the visual diff's "contents" are missing the usual content styles (e.g. no bullet points in lists), because for some reason MobileFrontend doesn't allow it to apply there.

Jdlrobson moved this task from Untriaged to Untag on the Web-Team-Backlog (Tracking) board.Sep 21 2021, 8:42 PM

matmarex mentioned this in T292491: Context of Visual differences become invisible under mobile view.Oct 7 2021, 4:39 PM

matmarex mentioned this in T293392: Content styles not applied to mobile visual diff.Oct 14 2021, 6:59 PM

In T244673#6110852, @matmarex wrote:

The current state is that I fixed all of the conflicts between the two sets of diff styles, but the visual diff's "contents" are missing the usual content styles (e.g. no bullet points in lists), because for some reason MobileFrontend doesn't allow it to apply there.

The remaining issues are being fixed in T293392. I think we can close this.

VisualDiff feature on mobile has an inconsistent style/layout
Closed, ResolvedPublic
Actions

Description

Details

Related Objects
Search...

Event Timeline

	F31616604: Screen Shot 2020-02-14 at 11.52.42 AM.png
	Feb 14 2020, 7:54 PM

	F31547896: en.m.wikipedia.beta.wmflabs.org_wiki_Special_MobileDiff_411223...412204_diffmode=visual(iPhone 6_7_8).png
	Feb 9 2020, 8:59 PM

	F31539250: Screenshot_20200130-030326.png
	Feb 9 2020, 8:56 PM

	F31608731: image.png
	Feb 11 2020, 8:49 PM

	F31608738: image.png
	Feb 11 2020, 8:49 PM

	F31608733: image.png
	Feb 11 2020, 8:49 PM

	F31608736: image.png
	Feb 11 2020, 8:49 PM

VisualDiff feature on mobile has an inconsistent style/layoutClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

VisualDiff feature on mobile has an inconsistent style/layout
Closed, ResolvedPublic
Actions

Related Objects
Search...