Ensure that relevant extensions are MCR-aware
Open, MediumPublic
Actions

Assigned To

None

Authored By

	daniel
	Mar 8 2018, 4:28 PM

Description

This is a tracking ticket for investigating which extensions need updating to be fully functional with MCR.

We should investigate at least:

SpamBlacklist applies to content of all slots
AbuseFilter applies to the content of all slots

We should further survey which extensions rely on PreparedEdit objects returned by WikiPage::prepareContentForEdit, compare also T194042: Replace usages of WikiPage::prepareContentForEdit.

Details

	Subject	Repo	Branch	Lines +/-
	Allow edit.php to modify different slots.	mediawiki/core	master	+29 -6

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open	BUG REPORT	None	T12863 Links on commons upload summaries do not link to commons
Open		None	T5498 Image history is confusing
Stalled		None	T96384 Integrate file revisions with description page history
Open		None	T115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
Open		None	T115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
Duplicate		None	T115864 Figure out if the description of the image can be used as the caption on-wiki
Open	Feature	None	T53032 When inserting an image, set its caption by default to be the Commons image description
Open	Feature	None	T39534 Wikimedia Commons should support searching by color
Duplicate		None	T39535 Wikimedia Commons should support filtering by color
Resolved		None	T19503 Provide metadata support on Wikimedia Commons
Open		None	T122038 Moving/Deleting a video file does not move/delete subtitles files, nor does it inform the file mover of their existence
Open		None	T135221 Make TimedText content an integral part of the File page
Open	Feature	None	T2167 Use a dedicated interface for adding meta-data like interwiki links, rather than wikitext
Open		None	T132072 Integrate page meta-data as a new content model revision slot for consistency and atomicity
Resolved		None	T51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
Resolved		None	T68108 [Epic] Store media information for files on Wikimedia Commons as structured data
Open	Feature	None	T14963 allow per-page exceptions to spam blacklist
Open		None	T203157 Make the spam whitelist its own slot
Open	Feature	None	T56140 Move TemplateData to its own JSON-content namespace and associate with Template-namespace, or to its own TemplateData content model and revision slot
Stalled		None	T174043 Deploy Multi-Content Revisions
Open		None	T174022 Implement multi-content revisions
Open		None	T189220 Ensure that relevant extensions are MCR-aware
Resolved		daniel	T194037 Track dependencies for multiple Content objects per page
Resolved		daniel	T194038 Introduce ContentHandler::getSecondaryDataUpdates to replace Content::getSecondaryDataUpdates
Invalid		Tgr	T194049 Introduce SlotRenderingProvider
Resolved		daniel	T190063 Tracking dependencies for multiple Content objects per page (MCR)
Resolved		Tgr	T194043 Replace usages of Content::getSecondaryDataUpdates
Resolved		Tgr	T196653 Test MCR Storage Layer Patches
Resolved		Tgr	T192306 Create MCR test wiki on WM Cloud
Resolved		• Bstorm	T194239 Request creation of mcr-dev VPS project
Resolved		CCicalese_WMF	T196082 npm install for selenium tests not working on labs-vagrant
Resolved		edwardspec	T205982 MCR: replace PageContentSave hook: must have a hook that receives all slots (for edit-intercepting extensions like Moderation)
Open		None	T195779 MCR support in ORES
Resolved		awight	T201332 ORES feature extraction triggers new MCR-related deprecation warning
Open		None	T191795 Support MCR in mobile
Open		None	T200687 MCR support in TemplateStyles
Open		None	T187935 Allow cross-slot access during HTML rendering.
Open		None	T201848 Make DifferenceEngine callers pass revisions, not contents
Open		None	T202763 Update extensions which customize content diff rendering
Resolved		None	T117279 [EPIC] Core should provide inline diffs as well as side by side (Move InlineDifferenceEngine into core / remove MobileDiff)
Resolved		ovasileva	T101796 MobileDiff appears strangely empty if previous revision is hidden
Resolved		Jdlrobson	T222562 Special:MobileDiff doesn't correctly handle diff=0 if the diff would cover multiple revisions
Resolved		Ammarpad	T224430 Improve appearance of Special:MobileDiff when looking for invalid revision (Maybe because it's deleted)
Open		None	T194830 Refactor DifferenceEngine
Resolved		Jdlrobson	T238331 Option for hiding changes should be added to AMC diff display
Resolved		Jdlrobson	T240608 Standardise a control for switching diff types from side by side to inline/visual
Resolved		phuedx	T240622 [Technical debt payoff] Remove InlineDiffFormatter and InlineDifferenceEngine from MobileFrontend
Resolved		Jdlrobson	T240624 Style desktop Minerva diff page to look like Special:MobileDiff
Resolved		ovasileva	T242310 Regression: issues with MobileDiff
Resolved		• marcella	T242351 HTML for VisualDiff mode button appears in mobile diff pages (disabled by hack)
Resolved		matmarex	T244673 VisualDiff feature on mobile has an inconsistent style/layout
Resolved	BUG REPORT	Esanders	T245172 VisualDiff toggle buttons appear in mobile when the relevant page doesn't have wikitext content model
Resolved		ovasileva	T243783 MobileDiff drops whitespaces from edits
Resolved		ovasileva	T243235 Regression: Desktop diff styles for moved paragraphs load alongside mobile
Resolved		Jdlrobson	T171726 MobileDiff with inconsistent linebreaks within words
Invalid		None	T199307 Determine treatment for empty lines in diffs
Resolved		• jkroll	T197729 wikidiff2 creating ins and del elements with single empty character element
Open	Feature	None	T298174 Diffs should show change tags at lower resolutions
Open		None	T218428 Mobile diff is not clear about move direction
Resolved		Jdlrobson	T191706 It's not possible to undo/rollback edits from diff on Mobile
Resolved		Jdlrobson	T347779 Show editor groups and edit count on diff pages
Resolved		Jdlrobson	T347780 Include previous and next links outside the diff columns
Declined		None	T348179 Show bytes added on diff pages
Resolved		None	T350181 Enable desktop diff page on mobile site
Resolved	BUG REPORT	SBisson	T353404 Wikistory showing on mobile diff page
Resolved		Jdlrobson	T353407 Diff footer is overlaying the text when visual diff is clicked
Resolved	BUG REPORT	Jdlrobson	T353478 Diff tables collapse incorrectly on tablet breakpoint
Resolved		JSengupta-WMF	T353479 Diff legend does not display in mobile HTML
Open	BUG REPORT	None	T361176 visualdiff legend colors are mismatched
Open	BUG REPORT	None	T353062 Core diff on mobile buggy codex thank button
Resolved		Jdlrobson	T357079 Wrong digit on bnwiki mobile diff
Resolved		daniel	T208767 Ensure that SpamBlacklist applies to the content of all MCR slots
Resolved		Jdforrester-WMF	T208769 Ensure that AbuseFilter applies to the content of all MCR slots
Resolved		daniel	T209291 Make AbuseFilter::revisionToString work across slots
Resolved		Jdforrester-WMF	T208770 Ensure TitleBlacklist applies when the context is an MCR page
Resolved		Jdforrester-WMF	T208771 Ensure ConfirmEdit applies when the context is an MCR page
Declined		None	T218096 Extension Duplicator needs to be updated due to MCR schema changes

Event Timeline

daniel triaged this task as Medium priority.Mar 8 2018, 4:28 PM

daniel created this task.

CCicalese_WMF subscribed.Mar 8 2018, 5:57 PM

daniel added a subscriber: Abit.Mar 8 2018, 5:58 PM

CCicalese_WMF moved this task from Inbox to Watching on the MediaWiki-Platform-Team-Archived board.Mar 13 2018, 12:29 AM

daniel added a parent task: T194750: Deploy Structured Data on Commons baseline .May 15 2018, 11:26 AM

CCicalese_WMF moved this task from Inbox to Epic on the Multi-Content-Revisions board.May 15 2018, 2:52 PM

daniel edited projects, added Multi-Content-Revisions (MCR-SDC Statement Support - phase 3); removed Multi-Content-Revisions.Jul 11 2018, 5:40 PM

daniel updated the task description. (Show Details)

CCicalese_WMF edited projects, added Core-Platform-Team-Old; removed MediaWiki-Platform-Team-Archived.Jul 12 2018, 12:14 AM

CCicalese_WMF moved this task from Inbox to Watching on the Core-Platform-Team-Old board.

CCicalese_WMF moved this task from Backlog to Epic on the Multi-Content-Revisions (MCR-SDC Statement Support - phase 3) board.Jul 12 2018, 3:12 AM

Jdforrester-WMF mentioned this in T194750: Deploy Structured Data on Commons baseline .Sep 4 2018, 9:51 PM

daniel moved this task from Epic to Backlog on the Multi-Content-Revisions (MCR-SDC Statement Support - phase 3) board.Sep 10 2018, 1:33 PM

CCicalese_WMF added a subtask: T194037: Track dependencies for multiple Content objects per page.Sep 10 2018, 2:16 PM

CCicalese_WMF removed a project: Epic.Sep 10 2018, 2:29 PM

awight mentioned this in T200297: Review Jade data storage and architecture proposal [RFC].Sep 12 2018, 6:03 PM

Change 460490 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Allow edit.php to modify different slots.

https://gerrit.wikimedia.org/r/460490

gerritbot added a project: Patch-For-Review.Sep 14 2018, 9:22 AM

CCicalese_WMF edited projects, added Multi-Content-Revisions; removed Multi-Content-Revisions (MCR-SDC Statement Support - phase 3).Sep 17 2018, 2:08 PM

daniel closed subtask T194037: Track dependencies for multiple Content objects per page as Resolved.Sep 17 2018, 6:59 PM

Change 460490 merged by jenkins-bot:
[mediawiki/core@master] Allow edit.php to modify different slots.

https://gerrit.wikimedia.org/r/460490

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)).Sep 18 2018, 4:00 PM

CCicalese_WMF added a project: Epic.Sep 19 2018, 2:36 PM

CCicalese_WMF removed a project: Patch-For-Review.

Jdforrester-WMF added a parent task: T204582: Verify that abuse-/spam-related extensions work with Wikibase MediaInfo.Sep 24 2018, 4:44 PM

Jdforrester-WMF added a project: Structured Data Engineering.Sep 27 2018, 10:22 PM

CCicalese_WMF moved this task from Watching to Epic on the Core-Platform-Team-Old board.Oct 1 2018, 4:21 PM

CCicalese_WMF edited projects, added Platform Team Legacy; removed Core-Platform-Team-Old.Oct 1 2018, 4:23 PM

CCicalese_WMF moved this task from Inbox to Epics on the Platform Team Legacy board.

CCicalese_WMF added a project: Platform Engineering.Oct 2 2018, 2:02 PM

edwardspec added a subtask: T205982: MCR: replace PageContentSave hook: must have a hook that receives all slots (for edit-intercepting extensions like Moderation).Oct 2 2018, 3:10 PM

Per @Tgr in IRC, this is "blocked on having the finalized PageUpdater interface, and on SlotRoleHandler/PageTypeHandler landing". That would be T196087: Refactored implementation of MCR page update interface and T194046: Introduce SlotRoleHandler and SlotRoleRegistry for declaring slot roles. and NO_TASK_YET for PageTypeHandler.

More precisely,

extensions that would provide their own slots are blocked on T194046: Introduce SlotRoleHandler and SlotRoleRegistry for declaring slot roles.. Obvious candidates are TemplateStyles, TemplateData, TimedMediaHandler, MediaWiki-extensions-PageAssessments, MediaWiki-extensions-WikibaseClient (for description overrides), MassMessage. Maybe also extensions that now require injecting a big ugly data dump into wikitext (like Maps, MediaWiki-extensions-Graph, EasyTimeline, maybe even Cite).
anything that provides an editable slot (ie. editing is not done entirely via the API/programmatically) is further blocked on T204112: Support slots other than the main slot in EditPage.
extensions which define their own namespace are probably blocked in PageTypeHandler (gerrit 463076, no task yet). MediaWiki-extensions-Gadgets, ProofreadPage, MediaWiki-extensions-CentralNotice. Maybe MediaWiki-extensions-Translate.
extensions which want to edit a non-main slot programmatically (or the main slot and don't want to use Wikipage::doEditContent on account of it being deprecated) are blocked on T196087: Refactored implementation of MCR page update interface.
anything that uses PreparedEdit (including SpamBlacklist, AbuseFilter, ORES and similar edit filtering extensions) are probably blocked on T194042: Replace usages of WikiPage::prepareContentForEdit, specifically access to slot-level info in whatever replaces PreparedEdit.

Tgr added a subtask: T195779: MCR support in ORES.Oct 3 2018, 1:04 AM

Tgr added subtasks: T191795: Support MCR in mobile, T200687: MCR support in TemplateStyles.

Tgr added subtasks: T201848: Make DifferenceEngine callers pass revisions, not contents, T202763: Update extensions which customize content diff rendering.Oct 3 2018, 3:37 AM

CCicalese_WMF edited projects, added Platform Team Legacy (Epic), Platform Engineering (MCR); removed Platform Engineering, Platform Team Legacy.Oct 3 2018, 1:58 PM

CCicalese_WMF moved this task from Epic to Tech Debt on the Multi-Content-Revisions board.Oct 4 2018, 3:03 PM

CCicalese_WMF edited projects, added Multi-Content-Revisions (Tech Debt); removed Multi-Content-Revisions.

For the record, I think SpamBlacklist will work properly with MCR, without any change:

SpamBlacklistHooks::filterMergedContent calls WikiPage::prepareContentForEdit and then only uses $editInfo->output, which is the combined ParserOutput for all fields. This means that getExternalLinks() will return the external links from all slots, and SpamBlacklist::filter() will thus detect any bad links in any slot.

There is a caveat: when checking upload comments, SpamBlacklistHooks::onUploadVerifyUpload calls Content::getParserOutput directly, which will only cover the main slot. But this will only become a problem when the upload interface starts supporting the immediate creation of additional slots, at which point the UploadVerifyUpload hook will need updating.

SpamBlacklistHooks should of course still be updated to not use the deprecated prepareContentForEdit() method.

Jdforrester-WMF removed a parent task: T204582: Verify that abuse-/spam-related extensions work with Wikibase MediaInfo.Nov 5 2018, 7:43 PM

Jdforrester-WMF removed a project: Structured Data Engineering.

daniel mentioned this in T204582: Verify that abuse-/spam-related extensions work with Wikibase MediaInfo.Nov 6 2018, 1:11 PM

daniel closed subtask T208767: Ensure that SpamBlacklist applies to the content of all MCR slots as Resolved.Nov 6 2018, 1:42 PM

Jdforrester-WMF closed subtask T208771: Ensure ConfirmEdit applies when the context is an MCR page as Resolved.Nov 14 2018, 4:24 PM

Jdforrester-WMF closed subtask T208770: Ensure TitleBlacklist applies when the context is an MCR page as Resolved.Nov 16 2018, 7:19 PM

Jdforrester-WMF removed a parent task: T194750: Deploy Structured Data on Commons baseline .Nov 16 2018, 7:24 PM

Jdforrester-WMF closed subtask T208769: Ensure that AbuseFilter applies to the content of all MCR slots as Resolved.Dec 10 2018, 3:35 PM

CCicalese_WMF added a subtask: T218096: Extension Duplicator needs to be updated due to MCR schema changes.Mar 12 2019, 1:25 PM

• WDoranWMF removed a project: Platform Team Legacy (Epic).Jul 5 2019, 7:33 PM

• WDoranWMF moved this task from MCR to mop on the Platform Engineering board.Jul 26 2019, 6:40 PM