Maniphest T201848

Make DifferenceEngine callers pass revisions, not contents
Open, MediumPublic
Actions

Assigned To

None

Authored By

	Tgr
	Aug 13 2018, 3:17 PM

Description

The MCR update gives DifferenceEngine a new setRevisions() method which works like setContent() but can handle multiple slots. Callers that might need multi-slot should be updated to use it. At a glance, these are:

EditPage::showDiff (view changes while editing; depends on multi-slot edit support)
SpecialUndelete::showDiff ("diff" links on undelete page)
TextConflictHelper::showEditFormTextAfterFooters (edit conflict)

Details

	Subject	Repo	Branch	Lines +/-
	Support multi-content diffs on Special:Undelete	mediawiki/core	master	+2 -8

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Declined		dchen	T118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
Open		None	T115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
Open		None	T115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
Duplicate		None	T115864 Figure out if the description of the image can be used as the caption on-wiki
Open	Feature	None	T53032 When inserting an image, set its caption by default to be the Commons image description
Open	BUG REPORT	None	T12863 Links on commons upload summaries do not link to commons
Open		None	T5498 Image history is confusing
Stalled		None	T96384 Integrate file revisions with description page history
Open	Feature	None	T39534 Wikimedia Commons should support searching by color
Duplicate		None	T39535 Wikimedia Commons should support filtering by color
Resolved		None	T19503 Provide metadata support on Wikimedia Commons
Open		None	T122038 Moving/Deleting a video file does not move/delete subtitles files, nor does it inform the file mover of their existence
Open		None	T135221 Make TimedText content an integral part of the File page
Open	Feature	None	T2167 Use a dedicated interface for adding meta-data like interwiki links, rather than wikitext
Open		None	T132072 Integrate page meta-data as a new content model revision slot for consistency and atomicity
Resolved		None	T51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
Resolved		None	T68108 [Epic] Store media information for files on Wikimedia Commons as structured data
Open	Feature	None	T14963 allow per-page exceptions to spam blacklist
Open		None	T203157 Make the spam whitelist its own slot
Open	Feature	None	T56140 Move TemplateData to its own JSON-content namespace and associate with Template-namespace, or to its own TemplateData content model and revision slot
Stalled		None	T174043 Deploy Multi-Content Revisions
Open		None	T174022 Implement multi-content revisions
Open		None	T189220 Ensure that relevant extensions are MCR-aware
Open		None	T201848 Make DifferenceEngine callers pass revisions, not contents

Event Timeline

Tgr created this task.Aug 13 2018, 3:17 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 13 2018, 3:17 PM

Tgr mentioned this in T194731: Show diffs for all slots [MCR].Aug 13 2018, 3:21 PM

CCicalese_WMF edited projects, added Multi-Content-Revisions; removed Multi-Content-Revisions (Deployment).Aug 21 2018, 2:17 PM

Tgr mentioned this in T202920: null argument on DifferenceEngine->generateContentDiffBody() on Special:Undelete.Aug 28 2018, 4:04 PM

Change 461863 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/core@master] Support multi-content diffs on Special:Undelete

https://gerrit.wikimedia.org/r/461863

gerritbot added a project: Patch-For-Review.Sep 21 2018, 5:59 AM

CCicalese_WMF moved this task from Inbox to In Progress on the Multi-Content-Revisions board.Sep 24 2018, 6:11 PM

Tgr added a parent task: T189220: Ensure that relevant extensions are MCR-aware.Oct 3 2018, 3:37 AM

CCicalese_WMF added projects: Platform Team Legacy (Designing), Platform Engineering (MCR).Oct 3 2018, 6:37 PM

CCicalese_WMF moved this task from Inbox to Doing on the Platform Team Legacy (Designing) board.Oct 3 2018, 7:22 PM

CCicalese_WMF moved this task from In Progress to Tech Debt on the Multi-Content-Revisions board.Oct 4 2018, 2:58 PM

CCicalese_WMF edited projects, added Multi-Content-Revisions (Tech Debt); removed Multi-Content-Revisions.

CCicalese_WMF edited projects, added Platform Team Workboards (Doing); removed Platform Team Legacy (Designing).Oct 14 2018, 4:00 PM

CCicalese_WMF moved this task from Doing to Waiting for Review on the Platform Team Workboards board.Nov 5 2018, 3:47 PM

CCicalese_WMF edited projects, added Platform Team Workboards (Waiting for Review); removed Platform Team Workboards (Doing).

Change 461863 merged by jenkins-bot:
[mediawiki/core@master] Support multi-content diffs on Special:Undelete