Page MenuHomePhabricator

Make DifferenceEngine callers pass revisions, not contents
Open, MediumPublic

Description

The MCR update gives DifferenceEngine a new setRevisions() method which works like setContent() but can handle multiple slots. Callers that might need multi-slot should be updated to use it. At a glance, these are:

  • EditPage::showDiff (view changes while editing; depends on multi-slot edit support)
  • SpecialUndelete::showDiff ("diff" links on undelete page)
  • TextConflictHelper::showEditFormTextAfterFooters (edit conflict)

Related Objects

StatusSubtypeAssignedTask
Declineddchen
OpenNone
OpenNone
DuplicateNone
OpenFeatureNone
OpenBUG REPORTNone
OpenNone
StalledNone
OpenFeatureNone
DuplicateNone
ResolvedNone
OpenNone
OpenNone
OpenFeatureNone
OpenNone
ResolvedNone
ResolvedNone
OpenFeatureNone
StalledNone
OpenNone
OpenNone
OpenNone
OpenNone

Event Timeline

Change 461863 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/core@master] Support multi-content diffs on Special:Undelete

https://gerrit.wikimedia.org/r/461863

Change 461863 merged by jenkins-bot:
[mediawiki/core@master] Support multi-content diffs on Special:Undelete

https://gerrit.wikimedia.org/r/461863