Page MenuHomePhabricator

Make DifferenceEngine callers pass revisions, not contents
Open, NormalPublic

Description

The MCR update gives DifferenceEngine a new setRevisions() method which works like setContent() but can handle multiple slots. Callers that might need multi-slot should be updated to use it. At a glance, these are:

  • EditPage::showDiff (view changes while editing; depends on multi-slot edit support)
  • SpecialUndelete::showDiff ("diff" links on undelete page)
  • TextConflictHelper::showEditFormTextAfterFooters (edit conflict)

Related Objects

StatusAssignedTask
Declineddchen
OpenNone
OpenNone
DuplicateNone
OpenNone
ResolvedAbit
OpenNone
OpenNone
OpenNone
OpenNone
DuplicateNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
Resolvedppelberg
ResolvedKrinkle
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone

Event Timeline

Tgr created this task.Aug 13 2018, 3:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 13 2018, 3:17 PM

Change 461863 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/core@master] Support multi-content diffs on Special:Undelete

https://gerrit.wikimedia.org/r/461863

Change 461863 merged by jenkins-bot:
[mediawiki/core@master] Support multi-content diffs on Special:Undelete

https://gerrit.wikimedia.org/r/461863

Tgr updated the task description. (Show Details)Nov 5 2018, 5:59 PM
CCicalese_WMF triaged this task as Normal priority.Dec 18 2018, 3:51 PM