Wikistory showing on mobile diff page
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Dec 14 2023, 12:08 AM

Description

Steps to replicate the issue (include links if applicable):

Can currently only be replicated on beta cluster e.g. https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Spain&diff=prev&oldid=534766&title=Spain&diffonly=1&safemode=1

What happens?:
Story banner shows which takes considerable room

Screenshot 2023-12-13 at 2.07.31 PM.png (1×716 px, 150 KB)

What should have happened instead?:

Screenshot 2023-12-13 at 2.08.32 PM.png (1×766 px, 116 KB)

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

QA Results - Beta

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T353404 here

Details

	Subject	Repo	Branch	Lines +/-
	Hide Wikistories on diff page	mediawiki/extensions/Wikistories	master	+5 -4

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Declined		dchen	T118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
Open		None	T115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
Open		None	T115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
Duplicate		None	T115864 Figure out if the description of the image can be used as the caption on-wiki
Open	Feature	None	T53032 When inserting an image, set its caption by default to be the Commons image description
Open	BUG REPORT	None	T12863 Links on commons upload summaries do not link to commons
Open		None	T5498 Image history is confusing
Stalled		None	T96384 Integrate file revisions with description page history
Open	Feature	None	T39534 Wikimedia Commons should support searching by color
Duplicate		None	T39535 Wikimedia Commons should support filtering by color
Resolved		None	T19503 Provide metadata support on Wikimedia Commons
Open		None	T122038 Moving/Deleting a video file does not move/delete subtitles files, nor does it inform the file mover of their existence
Open		None	T135221 Make TimedText content an integral part of the File page
Open	Feature	None	T2167 Use a dedicated interface for adding meta-data like interwiki links, rather than wikitext
Open		None	T132072 Integrate page meta-data as a new content model revision slot for consistency and atomicity
Resolved		None	T51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
Resolved		None	T68108 [Epic] Store media information for files on Wikimedia Commons as structured data
Open	Feature	None	T14963 allow per-page exceptions to spam blacklist
Open		None	T203157 Make the spam whitelist its own slot
Resolved		Halfak	T252280 Improve Wikilabels UI
Open		None	T105518 Make Wiki Labels mobile compatible
Open		None	T104072 Implement single column diff option (from mobile app)
Open	Feature	None	T56140 Move TemplateData to its own JSON-content namespace and associate with Template-namespace, or to its own TemplateData content model and revision slot
Stalled		None	T174043 Deploy Multi-Content Revisions
Open		None	T174022 Implement multi-content revisions
Open		None	T189220 Ensure that relevant extensions are MCR-aware
Open		None	T94370 Implement a mechanism that recognizes syntax errors of wikicode as a Huggle extension
Resolved		Petrb	T57793 Scoring should perhaps take into account added text rather than all text
Open		None	T100082 Provide useful diffs to high-volume consumers of recent changes
Open		None	T56328 Provide intraline diff format in API action=compare
Resolved		tstarling	T339184 MW core diff review/reorg/refactor
Open		None	T202763 Update extensions which customize content diff rendering
Declined		None	T162210 [EPIC] Upstream MobileFrontend components to core and other extensions (tracking)
Resolved	BUG REPORT	Jdlrobson	T238507 MobileFrontend sometimes goes to diff page instead of pending changes review page
Resolved		None	T117279 [EPIC] Core should provide inline diffs as well as side by side (Move InlineDifferenceEngine into core / remove MobileDiff)
Resolved		None	T350181 Enable desktop diff page on mobile site
Resolved	BUG REPORT	SBisson	T353404 Wikistory showing on mobile diff page

Event Timeline

Jdlrobson created this task.Dec 14 2023, 12:08 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 14 2023, 12:08 AM

Jdlrobson added a parent task: T350181: Enable desktop diff page on mobile site.Dec 14 2023, 12:09 AM

Jdlrobson triaged this task as High priority.Dec 14 2023, 12:17 AM

Jdlrobson mentioned this in T350181: Enable desktop diff page on mobile site.Dec 14 2023, 12:22 AM

Sorry about that

Change 983211 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/Wikistories@master] Hide Wikistories on diff page

https://gerrit.wikimedia.org/r/983211

gerritbot added a project: Patch-For-Review.Dec 14 2023, 3:56 PM

Change 983211 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Hide Wikistories on diff page

https://gerrit.wikimedia.org/r/983211

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.10; 2023-12-19).Dec 14 2023, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 14 2023, 5:10 PM

Thanks @SBisson for looking into this so quickly!

SBisson moved this task from Dev to QA on the Inuka-Team (Kanban) board.Dec 14 2023, 6:07 PM

@SBisson Wikistory is no longer showing on mobile diff as seen in the screenshots. This will be moved to design sign-off. Thanks for all your work!

Status: ✅PASS
Environment: Beta: 1.42.0-alpha (d5ff499)
OS: macOS Sonoma 14.2
Browser: Chrome 120, Firefox 120, Safari 17.2, Edge 120
Skins. Vector 2022, 2010, Minerva, Monobook, Timeless
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Spain&diff=prev&oldid=534766&title=Spain&diffonly=1&safemode=1