Wikistory showing on mobile diff page
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Dec 14 2023, 12:08 AM

Description

Steps to replicate the issue (include links if applicable):

Can currently only be replicated on beta cluster e.g. https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Spain&diff=prev&oldid=534766&title=Spain&diffonly=1&safemode=1

What happens?:
Story banner shows which takes considerable room

Screenshot 2023-12-13 at 2.07.31 PM.png (1×716 px, 150 KB)

What should have happened instead?:

Screenshot 2023-12-13 at 2.08.32 PM.png (1×766 px, 116 KB)

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

QA Results - Beta

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T353404 here

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Hide Wikistories on diff page	mediawiki/extensions/Wikistories	master	+5 -4

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Subtype	Assigned	Task
			· · ·
Resolved		None	T350181 Enable desktop diff page on mobile site
Resolved	BUG REPORT	SBisson	T353404 Wikistory showing on mobile diff page
			· · ·

Event Timeline

Jdlrobson created this task.Dec 14 2023, 12:08 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 14 2023, 12:08 AM

Jdlrobson added a parent task: T350181: Enable desktop diff page on mobile site.Dec 14 2023, 12:09 AM

Jdlrobson triaged this task as High priority.Dec 14 2023, 12:17 AM

Jdlrobson mentioned this in T350181: Enable desktop diff page on mobile site.Dec 14 2023, 12:22 AM

Sorry about that

Change 983211 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/Wikistories@master] Hide Wikistories on diff page

https://gerrit.wikimedia.org/r/983211

gerritbot added a project: Patch-For-Review.Dec 14 2023, 3:56 PM

Change 983211 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Hide Wikistories on diff page

https://gerrit.wikimedia.org/r/983211

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.10; 2023-12-19).Dec 14 2023, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 14 2023, 5:10 PM

Thanks @SBisson for looking into this so quickly!

SBisson moved this task from Dev to QA on the Inuka-Team (Kanban) board.Dec 14 2023, 6:07 PM

@SBisson Wikistory is no longer showing on mobile diff as seen in the screenshots. This will be moved to design sign-off. Thanks for all your work!

Status: ✅PASS
Environment: Beta: 1.42.0-alpha (d5ff499)
OS: macOS Sonoma 14.2
Browser: Chrome 120, Firefox 120, Safari 17.2, Edge 120
Skins. Vector 2022, 2010, Minerva, Monobook, Timeless
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Spain&diff=prev&oldid=534766&title=Spain&diffonly=1&safemode=1