Page MenuHomePhabricator

MCR: replace PageContentSave hook: must have a hook that receives all slots (for edit-intercepting extensions like Moderation)
Open, Needs TriagePublic

Description

Extension:Moderation relies on PageContentSave hook to (1) remember the new text, (2) return false from this hook, preventing the edit from being saved.

With MCR feature, PageContentSave hook only gets the main content (see PageUpdater::saveRevision), so it's not possible to remember the additional slots (they will be lost on edit).

New hook (e.g. MultiContentSave) should be provided, and all slots should be available from it.

Details

Related Gerrit Patches:

Related Objects

StatusAssignedTask
Declineddchen
OpenNone
OpenNone
DuplicateNone
OpenNone
ResolvedAbit
OpenNone
OpenNone
OpenNone
OpenNone
DuplicateNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
Resolvedppelberg
ResolvedKrinkle
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
Opendaniel
OpenNone
OpenNone

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 2 2018, 3:08 PM
edwardspec updated the task description. (Show Details)Oct 2 2018, 3:14 PM

Change 467308 had a related patch set uploaded (by Edward Chernenko; owner: Edward Chernenko):
[mediawiki/core@master] MCR: provide PageMultiContentSave hook to replace PageContentSave

https://gerrit.wikimedia.org/r/467308

edwardspec renamed this task from MCR: PageContentSave hook should receive all slots (for edit-intercepting extensions like Moderation) to MCR: replace PageContentSave hook: must have a hook that receives all slots (for edit-intercepting extensions like Moderation).Dec 6 2018, 1:49 AM
edwardspec updated the task description. (Show Details)

@CCicalese_WMF I#m trying to fit this into our roadmap. It has an almost-done patch, just needs some lova and attention. Edward has been waiting on this for a while, but I don't get around to looking into it this week. Any thoughts on where this should be on hour borads so it doesn't fall through the cracks?

I've put it in Core Platform Team Workboards (Waiting for Review), which we've been using both for tasks that we are waiting for others to review as well as tasks that others are waiting for us to review.

WDoranWMF moved this task from MCR to mop on the Core Platform Team board.Jul 26 2019, 6:37 PM