Maniphest T205982

MCR: replace PageContentSave hook: must have a hook that receives all slots (for edit-intercepting extensions like Moderation)
Closed, ResolvedPublic
Actions

Description

Extension:Moderation relies on PageContentSave hook to (1) remember the new text, (2) return false from this hook, preventing the edit from being saved.

With MCR feature, PageContentSave hook only gets the main content (see PageUpdater::saveRevision), so it's not possible to remember the additional slots (they will be lost on edit).

New hook (e.g. MultiContentSave) should be provided, and all slots should be available from it.

Details

	Subject	Repo	Branch	Lines +/-
	MCR: provide MultiContentSave hook to replace PageContentSave	mediawiki/core	master	+134 -12

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Declined		dchen	T118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
Open		None	T115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
Open		None	T115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
Duplicate		None	T115864 Figure out if the description of the image can be used as the caption on-wiki
Open	Feature	None	T53032 When inserting an image, set its caption by default to be the Commons image description
Open	BUG REPORT	None	T12863 Links on commons upload summaries do not link to commons
Open		None	T5498 Image history is confusing
Stalled		None	T96384 Integrate file revisions with description page history
Open	Feature	None	T39534 Wikimedia Commons should support searching by color
Duplicate		None	T39535 Wikimedia Commons should support filtering by color
Resolved		None	T19503 Provide metadata support on Wikimedia Commons
Open		None	T122038 Moving/Deleting a video file does not move/delete subtitles files, nor does it inform the file mover of their existence
Open		None	T135221 Make TimedText content an integral part of the File page
Open	Feature	None	T2167 Use a dedicated interface for adding meta-data like interwiki links, rather than wikitext
Open		None	T132072 Integrate page meta-data as a new content model revision slot for consistency and atomicity
Resolved		None	T51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
Resolved		None	T68108 [Epic] Store media information for files on Wikimedia Commons as structured data
Open	Feature	None	T14963 allow per-page exceptions to spam blacklist
Open		None	T203157 Make the spam whitelist its own slot
Open	Feature	None	T56140 Move TemplateData to its own JSON-content namespace and associate with Template-namespace, or to its own TemplateData content model and revision slot
Stalled		None	T174043 Deploy Multi-Content Revisions
Open		None	T174022 Implement multi-content revisions
Open		None	T189220 Ensure that relevant extensions are MCR-aware
Open		daniel	T196087 Refactored implementation of MCR page update interface
Open		None	T192307 Provide MCR-aware hook points
Resolved		edwardspec	T205982 MCR: replace PageContentSave hook: must have a hook that receives all slots (for edit-intercepting extensions like Moderation)

Event Timeline

edwardspec created this task.Oct 2 2018, 3:08 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 2 2018, 3:08 PM

edwardspec added a parent task: T189220: Ensure that relevant extensions are MCR-aware.Oct 2 2018, 3:10 PM

edwardspec updated the task description. (Show Details)Oct 2 2018, 3:14 PM

CCicalese_WMF added projects: Platform Team Legacy (Next), Platform Engineering (MCR).Oct 3 2018, 2:40 PM

CCicalese_WMF moved this task from Inbox to Next on the Multi-Content-Revisions board.Oct 3 2018, 5:24 PM

CCicalese_WMF moved this task from Next to Tech Debt on the Multi-Content-Revisions board.Oct 4 2018, 2:59 PM

CCicalese_WMF edited projects, added Multi-Content-Revisions (Tech Debt); removed Multi-Content-Revisions.

Change 467308 had a related patch set uploaded (by Edward Chernenko; owner: Edward Chernenko):
[mediawiki/core@master] MCR: provide PageMultiContentSave hook to replace PageContentSave

https://gerrit.wikimedia.org/r/467308

gerritbot added a project: Patch-For-Review.Oct 15 2018, 10:50 AM

Jdforrester-WMF added a parent task: T192307: Provide MCR-aware hook points.Nov 5 2018, 8:04 PM

edwardspec renamed this task from MCR: PageContentSave hook should receive all slots (for edit-intercepting extensions like Moderation) to MCR: replace PageContentSave hook: must have a hook that receives all slots (for edit-intercepting extensions like Moderation).Dec 6 2018, 1:49 AM

edwardspec updated the task description. (Show Details)

@CCicalese_WMF I#m trying to fit this into our roadmap. It has an almost-done patch, just needs some lova and attention. Edward has been waiting on this for a while, but I don't get around to looking into it this week. Any thoughts on where this should be on hour borads so it doesn't fall through the cracks?

I've put it in Platform Team Workboards (Waiting for Review), which we've been using both for tasks that we are waiting for others to review as well as tasks that others are waiting for us to review.

WDoranWMF removed a project: Platform Team Workboards (Waiting for Review).Jul 5 2019, 4:51 PM

WDoranWMF moved this task from MCR to mop on the Platform Engineering board.Jul 26 2019, 6:37 PM

WDoranWMF edited projects, added Core Platform Team Initiatives (MCR); removed Platform Engineering (MCR).

Change 467308 had a related patch set uploaded (by Edward Chernenko; owner: Edward Chernenko):
[mediawiki/core@master] MCR: provide MultiContentSave hook to replace PageContentSave

https://gerrit.wikimedia.org/r/467308

edwardspec mentioned this in T222413: PageContentSave does not allow modification of parameters.Nov 26 2019, 10:34 PM

bovender subscribed.Nov 27 2019, 7:02 PM

@daniel @CCicalese_WMF Is there anything I can do to get this merged before 1.35 (LTS) gets released?

CCicalese_WMF added a project: Platform Team Workboards (External Code Reviews).Mar 27 2020, 2:16 PM

Anomie moved this task from External Code Review Needed to External Code Review In Progress on the Platform Team Workboards (External Code Reviews) board.Mar 27 2020, 7:56 PM

Change 467308 merged by jenkins-bot:
[mediawiki/core@master] MCR: provide MultiContentSave hook to replace PageContentSave

https://gerrit.wikimedia.org/r/467308

DannyS712 removed a project: Patch-For-Review.Mar 30 2020, 5:24 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.26; 2020-03-31).Mar 30 2020, 6:00 PM

Jdforrester-WMF closed this task as Resolved.Apr 1 2020, 5:30 PM

Jdforrester-WMF assigned this task to edwardspec.