Diff footer is overlaying the text when visual diff is clicked
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Dec 14 2023, 12:20 AM

Description

NOTE: The following recording replicates the bug with developer tools to inspect: https://app.replay.io/recording/spain-difference-between-revisions-wikipedia-the-free-encyclopedia--16de4400-ea17-421f-a569-636f096f87c7

Visit https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Spain&diff=prev&oldid=534765&diffonly=1&safemode=1
Click Visual Diff

what happens

Screenshot 2023-12-13 at 2.19.20 PM.png (998×568 px, 135 KB)

expected

Text should not become transparent.

QA

Visit https://de.wikipedia.beta.wmflabs.org/w/index.php?title=Chess&diff=31578&diffonly=0&oldid=31385&useskin=minerva
Scroll to chessboard
ensure it appears below the fixed footer

QA Results - Beta

AC	Status	Details
1	✅	T353407#9518163

QA Results - Prod

AC	Status	Details
1	✅	T353407#9540372

Details

	Subject	Repo	Branch	Lines +/-
	Fixes: Diff footer is overlaying the text when visual diff is clicked	mediawiki/skins/MinervaNeue	master	+1 -0

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Declined		dchen	T118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
Open		None	T115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
Open		None	T115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
Duplicate		None	T115864 Figure out if the description of the image can be used as the caption on-wiki
Open	Feature	None	T53032 When inserting an image, set its caption by default to be the Commons image description
Open	BUG REPORT	None	T12863 Links on commons upload summaries do not link to commons
Open		None	T5498 Image history is confusing
Stalled		None	T96384 Integrate file revisions with description page history
Open	Feature	None	T39534 Wikimedia Commons should support searching by color
Duplicate		None	T39535 Wikimedia Commons should support filtering by color
Resolved		None	T19503 Provide metadata support on Wikimedia Commons
Open		None	T122038 Moving/Deleting a video file does not move/delete subtitles files, nor does it inform the file mover of their existence
Open		None	T135221 Make TimedText content an integral part of the File page
Open	Feature	None	T2167 Use a dedicated interface for adding meta-data like interwiki links, rather than wikitext
Open		None	T132072 Integrate page meta-data as a new content model revision slot for consistency and atomicity
Resolved		None	T51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
Resolved		None	T68108 [Epic] Store media information for files on Wikimedia Commons as structured data
Open	Feature	None	T14963 allow per-page exceptions to spam blacklist
Open		None	T203157 Make the spam whitelist its own slot
Resolved		Halfak	T252280 Improve Wikilabels UI
Open		None	T105518 Make Wiki Labels mobile compatible
Open		None	T104072 Implement single column diff option (from mobile app)
Open	Feature	None	T56140 Move TemplateData to its own JSON-content namespace and associate with Template-namespace, or to its own TemplateData content model and revision slot
Stalled		None	T174043 Deploy Multi-Content Revisions
Open		None	T174022 Implement multi-content revisions
Open		None	T189220 Ensure that relevant extensions are MCR-aware
Open		None	T94370 Implement a mechanism that recognizes syntax errors of wikicode as a Huggle extension
Resolved		Petrb	T57793 Scoring should perhaps take into account added text rather than all text
Open		None	T100082 Provide useful diffs to high-volume consumers of recent changes
Open		None	T56328 Provide intraline diff format in API action=compare
Resolved		tstarling	T339184 MW core diff review/reorg/refactor
Open		None	T202763 Update extensions which customize content diff rendering
Declined		None	T162210 [EPIC] Upstream MobileFrontend components to core and other extensions (tracking)
Resolved	BUG REPORT	Jdlrobson	T238507 MobileFrontend sometimes goes to diff page instead of pending changes review page
Resolved		None	T117279 [EPIC] Core should provide inline diffs as well as side by side (Move InlineDifferenceEngine into core / remove MobileDiff)
Resolved		None	T350181 Enable desktop diff page on mobile site
Resolved		Jdlrobson	T353407 Diff footer is overlaying the text when visual diff is clicked

Event Timeline

Jdlrobson created this task.Dec 14 2023, 12:20 AM

Jdlrobson updated the task description. (Show Details)

Jdlrobson mentioned this in T350181: Enable desktop diff page on mobile site.

Nardog unsubscribed.Dec 14 2023, 12:28 AM

Ciencia_Al_Poder unsubscribed.Dec 14 2023, 8:20 AM

matmarex unsubscribed.Dec 15 2023, 7:09 PM

It also overlaps the article content in a similar way, which leads me to believe that this is a problem with the diff footer, not the visual diff: https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Spain&diff=prev&oldid=534765&diffonly=0&safemode=1

LordProfo unsubscribed.Dec 15 2023, 7:35 PM

Jdlrobson edited projects, added Web-Team-Backlog (Needs Prioritization (Tech)), MediaWiki-Page-diffs, MinervaNeue; removed MobileFrontend.Dec 15 2023, 8:25 PM

Jdlrobson updated the task description. (Show Details)Dec 18 2023, 7:00 PM

Jdlrobson mentioned this in T350637: Cannot access the footer on Minerva diff pages as no way to target styles specific to this page.

ovasileva triaged this task as Medium priority.Dec 19 2023, 8:52 AM

ovasileva edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 1); removed Web-Team-Backlog (Needs Prioritization (Tech)).

ovasileva subscribed.

Change 985051 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Fixes: Diff footer is overlaying the text when visual diff is clicked

https://gerrit.wikimedia.org/r/985051

gerritbot added a project: Patch-For-Review.Dec 21 2023, 10:47 PM

ovasileva moved this task from FY2023-24 Q3 Sprint 1 to FY2023-24 Q3 Sprint 2 on the Web-Team-Backlog board.Jan 4 2024, 1:51 PM

ovasileva edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 2); removed Web-Team-Backlog (FY2023-24 Q3 Sprint 1).

Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team-Backlog (FY2023-24 Q3 Sprint 2) board.Jan 29 2024, 4:43 PM

bwang set the point value for this task to 1.Jan 29 2024, 6:54 PM

Jdlrobson moved this task from Ready for Development to Code Review on the Web-Team-Backlog (FY2023-24 Q3 Sprint 2) board.Jan 29 2024, 7:14 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (FY2023-24 Q3 Sprint 2) board.Jan 30 2024, 12:58 AM

Jdlrobson assigned this task to Edtadros.Jan 30 2024, 1:06 AM

Jdlrobson removed Edtadros as the assignee of this task.Jan 31 2024, 6:09 PM

Jdlrobson moved this task from QA to Code Review on the Web-Team-Backlog (FY2023-24 Q3 Sprint 2) board.

Jdlrobson added a subscriber: Edtadros.

Test Result - Beta

Status: ❌ FAIL
Environment: debeta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Visit https://de.wikipedia.beta.wmflabs.org/w/index.php?title=Chess&diff=31578&diffonly=0&oldid=31385&useskin=minerva
Scroll to chessboard
❌ AC1: ensure it appears below the fixed footer

Sorry the patch didn't get merged yet and I moved it prematurely :(

Change 985051 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Fixes: Diff footer is overlaying the text when visual diff is clicked

https://gerrit.wikimedia.org/r/985051

Jdlrobson assigned this task to Edtadros.Jan 31 2024, 8:50 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (FY2023-24 Q3 Sprint 2) board.

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.17; 2024-02-06).Jan 31 2024, 9:00 PM

Test Result - Beta

Status: ✅ PASS
Environment: debeta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Visit https://de.wikipedia.beta.wmflabs.org/w/index.php?title=Chess&diff=31578&diffonly=0&oldid=31385&useskin=minerva
Scroll to chessboard
✅ AC1: ensure it appears below the fixed footer

Edtadros updated the task description. (Show Details)Feb 6 2024, 5:17 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 6 2024, 5:31 PM

Jdlrobson closed this task as Resolved.Feb 8 2024, 12:44 AM

Jdlrobson claimed this task.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Visit https://en.m.wikipedia.org/w/index.php?title=Chess&diff=prev&oldid=1206943027&title=Chess&diffonly=1
Scroll to an image
✅ AC1: ensure it appears below the fixed footer

Edtadros updated the task description. (Show Details)Feb 13 2024, 10:27 PM

Edtadros mentioned this in T356137: Verify 1.42.0-wmf.17 deployment.Feb 14 2024, 10:54 PM

	F41599644: Screenshot 2023-12-13 at 2.19.20 PM.png
	Dec 14 2023, 12:20 AM

	F41886446: screenshot 500.png
	Feb 13 2024, 10:26 PM

	F41794791: screenshot 430.png
	Feb 6 2024, 5:17 PM

	F41735615: screenshot 419.png
	Jan 31 2024, 7:23 PM

	F41602534: image.png
	Dec 15 2023, 7:13 PM

Diff footer is overlaying the text when visual diff is clickedClosed, ResolvedPublic1 Estimated Story PointsActions

Description

what happens

expected

QA

QA Results - Beta

QA Results - Prod

Details

Related ObjectsSearch...

Event Timeline

Test Result - Beta

QA Steps

Test Result - Beta

QA Steps

Test Result - Prod

QA Steps

Diff footer is overlaying the text when visual diff is clicked
Closed, ResolvedPublic1 Estimated Story Points
Actions

Related Objects
Search...