Page MenuHomePhabricator

Diff footer is overlaying the text when visual diff is clicked
Closed, ResolvedPublic1 Estimated Story Points

Description

what happens

Screenshot 2023-12-13 at 2.19.20 PM.png (998×568 px, 135 KB)

expected

Text should not become transparent.

QA

Visit https://de.wikipedia.beta.wmflabs.org/w/index.php?title=Chess&diff=31578&diffonly=0&oldid=31385&useskin=minerva
Scroll to chessboard
ensure it appears below the fixed footer

QA Results - Beta

ACStatusDetails
1T353407#9518163

QA Results - Prod

ACStatusDetails
1T353407#9540372

Related Objects

StatusSubtypeAssignedTask
Declineddchen
OpenNone
OpenNone
DuplicateNone
OpenFeatureNone
OpenBUG REPORTNone
OpenNone
StalledNone
OpenFeatureNone
DuplicateNone
ResolvedNone
OpenNone
OpenNone
OpenFeatureNone
OpenNone
ResolvedNone
ResolvedNone
OpenFeatureNone
OpenNone
ResolvedHalfak
OpenNone
OpenNone
OpenFeatureNone
StalledNone
OpenNone
OpenNone
OpenNone
ResolvedPetrb
OpenNone
OpenNone
Resolved tstarling
OpenNone
DeclinedNone
ResolvedBUG REPORTJdlrobson
ResolvedNone
ResolvedNone
ResolvedJdlrobson

Event Timeline

It also overlaps the article content in a similar way, which leads me to believe that this is a problem with the diff footer, not the visual diff: https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Spain&diff=prev&oldid=534765&diffonly=0&safemode=1

image.png (2×996 px, 255 KB)

image.png (2×996 px, 223 KB)

Change 985051 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Fixes: Diff footer is overlaying the text when visual diff is clicked

https://gerrit.wikimedia.org/r/985051

bwang set the point value for this task to 1.Jan 29 2024, 6:54 PM
Jdlrobson added a subscriber: Edtadros.

Test Result - Beta

Status: ❌ FAIL
Environment: debeta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Visit https://de.wikipedia.beta.wmflabs.org/w/index.php?title=Chess&diff=31578&diffonly=0&oldid=31385&useskin=minerva
Scroll to chessboard
❌ AC1: ensure it appears below the fixed footer

screenshot 419.png (1×575 px, 156 KB)

Sorry the patch didn't get merged yet and I moved it prematurely :(

Change 985051 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Fixes: Diff footer is overlaying the text when visual diff is clicked

https://gerrit.wikimedia.org/r/985051

Test Result - Beta

Status: ✅ PASS
Environment: debeta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Visit https://de.wikipedia.beta.wmflabs.org/w/index.php?title=Chess&diff=31578&diffonly=0&oldid=31385&useskin=minerva
Scroll to chessboard
✅ AC1: ensure it appears below the fixed footer

screenshot 430.png (896×414 px, 124 KB)

Jdlrobson claimed this task.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Visit https://en.m.wikipedia.org/w/index.php?title=Chess&diff=prev&oldid=1206943027&title=Chess&diffonly=1
Scroll to an image
✅ AC1: ensure it appears below the fixed footer

screenshot 500.png (934×431 px, 126 KB)