Diff tables collapse incorrectly on tablet breakpoint
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Dec 14 2023, 7:23 PM

Description

Steps to replicate the issue (include links if applicable):

What happens?:

Screenshot 2023-12-14 at 9.21.04 AM.png (1×1 px, 195 KB)

What should have happened instead?:

Screenshot 2023-12-14 at 9.22.44 AM.png (902×1 px, 127 KB)

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
There is a conflict between the rules @media screen and (min-width: 720px) .content table tbody { and @media (max-width: 1000px)

Details

	Subject	Repo	Branch	Lines +/-
	Switch to non-compact mode on tablet breakpoint instead of desktop	mediawiki/skins/MinervaNeue	master	+1 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Declined		dchen	T118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
Open		None	T115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
Open		None	T115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
Duplicate		None	T115864 Figure out if the description of the image can be used as the caption on-wiki
Open	Feature	None	T53032 When inserting an image, set its caption by default to be the Commons image description
Open	BUG REPORT	None	T12863 Links on commons upload summaries do not link to commons
Open		None	T5498 Image history is confusing
Stalled		None	T96384 Integrate file revisions with description page history
Open	Feature	None	T39534 Wikimedia Commons should support searching by color
Duplicate		None	T39535 Wikimedia Commons should support filtering by color
Resolved		None	T19503 Provide metadata support on Wikimedia Commons
Open		None	T122038 Moving/Deleting a video file does not move/delete subtitles files, nor does it inform the file mover of their existence
Open		None	T135221 Make TimedText content an integral part of the File page
Open	Feature	None	T2167 Use a dedicated interface for adding meta-data like interwiki links, rather than wikitext
Open		None	T132072 Integrate page meta-data as a new content model revision slot for consistency and atomicity
Resolved		None	T51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
Resolved		None	T68108 [Epic] Store media information for files on Wikimedia Commons as structured data
Open	Feature	None	T14963 allow per-page exceptions to spam blacklist
Open		None	T203157 Make the spam whitelist its own slot
Resolved		Halfak	T252280 Improve Wikilabels UI
Open		None	T105518 Make Wiki Labels mobile compatible
Open		None	T104072 Implement single column diff option (from mobile app)
Open	Feature	None	T56140 Move TemplateData to its own JSON-content namespace and associate with Template-namespace, or to its own TemplateData content model and revision slot
Stalled		None	T174043 Deploy Multi-Content Revisions
Open		None	T174022 Implement multi-content revisions
Open		None	T189220 Ensure that relevant extensions are MCR-aware
Open		None	T94370 Implement a mechanism that recognizes syntax errors of wikicode as a Huggle extension
Resolved		Petrb	T57793 Scoring should perhaps take into account added text rather than all text
Open		None	T100082 Provide useful diffs to high-volume consumers of recent changes
Open		None	T56328 Provide intraline diff format in API action=compare
Resolved		tstarling	T339184 MW core diff review/reorg/refactor
Open		None	T202763 Update extensions which customize content diff rendering
Declined		None	T162210 [EPIC] Upstream MobileFrontend components to core and other extensions (tracking)
Resolved	BUG REPORT	Jdlrobson	T238507 MobileFrontend sometimes goes to diff page instead of pending changes review page
Resolved		None	T117279 [EPIC] Core should provide inline diffs as well as side by side (Move InlineDifferenceEngine into core / remove MobileDiff)
Resolved		None	T350181 Enable desktop diff page on mobile site
Resolved	BUG REPORT	Jdlrobson	T353478 Diff tables collapse incorrectly on tablet breakpoint

Event Timeline

Jdlrobson created this task.Dec 14 2023, 7:23 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 14 2023, 7:23 PM

Jdlrobson added a parent task: T350181: Enable desktop diff page on mobile site.Dec 14 2023, 7:24 PM

Change 983282 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] Remove unnecessary MobileFrontend diff hook

https://gerrit.wikimedia.org/r/983282

gerritbot added a project: Patch-For-Review.Dec 15 2023, 1:10 AM

Jdlrobson triaged this task as High priority.Dec 15 2023, 1:29 AM

Change 983284 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Make the diff legend responsive

https://gerrit.wikimedia.org/r/983284

Change 983285 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Add a legend label to the diff legend

https://gerrit.wikimedia.org/r/983285

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/cf5f8b47bb/w

Jdlrobson added a subscriber: JSengupta-WMF.Dec 15 2023, 1:44 AM

This comment was removed by Jdlrobson.

Jdlrobson assigned this task to JSengupta-WMF.Dec 15 2023, 1:44 AM

Hi, Am I looking at the mobile resolution? As far as I remember, mobile web was out of scope. when I look at it on mobile it shows different color and the feature is not available. However, if I open it on desktop and reduce the resolution to mobile, the legends go from top to bottom. I was wondering if it's possible to keep the legends still on the top. In case the diffs are too long, the user has to scroll all the way to the end to read them.

Sorry I put my patch and comment on the wrong ticket. Moving to correct one (T353479) and I will reply there.

Jdlrobson removed JSengupta-WMF as the assignee of this task.Dec 15 2023, 4:56 PM

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/0c6936f0ca/w

Jdlrobson mentioned this in T353479: Diff legend does not display in mobile HTML.Dec 15 2023, 5:19 PM

Change 983458 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Switch to non-compact mode on tablet breakpoint instead of desktop

https://gerrit.wikimedia.org/r/983458

Change 983458 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Switch to non-compact mode on tablet breakpoint instead of desktop

https://gerrit.wikimedia.org/r/983458

I have verified the fix on the beta cluster.

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.12; 2024-01-02).Dec 20 2023, 8:01 PM

Test wiki on Patch demo by Jdlrobson using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/cf5f8b47bb/w/~~

Test wiki on Patch demo by Jdlrobson using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/0c6936f0ca/w/~~

	F41601206: Screenshot 2023-12-14 at 3.43.31 PM.png
	Dec 15 2023, 1:44 AM

	F41601203: Screenshot 2023-12-14 at 3.39.11 PM.png
	Dec 15 2023, 1:44 AM

	F41600840: Screenshot 2023-12-14 at 9.22.44 AM.png
	Dec 14 2023, 7:23 PM

	F41600836: Screenshot 2023-12-14 at 9.21.04 AM.png
	Dec 14 2023, 7:23 PM

Diff tables collapse incorrectly on tablet breakpointClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related ObjectsSearch...

Event Timeline

Diff tables collapse incorrectly on tablet breakpoint
Closed, ResolvedPublicBUG REPORT
Actions

Related Objects
Search...