Page MenuHomePhabricator

Wrong digit on bnwiki mobile diff
Closed, ResolvedPublic

Description

On bnwiki mobile diff, mediawiki used to show "X ago" using Bengali digit. Recently i am started to seeing it in English.

Steps to replicate the issue:

  • View any diff on bnwiki (make sure you are using mobile view & logged in)
    • E.g. this, notice it's showing 3 মাস আগে (3 months ago) instead of ৩ মাস আগে

bnwiki.png (560×488 px, 35 KB)

  • If you view the same link while logged out, it correctly shows ৩ মাস আগে

QA Results - Prod

ACStatusDetails
1T357079#9540354

Related Objects

StatusSubtypeAssignedTask
Declineddchen
OpenNone
OpenNone
DuplicateNone
OpenFeatureNone
OpenBUG REPORTNone
OpenNone
StalledNone
OpenFeatureNone
DuplicateNone
ResolvedNone
OpenNone
OpenNone
OpenFeatureNone
OpenNone
ResolvedNone
ResolvedNone
OpenFeatureNone
OpenNone
ResolvedHalfak
OpenNone
OpenNone
OpenFeatureNone
StalledNone
OpenNone
OpenNone
OpenNone
ResolvedPetrb
OpenNone
OpenNone
Resolvedtstarling
OpenNone
DeclinedNone
ResolvedBUG REPORTJdlrobson
ResolvedNone
ResolvedNone
ResolvedJdlrobson

Event Timeline

Change 999927 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Diffs: Localize number in timeago

https://gerrit.wikimedia.org/r/999927

Change 999927 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Diffs: Localize number in timeago

https://gerrit.wikimedia.org/r/999927

Change 1002438 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@wmf/1.42.0-wmf.17] Diffs: Localize number in timeago

https://gerrit.wikimedia.org/r/1002438

Change 1002438 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@wmf/1.42.0-wmf.17] Diffs: Localize number in timeago

https://gerrit.wikimedia.org/r/1002438

Mentioned in SAL (#wikimedia-operations) [2024-02-12T21:57:57Z] <cjming@deploy2002> Started scap: Backport for [[gerrit:1002437|Make thanks button show again (T357202)]], [[gerrit:1002438|Diffs: Localize number in timeago (T357079)]]

Mentioned in SAL (#wikimedia-operations) [2024-02-12T21:59:16Z] <cjming@deploy2002> cjming and jdlrobson: Backport for [[gerrit:1002437|Make thanks button show again (T357202)]], [[gerrit:1002438|Diffs: Localize number in timeago (T357079)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-02-12T22:07:14Z] <cjming@deploy2002> Finished scap: Backport for [[gerrit:1002437|Make thanks button show again (T357202)]], [[gerrit:1002438|Diffs: Localize number in timeago (T357079)]] (duration: 09m 17s)

Jdlrobson claimed this task.

Now fixed. Thanks for the report!

Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: bnwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

View any diff on bnwiki (make sure you are using mobile view & logged in)
✅ AC1: the digit in n months ago should be in Bengali.

screenshot 499.png (955×449 px, 124 KB)