Page MenuHomePhabricator

Thanks button missing from mobile diff
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

Any diff view (on mobile) no longer shows the thanks button (since recent hotfix). For instance https://en.m.wikipedia.org/w/index.php?title=Wikipedia:Main_Page/Errors&curid=13207787&diff=1205708515&oldid=1205627551&title=Wikipedia%3AMain_Page%2FErrors&diffonly=1 shows the username, edit count, but there was previously a button for giving thanks.

Other places where you can give thanks, such as the edit history of an article still appears.

What happens?: There is now no "thanks" button on an edit contribution on mobile.

What should have happened instead?: the thanks button should appear.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
Android - Samsung Galaxy S21.

QA Results - Prod

ACStatusDetails
1T357202#9540345

Event Timeline

Nardog renamed this task from Thanks button missing - contribution mobile view to Thanks button missing from mobile diff.Sat, Feb 10, 8:49 AM
Nardog renamed this task from Thanks button missing from mobile diff to Thanks button missing - contribution mobile view.
Nardog updated the task description. (Show Details)
Nardog updated the task description. (Show Details)
Nardog renamed this task from Thanks button missing - contribution mobile view to Thanks button missing from mobile diff.Sat, Feb 10, 8:53 AM
Nardog updated the task description. (Show Details)

Other buttons are not showing up either, i.e. "Mark as patrolled" (for users with the "patrol" user right in wikis with $wgUseRCPatrol set to true).

Strange. If I click use desktop site in browser it shows.

Screenshot_20240210_075613_Chrome.jpg (2×1 px, 567 KB)

I will look into this on Monday. Thanks for the report!

If I click use desktop site in browser it shows.

It gets hidden when the viewport is <720px wide. The z-index here is too low.

Other buttons are not showing up either, i.e. "Mark as patrolled" (for users with the "patrol" user right in wikis with $wgUseRCPatrol set to true).

"Mark as patrolled" doesn't appear when viewing a diff on desktop either so I doubt it should on mobile. What are the "other buttons" you allude to?

Other buttons are not showing up either, i.e. "Mark as patrolled" (for users with the "patrol" user right in wikis with $wgUseRCPatrol set to true).

"Mark as patrolled" doesn't appear when viewing a diff on desktop either so I doubt it should on mobile. What are the "other buttons" you allude to?

Are you testing it on enwiki? It has $wgUseRCPatrol disabled. "Mark as patrolled" used to show up on itwiki even on mobile (and it still shows on desktop). You need a wiki with $wgUseRCPatrol = true and have the patrol user right to test it.

EDIT: You can check it on any of these Wikidata diffs if you're at least autoconfirmed.

This looks like a simple fix as @Nardog says - the z-index appears to be incorrect (1) it should be 2:

.mw-diff-tool { z-index: 2 !important; }

If someone has time to push a fix over the weekend I can make sure this gets merged and backported Monday (otherwise I'll have to chase a code reviewer :-)).

Change 1002587 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Make thanks button show again

https://gerrit.wikimedia.org/r/1002587

Change 1002587 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Make thanks button show again

https://gerrit.wikimedia.org/r/1002587

Change 1002437 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@wmf/1.42.0-wmf.17] Make thanks button show again

https://gerrit.wikimedia.org/r/1002437

After pulling in the latest versions of everything, I'm still not seeing the thanks button on visual diffs. I may have only checked on the text diff. We'll need a follow-up patch to address the visual diffs.
{F41870902}

ah, it looks like we're also covering long usernames.

localhost_8080_w_index.php_title=Main_Page&diff=prev&oldid=248&diffonly=1.png (1×600 px, 85 KB)

After pulling in the latest versions of everything, I'm still not seeing the thanks button on visual diffs. I may have only checked on the text diff. We'll need a follow-up patch to address the visual diffs.
{F41870902}

It looks like

[data-diff-action='insert'], [data-diff-action='remove'], [data-diff-action='change-insert'], [data-diff-action='change-remove'], [data-diff-move] {
    position: relative;
    z-index: 1;
}

is the culprit

Change 1002437 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@wmf/1.42.0-wmf.17] Make thanks button show again

https://gerrit.wikimedia.org/r/1002437

Mentioned in SAL (#wikimedia-operations) [2024-02-12T21:57:57Z] <cjming@deploy2002> Started scap: Backport for [[gerrit:1002437|Make thanks button show again (T357202)]], [[gerrit:1002438|Diffs: Localize number in timeago (T357079)]]

Mentioned in SAL (#wikimedia-operations) [2024-02-12T21:59:16Z] <cjming@deploy2002> cjming and jdlrobson: Backport for [[gerrit:1002437|Make thanks button show again (T357202)]], [[gerrit:1002438|Diffs: Localize number in timeago (T357079)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-02-12T22:07:14Z] <cjming@deploy2002> Finished scap: Backport for [[gerrit:1002437|Make thanks button show again (T357202)]], [[gerrit:1002438|Diffs: Localize number in timeago (T357079)]] (duration: 09m 17s)

Jdlrobson claimed this task.

Now fixed everywhere.
Created https://phabricator.wikimedia.org/T357352 for visual diff.

Edtadros added a subscriber: Edtadros.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Go to a diff view (on mobile) https://en.m.wikipedia.org/w/index.php?title=Wikipedia:Main_Page/Errors&curid=13207787&diff=1205708515&oldid=1205627551&title=Wikipedia%3AMain_Page%2FErrors&diffonly=1
✅ AC1: the thanks button should appear.

screenshot 498.png (949×450 px, 115 KB)