Page MenuHomePhabricator

Special:MobileDiff doesn't correctly handle diff=0 if the diff would cover multiple revisions
Open, Stalled, LowPublic

Description

When clicking the "all changes" diff link in an email notification and being taken to the mobile site (e.g. by clicking the link from a mobile device), if the diff would cover multiple revisions, the diff shown is with the next-older revision instead.

For example:

  1. Page "Foobar" has revisions 1, 2, 3, 4, and 5.
  2. I last viewed "Foobar" while logged in after revision 3 was saved.
  3. I get an email notification for the new edit when revision 4 is saved, and before I check it, revision 5 is also saved.
  4. I click the "all changes" link, expecting to get a diff that compares revision 3 (the last one I viewed) and revision 5 (the most recent one)
  5. Instead I get a diff that compares revisions 2 and 3.

Note that this also happens if you click the link and view the diff on the desktop version of the site, and then click the "Mobile view" link in the page footer.

Example diff: https://yugipedia.com/index.php?title=Vol.1_(DM5)&diff=0&oldid=4070535
Mobile diff: https://yugipedia.com/wiki/Special:MobileDiff/4070535

Related Objects

StatusSubtypeAssignedTask
Declineddchen
OpenNone
OpenNone
DuplicateNone
OpenNone
OpenNone
OpenNone
OpenNone
DuplicateNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
Resolvedppelberg
ResolvedKrinkle
OpenNone
OpenNone
OpenNone
ResolvedHalfak
OpenNone
OpenNone
StalledNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
ResolvedPetrb
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
StalledNone

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 6 2019, 1:43 AM
Dinoguy1000 renamed this task from Special:MobileDiff compares the wrong revisions when clicking a multi-revision diff link to Special:MobileDiff doesn't correctly handle diff=0 if the diff would cover multiple revisions.May 6 2019, 1:48 AM
ovasileva triaged this task as Medium priority.May 8 2019, 3:35 PM
Jdlrobson lowered the priority of this task from Medium to Low.Jul 8 2019, 8:57 PM
Jdlrobson added a subscriber: Jdlrobson.

The page has bugs but it would be in our interest to work out the future of this code before bug fixing further.

Of course; I wasn't aware of any potential plans to retire MobileDiff when I filed this bug report. If it's just going away, then this probably isn't worth fixing. =)

Jdlrobson moved this task from Backlog to Team: web on the MobileFrontend board.Fri, Jul 24, 3:00 PM
Jdlrobson changed the task status from Open to Stalled.Mon, Jul 27, 10:39 PM

Stalled on T117279