Page MenuHomePhabricator

Move blue links on user page
Closed, ResolvedPublic1 Story Points

Description

Description

For user pages, to resolve the awkwardness with the blue links at the top and the new AMC Article/Talk tabs, let's move the blue links below the toolbar:

QA instructions

Environment: staging
Browser & device: mobile, iOS & Android, all browsers
Skin: MFE/Minerva
Steps:

Acceptance criteria

  • The blue links should appear below the toolbar for all user pages (not just AMC mode)

QA Results

StatusDetails))
✅ PASST214697#4970835

QA Results:Production (eswiki)

StatusDetails))
✅ PASST214697#5064741

Details

Related Gerrit Patches:
mediawiki/skins/MinervaNeue : masterUser actions below page actions

Event Timeline

alexhollender triaged this task as High priority.Jan 25 2019, 3:08 PM
alexhollender created this task.
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptJan 25 2019, 3:08 PM
Jdlrobson removed the point value for this task.Jan 25 2019, 9:45 PM
Jdlrobson awarded a token.
Jdlrobson set the point value for this task to 1.Feb 5 2019, 5:18 PM

Change 490388 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] User actions below page actions

https://gerrit.wikimedia.org/r/490388

alexhollender updated the task description. (Show Details)
alexhollender updated the task description. (Show Details)

Looks good ⭐️

Jdlrobson removed Edtadros as the assignee of this task.Feb 13 2019, 8:31 PM
Jdlrobson added a subscriber: Edtadros.

Hang on. It's not been merged yet @alexhollender :)

Change 490388 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] User actions below page actions

https://gerrit.wikimedia.org/r/490388

Edtadros added a comment.EditedFeb 21 2019, 7:31 AM

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome DevTools Device Emulator (iPhone X)

Test Artifact(s):

https://reading-web-staging.wmflabs.org/wiki{F28258276}/User:Jdlrobson

AMC Mode :

Non-AMC Mode:

Not logged in:

Edtadros updated the task description. (Show Details)Feb 21 2019, 7:32 AM
Edtadros reassigned this task from Edtadros to Jdlrobson.Feb 21 2019, 7:34 AM

@Jdlrobson , I want to be sure before I pass this. The AC states " This should be for all user pages (not just AMC mode)". I tried a few other user pages but none of them had the links. Did you mean that this should work for the specific page in the task description but for all scenarios (AMC on, AMC off, and not logged in)?

...
Non-AMC Mode:

For completeness: @Edtadros the above screenshot looks like it's from AMC mode (the User page / Discussion tab shouldn't appear when AMC is off).

This is what I see for non-AMC mode logged in on RWS (reading web staging):

@alexhollender good catch. QA the QA! I will update the test results with the correct screenshot.
@Jdlrobson I'm seeing the same thing.

ovasileva closed this task as Resolved.Feb 21 2019, 6:26 PM

Looks good, thanks all.

Edtadros added a comment.EditedMar 28 2019, 4:35 AM

Test Result:Production

Status: ✅ PASS
OS: iOS
Browser: Chrome browser on (iPhone XS Max)

Test Artifact(s):

AMC Mode :

Non-AMC Mode:

Not logged in:

Edtadros updated the task description. (Show Details)Mar 28 2019, 7:42 AM