Change 489010 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] page actions is no longer position absolute

https://gerrit.wikimedia.org/r/489010

Change 483637 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Talk tabs in AMC mode

https://gerrit.wikimedia.org/r/483637

Change 489011 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Remove backwards compatible CSS

https://gerrit.wikimedia.org/r/489011

Change 490396 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Talk tab select should sit on top of page actions

https://gerrit.wikimedia.org/r/490396

This has been design reviewed. As long as no code changes it can go straight to QA.

Change 490396 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Talk tab select should sit on top of page actions

https://gerrit.wikimedia.org/r/490396

Test Result

OS: macOS Mojave
Browser: Chrome DevTools Device Emulator (iPhone X)

Test Artifact(s):

AC1: ✅ PASS
For any page that has a talk page, the navigation will display two tabs: primary and talk/discussion
AMC Off:

AC2: ✅ PASS
For pages that have an empty talk page, the talk page tab will still be displayed (no red link)
AMC Off:

AC3: ✅ PASS
The new talk tab will behave exactly like the existing "Talk" button at the bottom of the page. The new link should be a link to the talk page and open the talk overlay when clicked. ie. No changes will be made to the existing behaviour of the button
AMC on/off with no Talk page:

AC4: ✅ PASS
Naming - the text on each tab will be the text appearing on the desktop versions of the page based on project, language, and namespace.
For example, the WP namespace will have tabs that read “project page” and “talk”
For pages that do not have a talk page, no second tab will be displayed.
For example, Special:SpecialPages will only have the default tab “Special page”
Verified a number of pages. This artifact is representative of the sample:

AC5: ❌ FAIL
Make sure Return to "Sandwich" page. is removed from the bottom of https://en.m.wikipedia.org/wiki/Talk:Sandwich for advanced mobile contribution users (now we have a tab at the top of the page this is redundant). It should continue to display in non-AMC mode.
This was the same in staging at the URL above:

AC6: ⬜ Unable to test
the tabs will appear under wikidata descriptions
//Note: Could not find a page on staging with wikidata descriptions.

AC7: ⬜ Unable to test
The new functionality is present for logged in enabled client Minerva, logged in enabled server Minerva; the old functionality is maintained for logged in disabled client Minerva, logged in disabled server Minerva, logged out client, logged out server.

AC8: ✅ PASS
For pages that do not exist, the landing page will be the main (article) page and the talk page tab will display as in all other cases above.
AMC Off:

AC9:⬜ Unable to test
verify that Wikipedia:New_user_landing_page flow still works properly
//Need more info.

In T212216#4983586, @Edtadros wrote:

@Jdlrobson please see my comments on the items that were Unable to test. There is one Fail that I didn't catch in my first pass until I delved into the Acceptance Criteria a bit more.

Not sure why but the test link was on production. Either way, I was able to reproduce on staging:

Thanks @ovasileva. I was curious why the link was for production. I did test it in Staging as well but only made a reference to that above the image of prod.

Change 493089 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Return to link is not needed in AMC mode on talk pages

https://gerrit.wikimedia.org/r/493089

Above patch will drop the "Return to link" for AMC users.

Change 493089 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Return to link is not needed in AMC mode on talk pages

https://gerrit.wikimedia.org/r/493089

AC5: ✅ PASS
Make sure Return to "Sandwich" page. is removed from the bottom of the Talk:Sandwich page for advanced mobile contribution users (now we have a tab at the top of the page this is redundant). It should continue to display in non-AMC mode.

Non-AMC:

AMC:

Use http://en-reading-web-staging.wmflabs.org/w/index.php?title=T173949&mobileaction=beta
Make sure you are in beta AND AMC.

Test Result

OS: iOS 12.1.4
Browser: Safari
Device: iPhone XS Max

Test Artifact(s):*AC6:** ✅ PASS
the tabs will appear under wikidata descriptions

@Edtadros, I've revised the QA steps

=== Test Result

AC7

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome DevTools Device Emulator (iPhone X)

Test Artifact(s):
AMC is both available AND active when logged in, the AMC toggle is on, AND JavaScript is disabled (server) OR enabled (client) on the mobile Minerva skin.
JS Disabled:

AMC is both unavailable AND inactive (identical to today's production) when not logged in AND JavaScript is disabled (server) OR enabled (client) on both the mobile Minerva skin AND desktop Vector skin.
JS Disabled:

JS Enabled:

AMC is both available AND inactive when logged in, the AMC toggle is off, AND JavaScript is disabled (server) OR enabled (client) on the mobile Minerva skin.//**
JS Disabled:

JS Enabled:

AMC is both unavailable AND inactive (identical to today's production) when not logged in AND JavaScript is disabled (server) OR enabled (client) on both the mobile Minerva skin AND desktop Vector skin.
JS Enabled

This looks like a bug to me. Where is the discussion button?

Test Result

Status: ✅ PASS
Worked with @pmiazga to test this.

Test Artifact(s):
AC9:verify that Wikipedia:New_user_landing_page flow still works properly*

@Niedzielski the Discussion button does show up when logged in. That screenshot was for the case where the user was logged in, AMC was disabled, and JS was enabled. Should this go back to Needs More Work?

@Edtadros, my mistake! Looks good to me @Edtadros

Test Results: Production

OS: iOS
Browser: Chrome for iOS

Test Artifact(s):

AC1:
For any page that has a talk page, the navigation will display two tabs: primary and talk/discussion
AC1.1 AMC Off:

eswiki: ✅	arwiki: ✅	idwiki: ✅

AC1.2 AMC On:

eswiki: ✅	arwiki: ✅	idwiki: ✅

AC2:
For pages that have an empty talk page, the talk page tab will still be displayed (no red link)
AC2.1 AMC Off:

eswiki: ✅	arwiki: ✅	idwiki: ✅

AC2.2 AMC On:

eswiki: ✅	arwiki: ✅	idwiki: ✅

AC3:
The new talk tab will behave exactly like the existing "Talk" button at the bottom of the page. The new link should be a link to the talk page and open the talk overlay when clicked. ie. No changes will be made to the existing behaviour of the button
AC3.1 AMC on/off with no Talk page:

eswiki: ✅	arwiki: ✅	idwiki: ✅

AC3.2 AMC on/off with Talk page:

eswiki: ✅	arwiki: ✅	idwiki: ✅

AC4:
Naming - the text on each tab will be the text appearing on the desktop versions of the page based on project, language, and namespace.
For example, the WP namespace will have tabs that read “project page” and “talk”
For pages that do not have a talk page, no second tab will be displayed.
For example, Special:SpecialPages will only have the default tab “Special page”
Verified a number of pages. This artifact is representative of the sample:

eswiki: ✅	arwiki: ✅	idwiki: ✅

AC5:
AC5.1 Make sure Return to "Sandwich" page. is removed from the bottom of https://en.m.wikipedia.org/wiki/Talk:Sandwich for advanced mobile contribution users (now we have a tab at the top of the page this is redundant).

eswiki: ✅	arwiki: ✅	idwiki: ✅

AC5.2 It should continue to display in non-AMC mode.

eswiki: ✅	arwiki: ✅	idwiki: ✅

AC6:
the tabs will appear under wikidata descriptions

eswiki: ✅	arwiki: ✅	idwiki: ✅

AC7:
The new functionality is present for logged in enabled client Minerva, logged in enabled server Minerva; the old functionality is maintained for logged in disabled client Minerva, logged in disabled server Minerva, logged out client, logged out server.

AC7.1 Logged In with JS off

eswiki: ✅	arwiki: ✅	idwiki: ✅

AC7.2 Not Logged in with JS off

eswiki: ✅	arwiki: ✅	idwiki: ✅

AC7.3 Logged In with JS off and AMC ON

eswiki: ✅	arwiki: ✅	idwiki: ✅

AC8: ✅ PASS
For pages that do not exist, the landing page will be the main (article) page and the talk page tab will display as in all other cases above.
AC8.1 AMC Off:

eswiki: ✅	arwiki: ✅	idwiki: ✅

AC8.2 AMC On:

eswiki: ✅	arwiki: ✅	idwiki: ✅

AC9:⬜ Out of Scope
verify that Wikipedia:New_user_landing_page flow still works properly

This is not in scope for eswiki, arwiki, or idwiki.

Per @pmiazga:
that page is provided by ArticleCreationWorkflow extension
https://www.mediawiki.org/wiki/Extension:ArticleCreationWorkflow
and
per https://raw.githubusercontent.com/wikimedia/operations-mediawiki-config/master/wmf-config/InitialiseSettings.php it's used

'wmgUseArticleCreationWorkflow' => [
    'default' => false,
    'testwiki' => true,
    'test2wiki' => true, // T175302
    'enwiki' => true, // T192455
],

Unable to get to page in Arabic.

For future reference, this is actually possible via https://ar.m.wikipedia.beta.wmflabs.org/w/index.php?title=%D8%B1%D9%82%D9%85_%D8%B3%D9%88%D8%B1%D8%A9&mobileaction=toggle_view_mobile URL

@Jdlrobson I get a very brief popup from the bottom, but it goes away. I've tried clicking it, it does nothing. Is it possible to get it in production?

@pmiazga please go to the very bottom of T212216#5047451 the only item remaining to test is AC9 for Arabic. You helped me test it before. It appears we are looking for a page with the discussion tab and project page tab, but I'm not entirely sure.

@pmiazga thanks for clarifying this. I have updated T212216#5047451 with the info you provided.