Page MenuHomePhabricator

Reduce startup registry footprint of WikibaseMediaInfo
Closed, ResolvedPublic

Description

While the extension only has one or two entry points for client-side code, it has many more modules registered internally. This is a left-over from how Wikibase misunderstood how modules wok in ResourceLoader.

These internal modules are all publicly registered via the JS-startup of all page views on Commons. This metadata has to download, parse, and execute before any interactive features can start to load.

Modules that are only references internally should be merged into the respective module bundles that are actual entry points, and/or in shared bundles used by multiple entry points.

More about this general issue at T202154. See also "Size of scripts" at https://www.mediawiki.org/wiki/Wikimedia_Performance_Team/Page_load_performance.

Event Timeline

Krinkle triaged this task as High priority.Feb 20 2019, 7:07 PM
Krinkle created this task.

Change 491468 had a related patch set uploaded (by Krinkle; owner: Jforrester):
[mediawiki/extensions/WikibaseMediaInfo@master] extensions: Collapse the wikibase.mediainfo module into its only caller

https://gerrit.wikimedia.org/r/491468

Change 491470 had a related patch set uploaded (by Krinkle; owner: Jforrester):
[mediawiki/extensions/WikibaseMediaInfo@master] Drop the now-unused ViewMediaInfoAction class and related RL modules

https://gerrit.wikimedia.org/r/491470

Change 491473 had a related patch set uploaded (by Krinkle; owner: Jforrester):
[mediawiki/extensions/WikibaseMediaInfo@master] Scrap the wikibase.mediainfo.datamodel.MediaInfo pointless module

https://gerrit.wikimedia.org/r/491473

Change 491468 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Collapse the wikibase.mediainfo RL module into its only caller

https://gerrit.wikimedia.org/r/491468

Change 491470 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Drop the now-unused ViewMediaInfoAction class and related RL modules

https://gerrit.wikimedia.org/r/491470

Change 491473 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Scrap the wikibase.mediainfo.datamodel.MediaInfo pointless module

https://gerrit.wikimedia.org/r/491473

Jdforrester-WMF removed a project: Patch-For-Review.

Should all roll out to production in wmf.19 except for the final removal of wikibase.mediainfo.filepagestyles, which will be in a few weeks' time.

Leaving to Krinkle to declare this is done.