Page MenuHomePhabricator

Toggle state in WikiEditor toolbar is not obvious
Open, Needs TriagePublic

Description

The toggle state for syntax highlighting in the WikiEditor toolbar is very subtle (slight change in icon colour and faint border). Could this be improved to be more obvious? It has caused confusion at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Syntax_highlighting (permalink).

Off:

On:

Event Timeline

Pcoombe created this task.Feb 27 2019, 12:28 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 27 2019, 12:28 AM
Jorm added a subscriber: Jorm.Feb 27 2019, 12:40 AM
Pcoombe updated the task description. (Show Details)Feb 27 2019, 12:46 AM

My, that's subtle.

I can't imagine this being functional for any person with limited vision. @Volker_E, do you have the set of low-vision glasses at your desk, so that people in the office can see how awkward that is?

Volker_E added a subscriber: TheDJ.EditedFeb 27 2019, 1:50 AM

@Whatamidoing-WMF That is actually true, I've got some. :) Although that change came from @TheDJ, who I haven't seen in the new office yet. In his defense, he has introduced 'active' state of Wikieditor toobar tools at all. Wikieditor didn't know concept for such state before!
Compare for example 'bold' button, there's no active state.

One way out were to give the toolbar more of a unified appearance as in T174119. But that would probably need more community consultation to move forward…

Izno added a subscriber: Izno.Feb 27 2019, 5:31 AM

i'll slap on whatever css needed if someone hands me a design that isn't 'change all the things'. ;)

TheDJ added a comment.EditedFeb 27 2019, 10:35 AM

P.S. Toggle state was the result of work from: T198781: Add toggle/state buttons to WikiEditor

Visually it's simply the hover/pressed state of any of the other buttons, right now.