Page MenuHomePhabricator
Create Task
Maniphest T217220

Post-inheritance cleanup
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

During the work to remove inheritance we left backwards compatible functions for caching.
After all the migrations have been completed and 2 weeks have passed we will remove the following:

  • mobile.languages.structured/LanguageOverlay
  • mobile.talk.overlays/talkOverlay
  • categories
  • languages

developer notes

Drop anything that is @deprecated either via moduleLoader and/or jsdoc tag

Details

SubjectRepoBranchLines +/-
💥 Breaking change: Remove deprecated methods/modulesmediawiki/extensions/MobileFrontendmaster+15 -95
Do not use pass the "string" (deprecated parameter) to toast show methodmediawiki/skins/MinervaNeuemaster+1 -1
Remove temporary function from mobile.languages.structured.jsmediawiki/extensions/MobileFrontendmaster+7 -25
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Feb 27 2019, 1:18 AM
gerritbot subscribed.Feb 27 2019, 1:19 AM

Change 492206 had a related patch set uploaded (by Jdlrobson; owner: Nray):
[mediawiki/extensions/MobileFrontend@master] Remove temporary function from mobile.languages.structured.js

https://gerrit.wikimedia.org/r/492206

gerritbot added a project: Patch-For-Review.Feb 27 2019, 1:19 AM
Jdlrobson added a project: Web-Team-Backlog (Tracking).Feb 27 2019, 1:19 AM
phuedx unsubscribed.Feb 27 2019, 12:01 PM
• Jhernandez unsubscribed.Feb 27 2019, 1:00 PM
gerritbot added a comment.Mar 7 2019, 12:19 AM

Change 492206 abandoned by Jdlrobson:
Remove temporary function from mobile.languages.structured.js

Reason:
Let's do this in a batch job along with the talk overlay and other changes as part of https://phabricator.wikimedia.org/T217220

Abandoning until that gets scheduled (we can restore then!).

https://gerrit.wikimedia.org/r/492206

Jdlrobson moved this task from Backlog to Review and refactor components on the MobileFrontend (MobileFrontend and MinervaNeue architecture) board.Mar 8 2019, 8:03 PM
Jdlrobson triaged this task as High priority.Apr 11 2019, 9:40 PM
Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Tracking).
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Incoming to Upcoming on the Web-Team-Backlog board.
ovasileva set the point value for this task to 2.Apr 16 2019, 4:42 PM
ovasileva edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4); removed Web-Team-Backlog.Apr 17 2019, 5:07 PM
Jdlrobson moved this task from To Do to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.Apr 23 2019, 2:47 PM
gerritbot added a comment.Apr 23 2019, 2:50 PM

Change 505785 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Do not use deprecated toast show parameter

https://gerrit.wikimedia.org/r/505785

gerritbot added a comment.Apr 23 2019, 2:56 PM

Change 505786 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] 💥 Breaking change: Remove deprecated methods/modules

https://gerrit.wikimedia.org/r/505786

Jdlrobson moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.Apr 23 2019, 2:56 PM
pmiazga moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.Apr 29 2019, 5:13 PM
gerritbot added a comment.May 1 2019, 6:25 PM

Change 505785 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Do not use pass the "string" (deprecated parameter) to toast show method

https://gerrit.wikimedia.org/r/505785

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.4; 2019-05-07).May 1 2019, 7:00 PM
Jdlrobson moved this task from Needs More Work to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.May 1 2019, 7:02 PM
gerritbot added a comment.May 2 2019, 6:05 PM

Change 505786 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] 💥 Breaking change: Remove deprecated methods/modules

https://gerrit.wikimedia.org/r/505786

Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.May 2 2019, 6:32 PM
Jdlrobson assigned this task to phuedx.May 6 2019, 5:06 PM
phuedx updated the task description. (Show Details)May 8 2019, 4:40 PM
phuedx closed this task as Resolved.May 8 2019, 4:44 PM

This LGTM.

Re:

Drop anything that is @deprecated either via moduleLoader and/or jsdoc tag

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits