| Jdlrobson | |
| Mar 19 2019, 7:42 PM |
| F28656482: Screen Shot 2019-04-14 at 3.43.55 PM.png | |
| Apr 14 2019, 10:52 PM |
| F28656484: T218731-1.png | |
| Apr 14 2019, 10:52 PM |
| F28485491: Screen Shot 2019-03-27 at 1.29.07 PM.png | |
| Mar 27 2019, 5:34 PM |
| F28485482: IMG_0157.PNG | |
| Mar 27 2019, 5:34 PM |
| F28485487: IMG_0159.PNG | |
| Mar 27 2019, 5:34 PM |
| F28485490: Screen Shot 2019-03-27 at 1.29.48 PM.png | |
| Mar 27 2019, 5:34 PM |
| F28437092: Screen Shot 2019-03-21 at 8.12.49 AM.png | |
| Mar 21 2019, 3:14 PM |
| F28424215: Screen Shot 2019-03-19 at 10.53.51 PM.png | |
| Mar 20 2019, 6:02 AM |
Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Notifications#/notifications
On mobile:
On desktop:
Compare with production:
Expected:
| Status | Details |
| ✅ Passed | T218731#5110101 |
Change 497597 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Fix positioning and size of mark all as read button in NotificationOverlay
Change 497597 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Fix positioning and size of mark all as read button in NotificationOverlay
Status: Need More Info
OS: macOS Mojave
Browser: Chrome DevTools Device Emulator (iPhone X)
Test Artifact(s):
Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Notifications#/notifications on desktop and confirm it matches (or improves the display) on production.
Resize browser to check mobile looks the same as well
@Jdlrobson I feel like this should fail. In Beta the button appears to bleed into the right edge of the screen. The expectation is that it is right aligned. Objectively this could satisfy the requirement. However, subjectively it doesn't look right. The buttons function correctly.
In Beta the button appears to bleed into the right edge of the screen. The expectation is that it is right aligned.
Yeh your screenshot definitely looks better but right now i'm seeing bleeding on enwiki too.
That said it looks even better without a border or background:
Pulling in @alexhollender for his thoughts around this!
Great catch @Jdlrobson. I'd like to keep the button styling as-is. Let's add 8px of padding/margin between the button and the edge of the overlay (there seems to be a number of ways to do this via CSS).
| current | fixed | |
| mobile |  |  |
| desktop |  |  |
Great catch @Jdlrobson.
@Edtadros caught this not me :P
We'll need a specific rule for the notification overlay that overrides the default button rule. If someone can pick this task up while I'm out that would be great.
Change 500534 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] OOUI header actions should have right margin
Change 500534 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] OOUI header actions should have right margin
Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: MBP, iPhoneX (Chrome devtools emulator)
Test Artifact(s):
Desktop:
Mobile:
