mw.cx.ui.MenuLabelWidget: Upstream has made some breaking changes, beware
Closed, ResolvedPublic
Actions

Description

Suggested by @matmarex whilst looking at T218722:

16:16:21 <+MatmaRex> James_F: a similar bug may also affect ContentTranslation – mw.cx.ui.MenuLabelWidget looks similar to MenuSectionOptionWidget (and also has .static.selectable = false)
16:17:12 <+MatmaRex> James_F: i'm off for now, sorry. leaving this in your capable hands. please also file a bug for the CX team to look at or something

Details

	Subject	Repo	Branch	Lines +/-
	Remove mw.cx.ui.MenuLabelWidget	mediawiki/extensions/ContentTranslation	master	+13 -63

Customize query in gerrit

Related Objects

Mentioned Here: T218722: DropdownInputWidget with MenuSectionOptionWidget triggers endless change events

Event Timeline

Jdforrester-WMF created this task.Mar 20 2019, 11:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 20 2019, 11:27 PM

KartikMistry added subscribers: • Petar.petkovic, Nikerabbit, santhosh.Mar 21 2019, 10:34 AM

KartikMistry subscribed.

Pginer-WMF added a project: Language-Team (Language-2019-January-March).Mar 21 2019, 11:29 AM

Change 498093 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Remove mw.cx.ui.MenuLabelWidget

https://gerrit.wikimedia.org/r/498093

gerritbot added a project: Patch-For-Review.Mar 21 2019, 2:00 PM

There was no infinite loop in "New translation" dialog, which uses mw.cx.ui.MenuLabelWidget for menu labels.

However, I have removed that widget and use OOUI's native OO.ui.MenuSectionOptionWidget since two widgets are almost same. That reduces code duplication, but also prevents bugs caused by possible future OOUI changes, since this.selected was not defined in mw.cx.ui.MenuLabelWidget, as the initialization was removed from the parent class.

Nikerabbit added a project: Unplanned-Sprint-Work.Mar 21 2019, 3:18 PM