Page MenuHomePhabricator

InvalidArgumentException from SpecialExternalGuidance: Invalid service name
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error

Request ID: XJPkrApAMEwAABSH5DwAAAAX

message
[{exception_id}] {exception_url}   InvalidArgumentException from line 75 of /srv/mediawiki/php-1.33.0-wmf.22/extensions/ExternalGuidance/specials/SpecialExternalGuidance.php: Invalid service name
trace
	#0 /srv/mediawiki/php-1.33.0-wmf.22/extensions/ExternalGuidance/specials/SpecialExternalGuidance.php(43): MediaWiki\Extension\ExternalGuidance\SpecialExternalGuidance->mtContextGuidance(WebRequest, OutputPage)
#1 /srv/mediawiki/php-1.33.0-wmf.22/includes/specialpage/SpecialPage.php(569): MediaWiki\Extension\ExternalGuidance\SpecialExternalGuidance->execute(NULL)
#2 /srv/mediawiki/php-1.33.0-wmf.22/includes/specialpage/SpecialPageFactory.php(558): SpecialPage->run(NULL)
#3 /srv/mediawiki/php-1.33.0-wmf.22/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#4 /srv/mediawiki/php-1.33.0-wmf.22/includes/MediaWiki.php(867): MediaWiki->performRequest()
#5 /srv/mediawiki/php-1.33.0-wmf.22/includes/MediaWiki.php(517): MediaWiki->main()
#6 /srv/mediawiki/php-1.33.0-wmf.22/index.php(42): MediaWiki->run()
#7 /srv/mediawiki/w/index.php(3): include(string)

Impact

Some users are accessing a url (presumably linked or forwarded from somewhere), and are receiving a generic system error page that they will not understand.

The problem is marked as an application error and thus uses HTTP 500, which means it is not cached, and contributes to raise error levels for production.

Notes

Happens every other hour, not very frequent. A few example urls:

  • enwiki HTTP GET /w/index.php?title=Special:ExternalGuidance&from=en&to=en&page=*******&targettitle=&service=translate.googleusercontent.com
  • enwiki HTTP GET /w/index.php?title=Special:ExternalGuidance&from=en&to=en&page=*******&targettitle=&service=translate.googleusercontent.com

Event Timeline

First hit in the production logs is 2019-02-24T13:08:58 in wmf.18, which I think is when this went live?

It was first deployed in wmf.17 according to https://www.mediawiki.org/wiki/MediaWiki_1.33/wmf.17#ExternalGuidance. Feb 24 is suspicious close to now - 30 days however.

But yeah, it's been this way since the extensions' creation earlier this year.

Change 498913 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[operations/mediawiki-config@master] ExternalGuidance: Allow google translate hosts as known services

https://gerrit.wikimedia.org/r/498913

Change 498913 merged by jenkins-bot:
[operations/mediawiki-config@master] ExternalGuidance: Allow google translate hosts as known services

https://gerrit.wikimedia.org/r/498913

KartikMistry triaged this task as Medium priority.

Mentioned in SAL (#wikimedia-operations) [2019-04-01T18:22:57Z] <lucaswerkmeister-wmde@deploy1001> Synchronized wmf-config/CommonSettings.php: SWAT: [[gerrit:498913|ExternalGuidance: Allow google translate hosts as known services (T218948)]] (duration: 00m 53s)

mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:07 PM