Page MenuHomePhabricator

Skin Contributions and History pages in Minerva for consistency with their mobile replacements
Open, Needs TriagePublic

Description

It should be possible now to render the Contributions and History pages in core inside Minerva in such a way that they are mostly consistent with the current rendering of these pages in mobile.

This will remove a hefty chunk of technical debt and set us up nicely for improving the UI in AMC mode.

his is a precursor to removing the SpecialMobileHistory and
Special:MobileContributions inside MobileFrontend. This will address many bugs.

Noted Visual differences:

  • Dates will be repeated, even if they are identical (solveable with JS if needed )
  • The link at the top of the history page linking back to the article will become a tagline rather than a standalone heading
  • User icons would not be displayed (solveable)

To do

There is a problem on Special:Contributions with the invisible ‎ code. It pushes the title down further than it should. I will create a bug, but a patch exists with some discussion.

Talk to Alex about the header behaviour:

var last;
$('.mw-changeslist-date-date').each(function(i,a ) {
 var cur = $(a).text();
 if (cur === last) {
   $(a).css('visibility', 'hidden');
   $(a).parents('li').css( 'margin-top','-30px');
 }
 last = $(a).text();
} );

Event Timeline

Jdlrobson added a project: User-Jdlrobson.
Jdlrobson updated the task description. (Show Details)

Change 499268 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] POC: History/contributons page is styled consistently with mobile pages

https://gerrit.wikimedia.org/r/499268

Jdlrobson moved this task from Inbox to Next up on the User-Jdlrobson board.Mar 27 2019, 10:54 PM

Change 499839 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] History styles marked as available on mobile

https://gerrit.wikimedia.org/r/499839

Change 499839 merged by jenkins-bot:
[mediawiki/core@master] History styles marked as available on mobile

https://gerrit.wikimedia.org/r/499839

Change 499268 abandoned by Jdlrobson:
Recent changes/watchlist/contributions page is styled consistently with mobile pages

https://gerrit.wikimedia.org/r/499268