Page MenuHomePhabricator
Create Task
Maniphest T219380

[regression] API-only preferences can't be set
Closed, ResolvedPublic
Actions

Description

Bisect blames https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/GlobalPreferences/+/494918/

Details

SubjectRepoBranchLines +/-
Follow-up Ia93e5631: Allow $modifiedPrefs to be set even if no UI controlmediawiki/extensions/GlobalPreferencesREL1_33+1 -1
Follow-up Ia93e5631: Allow $modifiedPrefs to be set even if no UI controlmediawiki/extensions/GlobalPreferencesmaster+1 -1
Follow-up Ia93e5631: Allow $modifiedPrefs to be set even if no UI controlmediawiki/extensions/GlobalPreferenceswmf/1.33.0-wmf.23+1 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedReleasedduvallT206677 1.33.0-wmf.23 deployment blockers
 Resolved• EsandersT219380 [regression] API-only preferences can't be set

Event Timeline

• Esanders created this task.Mar 27 2019, 1:10 PM
Restricted Application added a project: Community-Tech. · View Herald TranscriptMar 27 2019, 1:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Esanders triaged this task as Unbreak Now! priority.Mar 27 2019, 1:11 PM
Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptMar 27 2019, 1:11 PM
gerritbot added a comment.Mar 27 2019, 1:14 PM

Change 499476 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/GlobalPreferences@master] Follow-up Ia93e5631: Allow $modifiedPrefs to be set even if no UI control

https://gerrit.wikimedia.org/r/499476

gerritbot added a project: Patch-For-Review.Mar 27 2019, 1:14 PM
• Esanders added a comment.Mar 27 2019, 1:15 PM

This is going to need a backport.

• Esanders added subscribers: matmarex, Krinkle, MaxSem.Mar 27 2019, 2:18 PM
gerritbot added a comment.Mar 27 2019, 2:50 PM

Change 499476 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@master] Follow-up Ia93e5631: Allow $modifiedPrefs to be set even if no UI control

https://gerrit.wikimedia.org/r/499476

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.24; 2019-04-02).Mar 27 2019, 3:01 PM
gerritbot added a comment.Mar 27 2019, 3:16 PM

Change 499507 had a related patch set uploaded (by Jforrester; owner: Esanders):
[mediawiki/extensions/GlobalPreferences@wmf/1.33.0-wmf.23] Follow-up Ia93e5631: Allow $modifiedPrefs to be set even if no UI control

https://gerrit.wikimedia.org/r/499507

Jdforrester-WMF added a parent task: T206677: 1.33.0-wmf.23 deployment blockers.Mar 27 2019, 3:17 PM
gerritbot added a comment.Mar 27 2019, 4:12 PM

Change 499507 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@wmf/1.33.0-wmf.23] Follow-up Ia93e5631: Allow $modifiedPrefs to be set even if no UI control

https://gerrit.wikimedia.org/r/499507

Stashbot added a comment.Mar 27 2019, 4:28 PM

Mentioned in SAL (#wikimedia-operations) [2019-03-27T16:28:53Z] <jforrester@deploy1001> Synchronized php-1.33.0-wmf.23/extensions/GlobalPreferences/includes/GlobalPreferencesFactory.php: Hot-fix T219380 GlobalPreferences: Allow modifiedPrefs to be set even if no UI control (duration: 00m 58s)

Jdforrester-WMF closed this task as Resolved.Mar 27 2019, 4:42 PM
Jdforrester-WMF assigned this task to • Esanders.
Jdforrester-WMF edited projects, added MW-1.33-notes (1.33.0-wmf.23; 2019-03-26); removed MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review.
• Esanders added a comment.Mar 27 2019, 5:48 PM

Verified on mediawiki.org:

image.png (107×451 px, 8 KB)

Thanks!

gerritbot added a comment.Dec 4 2019, 9:43 PM

Change 554636 had a related patch set uploaded (by Paladox; owner: Esanders):
[mediawiki/extensions/GlobalPreferences@REL1_33] Follow-up Ia93e5631: Allow $modifiedPrefs to be set even if no UI control

https://gerrit.wikimedia.org/r/554636

gerritbot added a project: Patch-For-Review.Dec 4 2019, 9:43 PM
gerritbot added a comment.Dec 4 2019, 9:49 PM

Change 554636 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@REL1_33] Follow-up Ia93e5631: Allow $modifiedPrefs to be set even if no UI control

https://gerrit.wikimedia.org/r/554636

matmarex mentioned this in T231763: Don't show VE help/welcome messages to users if seen before.Dec 5 2019, 11:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits