Page MenuHomePhabricator
Create Task
Maniphest T219510

Citoid should only usurp "<ref" / ctrl+shift+k shortcuts if configured
Closed, ResolvedPublic
Actions

Description

Currently on wikis where it isn't configured (e.g. mediawiki.org) you get a very empty Citoid dialog:

image.png (177×414 px, 9 KB)

Details

SubjectRepoBranchLines +/-
Keep Citoid enabled if automatic tab is configuredmediawiki/extensions/Citoidwmf/1.33.0-wmf.24+90 -89
Keep Citoid enabled if automatic tab is configuredmediawiki/extensions/Citoidmaster+90 -89
Expose citoid map and conditionally register citefromid commandmediawiki/extensions/Citoidmaster+47 -76
Expose the list of citation toolsmediawiki/extensions/Citemaster+47 -46
Customize query in gerrit

Related Objects
Search...

Event Timeline

Esanders created this task.Mar 28 2019, 3:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 28 2019, 3:03 PM
gerritbot added a comment.Mar 28 2019, 3:48 PM

Change 499797 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Cite@master] Expose the list of citation tools

https://gerrit.wikimedia.org/r/499797

gerritbot added a project: Patch-For-Review.Mar 28 2019, 3:48 PM
gerritbot added a comment.Mar 28 2019, 3:51 PM

Change 499799 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Citoid@master] Expose citoid map and conditionally register citefromid command

https://gerrit.wikimedia.org/r/499799

gerritbot added a comment.Mar 28 2019, 8:03 PM

Change 499797 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] Expose the list of citation tools

https://gerrit.wikimedia.org/r/499797

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.24; 2019-04-02).Mar 28 2019, 9:01 PM
matmarex edited projects, added VisualEditor (Current work); removed VisualEditor.Mar 28 2019, 9:17 PM
matmarex moved this task from Incoming to Code review on the VisualEditor (Current work) board.
gerritbot added a comment.Mar 28 2019, 10:46 PM

Change 499799 merged by jenkins-bot:
[mediawiki/extensions/Citoid@master] Expose citoid map and conditionally register citefromid command

https://gerrit.wikimedia.org/r/499799

Mvolz moved this task from Backlog to Extension on the Citoid board.Apr 1 2019, 3:52 PM
matmarex moved this task from Code review to Product owner review on the VisualEditor (Current work) board.Apr 1 2019, 9:36 PM
Mvolz subscribed.EditedApr 3 2019, 3:07 PM

I checked this locally, and the merged change disables citoid even if the automatic tab is correctly configured. I don't think this is the correct behaviour; if neither are configured, it should be de-registered, but not cite tools missing alone: it should also check that Mediawiki:Citoid-template-type-map.json doesn't exist as well.

gerritbot added a comment.Apr 3 2019, 3:34 PM

Change 500979 had a related patch set uploaded (by Mvolz; owner: Mvolz):
[mediawiki/extensions/Citoid@master] Keep citoid enabled if automatic tab is configured

https://gerrit.wikimedia.org/r/500979

Mvolz added a comment.Apr 3 2019, 4:30 PM

I've found an example of a Wikipedia where deploying the previous change without this fix will disable citoid, so I think it should be cherry picked to the previous cut once merged:

https://gu.wikipedia.org/

Mvolz added a parent task: T206678: 1.33.0-wmf.24 deployment blockers.Apr 3 2019, 4:46 PM
dduvall triaged this task as Unbreak Now! priority.Apr 3 2019, 7:03 PM
dduvall subscribed.

Marking UBN as is our policy with train blockers.

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptApr 3 2019, 7:03 PM
dduvall added a comment.Apr 3 2019, 7:28 PM

@Mvolz I'm currently holding the group1 train deployment. Do you have an update or ETA on a fix?

Mvolz added a comment.Apr 3 2019, 7:40 PM
In T219510#5082803, @dduvall wrote:

@Mvolz I'm currently holding the group1 train deployment. Do you have an update or ETA on a fix?

I'm not 100% it's worth holding the train over - it'll disable citoid on at least one small language wiki. But the fix isn't done yet, no. Alternatively we can just revert it but note it requires reverting the change in the cite extension as well.

Mvolz added a comment.Apr 3 2019, 7:42 PM

Also this won't affect group 1, only some wikis in group 2

dduvall added a comment.Apr 3 2019, 7:42 PM
In T219510#5082854, @Mvolz wrote:
In T219510#5082803, @dduvall wrote:

@Mvolz I'm currently holding the group1 train deployment. Do you have an update or ETA on a fix?

I'm not 100% it's worth holding the train over - it'll disable citoid on at least one small language wiki. But the fix isn't done yet, no. Alternatively we can just revert it but note it requires reverting the change in the cite extension as well.

Thanks for the clarification. I'll proceed with group1 and check in tomorrow before promoting all wikis.

gerritbot added a comment.Apr 3 2019, 11:22 PM

Change 500979 merged by jenkins-bot:
[mediawiki/extensions/Citoid@master] Keep Citoid enabled if automatic tab is configured

https://gerrit.wikimedia.org/r/500979

gerritbot added a comment.Apr 3 2019, 11:34 PM

Change 501114 had a related patch set uploaded (by Jforrester; owner: Mvolz):
[mediawiki/extensions/Citoid@wmf/1.33.0-wmf.24] Keep Citoid enabled if automatic tab is configured

https://gerrit.wikimedia.org/r/501114

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.25; 2019-04-09); removed MW-1.33-notes (1.33.0-wmf.24; 2019-04-02).Apr 4 2019, 12:01 AM
Mvolz added a comment.EditedApr 4 2019, 11:27 AM
In T219510#5082874, @dduvall wrote:
In T219510#5082854, @Mvolz wrote:
In T219510#5082803, @dduvall wrote:

@Mvolz I'm currently holding the group1 train deployment. Do you have an update or ETA on a fix?

I'm not 100% it's worth holding the train over - it'll disable citoid on at least one small language wiki. But the fix isn't done yet, no. Alternatively we can just revert it but note it requires reverting the change in the cite extension as well.

Thanks for the clarification. I'll proceed with group1 and check in tomorrow before promoting all wikis.

The fix is now merged on master. The cherrypicked change to the branch is still open and needs merging here: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Citoid/+/501114/

Esanders renamed this task from Citoid should only usurp "<ref" / ctrl+shift+k shortcuts if full configured. to Citoid should only usurp "<ref" / ctrl+shift+k shortcuts if configured.Apr 4 2019, 12:33 PM
gerritbot added a comment.Apr 4 2019, 6:25 PM

Change 501114 merged by jenkins-bot:
[mediawiki/extensions/Citoid@wmf/1.33.0-wmf.24] Keep Citoid enabled if automatic tab is configured

https://gerrit.wikimedia.org/r/501114

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.24; 2019-04-02); removed MW-1.33-notes (1.33.0-wmf.25; 2019-04-09).Apr 4 2019, 7:01 PM
Stashbot mentioned this in T220037: RefreshLinksJob::runForTitle: transaction round 'RefreshLinksJob::run' already started on commons.Apr 4 2019, 7:06 PM

Mentioned in SAL (#wikimedia-operations) [2019-04-04T19:06:34Z] <marxarelli> fetch/rebase looks good, incorporates fixes for T220037, T219510. deploying

Krinkle closed this task as Resolved.Apr 4 2019, 7:22 PM
Krinkle assigned this task to Mvolz.
Ladsgroup removed a project: Patch-For-Review.May 21 2019, 9:27 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL