Page MenuHomePhabricator

Reuse JobExecutor within a JobRunner
Closed, DeclinedPublic


Currently there are 2 ways of executing the jobs in MediaWiki:

  • JobRunner used for all job queue implementation except Kafka implementation
  • JobExecutor used to execute a single job for the Kafka queue.

JobExecutor is mostly a copy-paste of certain parts of the JobRunner, so the two should be either merged together, or the JobRunner has to delegate actual job execution to the JobExecutor.

Event Timeline

Change 501597 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] [WIP] Reuse JobExecutor within a JobRunner

As reminder, there is a similar story between SpecialRunJob and (wmf-rpc)/RunSingleJob. See also T175146 about consolidating those.

Change 501597 merged by jenkins-bot:
[mediawiki/core@master] Add test for JobRunner

In light of T244826 we are not really going to do this, instead remove the JobExecutor entirely.