Page MenuHomePhabricator
Create Task
Maniphest T220277

SDC file page JS doesn't see existing captions in some circumstances
Closed, ResolvedPublic
Actions

Description

Please see this conversation for historical background:

https://commons.wikimedia.org/w/index.php?title=Commons_talk:Structured_data&oldid=345090906#Can't_edit_file_captions_while_a_file_is_being_requested_to_be_renamed

While I attempt to rename a file on Wikimedia Commons I can't edit file captions while the file is awaiting either approval or denial from a file renamer, please see:

wp_ss_20190406_0002.png (2×1 px, 774 KB)

wp_ss_20190406_0001.png (2×1 px, 413 KB)

This issue seems to affect both mobile 📱 and desktop users.

Details

SubjectRepoBranchLines +/-
Change class used by js to detect if we're on a history pagemediawiki/extensions/WikibaseMediaInfomaster+8 -4
Hooks::mediaInfoCaptionsExist: True even if the tag is lower casemediawiki/extensions/WikibaseMediaInfowmf/1.33.0-wmf.24+1 -1
Hooks::mediaInfoCaptionsExist: True even if the tag is lower casemediawiki/extensions/WikibaseMediaInfowmf/1.33.0-wmf.23+1 -1
Hooks::mediaInfoCaptionsExist: True even if the tag is lower casemediawiki/extensions/WikibaseMediaInfomaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

DonTrung created this task.Apr 6 2019, 8:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 6 2019, 8:57 PM
Aklapper added a project: Multimedia.Apr 6 2019, 9:10 PM
gerritbot added a comment.Apr 6 2019, 10:42 PM

Change 501965 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/WikibaseMediaInfo@master] Hooks::mediaInfoCaptionsExist: True even if the tag is lower case

https://gerrit.wikimedia.org/r/501965

gerritbot added a project: Patch-For-Review.Apr 6 2019, 10:42 PM
Jdforrester-WMF renamed this task from File captions can't be edited while a file is requested to be renamed (Wikimedia Commons) to SDC file page JS doesn't see existing captions in some circumstances.Apr 6 2019, 10:42 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF added a project: Structured Data Engineering.
Jdforrester-WMF mentioned this in rEWBIeb16e4018e72: Hooks::mediaInfoCaptionsExist: True even if the tag is lower case.Apr 6 2019, 10:47 PM
DonTrung added a comment.Apr 7 2019, 3:43 AM

Wow, this has got to be the fastest patch ever. Good job, JDForrester-WMF. 😊

gerritbot added a comment.Apr 8 2019, 10:18 AM

Change 501965 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Hooks::mediaInfoCaptionsExist: True even if the tag is lower case

https://gerrit.wikimedia.org/r/501965

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.25; 2019-04-09).Apr 8 2019, 12:02 PM
gerritbot added a comment.Apr 8 2019, 3:37 PM

Change 502257 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.33.0-wmf.24] Hooks::mediaInfoCaptionsExist: True even if the tag is lower case

https://gerrit.wikimedia.org/r/502257

gerritbot added a comment.Apr 8 2019, 3:38 PM

Change 502258 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.33.0-wmf.23] Hooks::mediaInfoCaptionsExist: True even if the tag is lower case

https://gerrit.wikimedia.org/r/502258

Jdforrester-WMF mentioned this in rEWBI36c0d4851d21: Hooks::mediaInfoCaptionsExist: True even if the tag is lower case.Apr 8 2019, 3:41 PM
Jdforrester-WMF mentioned this in rEWBIa86f8e9c7da6: Hooks::mediaInfoCaptionsExist: True even if the tag is lower case.
• Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.Apr 8 2019, 4:16 PM
gerritbot added a comment.Apr 8 2019, 9:29 PM

Change 502258 abandoned by Jforrester:
Hooks::mediaInfoCaptionsExist: True even if the tag is lower case

Reason:
Train's fully deployed now.

https://gerrit.wikimedia.org/r/502258

gerritbot added a comment.Apr 8 2019, 9:55 PM

Change 502257 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.33.0-wmf.24] Hooks::mediaInfoCaptionsExist: True even if the tag is lower case

https://gerrit.wikimedia.org/r/502257

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.24; 2019-04-02); removed MW-1.33-notes (1.33.0-wmf.25; 2019-04-09).Apr 8 2019, 10:00 PM
Stashbot added a comment.Apr 8 2019, 10:04 PM

Mentioned in SAL (#wikimedia-operations) [2019-04-08T22:04:56Z] <jforrester@deploy1001> Synchronized php-1.33.0-wmf.24/extensions/WikibaseMediaInfo/src/WikibaseMediaInfoHooks.php: WBMI T220277 (duration: 00m 57s)

Jdforrester-WMF moved this task from To Do to Verify on Production on the Structured Data Engineering board.Apr 8 2019, 10:05 PM
Jdforrester-WMF edited projects, added MW-1.33-notes (1.33.0-wmf.25; 2019-04-09); removed MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review.

Now deployed. Sorry for the inconvenience.

• Ramsey-WMF subscribed.EditedJun 7 2019, 10:03 PM

Tested on Production today and found problem still exists, and extends to the new tab as well.

rename-bug.gif (568×1 px, 129 KB)

Tested with files from: https://commons.wikimedia.org/wiki/Category:Media_requiring_renaming

gerritbot added a comment.Jun 11 2019, 1:37 PM

Change 516490 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/WikibaseMediaInfo@master] Change class used by js to detect if we're on a history page

https://gerrit.wikimedia.org/r/516490

gerritbot added a project: Patch-For-Review.Jun 11 2019, 1:37 PM
Cparle claimed this task.Jun 11 2019, 1:38 PM
Cparle added a project: Structured-Data-Team-Current-Work.
Cparle moved this task from To Do to Code Review on the Structured-Data-Team-Current-Work board.
Cparle added a subscriber: Jdforrester-WMF.
gerritbot added a comment.Jun 12 2019, 10:01 AM

Change 516490 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Change class used by js to detect if we're on a history page

https://gerrit.wikimedia.org/r/516490

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.10; 2019-06-18).Jun 12 2019, 11:00 AM
Cparle moved this task from Code Review to Needs QA on the Structured-Data-Team-Current-Work board.Jun 12 2019, 4:48 PM
Cparle closed this task as Resolved.Jun 12 2019, 4:50 PM

Should be verifiable on production on Thurs, June 20

Cparle reopened this task as Open.Jun 12 2019, 4:51 PM

sorry, resolved by accident ...

Cparle removed Cparle as the assignee of this task.Jun 12 2019, 4:51 PM
Cparle subscribed.
• Ramsey-WMF mentioned this in T225900: Structured image metadata of File:Editors_on_huwiki_until_2019-04-01.png.png uneditable.Jun 18 2019, 12:31 AM
Tgr merged a task: T225900: Structured image metadata of File:Editors_on_huwiki_until_2019-04-01.png.png uneditable.Aug 5 2019, 9:17 PM
Tgr subscribed.
Aklapper edited projects, added Structured-Data-Backlog; removed Multimedia.Aug 10 2019, 11:54 PM
Restricted Application added a project: Multimedia. · View Herald TranscriptAug 10 2019, 11:54 PM
Aklapper edited projects, added Structured-Data-Backlog (Current Work); removed Multimedia, Structured-Data-Backlog.Aug 10 2019, 11:57 PM
MBinder_WMF moved this task from Incoming to Needs QA on the Structured-Data-Backlog (Current Work) board.Aug 12 2019, 3:20 PM
• Ramsey-WMF closed this task as Resolved.Aug 14 2019, 2:01 AM
• Ramsey-WMF claimed this task.
• Ramsey-WMF edited projects, added Multimedia; removed Structured-Data-Backlog (Current Work), MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Structured-Data-Team-Current-Work, Patch-For-Review.

Tested on production and is fixed.

Restricted Application added a project: Structured-Data-Backlog. · View Herald TranscriptAug 14 2019, 2:01 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL