Can't merge code in WikibaseMediaInfo; seemingly caused by WikibaseCirrusSearch changes?
Closed, ResolvedPublic0 Estimated Story Points
Actions

Description

The "auto_generate_phrase_queries": true, term is missing for four EntitySearchElasticFulltextTest unit test results; it was removed in T219267, but not in the duplicates in WikibaseCirrusSearch and when that became the only copy it started erroring.

Example: https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/45288/consoleFull

Details

	Subject	Repo	Branch	Lines +/-
	Remove auto_generate_phrase_queries	mediawiki/extensions/WikibaseCirrusSearch	wmf/1.34.0-wmf.1	+0 -8
	Remove auto_generate_phrase_queries	mediawiki/extensions/WikibaseCirrusSearch	master	+0 -8

Customize query in gerrit

Related Objects

Mentioned In: rEWCSba284e6640b8: Remove auto_generate_phrase_queries
T221128: Wikibase / CirrusSearch tests are blocking merges in Math extension
T221135: Include WikibaseCirrusSearch into CirrusSearch tests
rEWCSd0ab01743888: Remove auto_generate_phrase_queries
T221110: Cannot edit statements for certain images
T221071: We don't want MediaInfo content to show up on wikis sharing Commons files
Mentioned Here: T219267: Elasticsearch 6: auto_generate_phrase_queries is deprecated and ineffective

Event Timeline

Jdforrester-WMF created this task.Apr 16 2019, 5:03 PM

Restricted Application added a project: Discovery-Search. · View Herald TranscriptApr 16 2019, 5:03 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• Ha78na subscribed.Apr 16 2019, 5:05 PM

• Ha78na mentioned this in T221071: We don't want MediaInfo content to show up on wikis sharing Commons files.Apr 16 2019, 6:55 PM

• Ha78na mentioned this in T221110: Cannot edit statements for certain images.Apr 16 2019, 6:57 PM

Change 504413 had a related patch set uploaded (by Jforrester; owner: Smalyshev):
[mediawiki/extensions/WikibaseCirrusSearch@master] Remove auto_generate_phrase_queries

https://gerrit.wikimedia.org/r/504413

gerritbot added a project: Patch-For-Review.Apr 16 2019, 7:13 PM

Jdforrester-WMF mentioned this in rEWCSd0ab01743888: Remove auto_generate_phrase_queries.Apr 16 2019, 7:15 PM

Yes, https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseCirrusSearch/+/504413 should fix it.

Smalyshev mentioned this in T221135: Include WikibaseCirrusSearch into CirrusSearch tests.Apr 16 2019, 7:23 PM

Jdforrester-WMF updated the task description. (Show Details)Apr 16 2019, 7:28 PM

Change 504413 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] Remove auto_generate_phrase_queries

https://gerrit.wikimedia.org/r/504413

Jdforrester-WMF mentioned this in T221128: Wikibase / CirrusSearch tests are blocking merges in Math extension.Apr 16 2019, 8:38 PM

Jdforrester-WMF merged a task: T221128: Wikibase / CirrusSearch tests are blocking merges in Math extension.

Jdforrester-WMF added subscribers: matmarex, Umherirrender, • SMalikWMF, TerraCodes.

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).Apr 16 2019, 9:00 PM

Jdforrester-WMF closed this task as Resolved.Apr 16 2019, 10:30 PM

Jdforrester-WMF claimed this task.

Jdforrester-WMF reassigned this task from Jdforrester-WMF to Smalyshev.

Jdforrester-WMF removed a project: Patch-For-Review.

Change 504582 had a related patch set uploaded (by Jforrester; owner: Smalyshev):
[mediawiki/extensions/WikibaseCirrusSearch@wmf/1.34.0-wmf.1] Remove auto_generate_phrase_queries

https://gerrit.wikimedia.org/r/504582

gerritbot added a project: Patch-For-Review.Apr 17 2019, 3:20 PM

Jdforrester-WMF mentioned this in rEWCSba284e6640b8: Remove auto_generate_phrase_queries.Apr 17 2019, 3:21 PM

Change 504582 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@wmf/1.34.0-wmf.1] Remove auto_generate_phrase_queries

https://gerrit.wikimedia.org/r/504582

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.1; 2019-04-16); removed MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).Apr 17 2019, 4:00 PM