Page MenuHomePhabricator

Can't merge code in WikibaseMediaInfo; seemingly caused by WikibaseCirrusSearch changes?
Closed, ResolvedPublic0 Story Points

Description

The "auto_generate_phrase_queries": true, term is missing for four EntitySearchElasticFulltextTest unit test results; it was removed in T219267, but not in the duplicates in WikibaseCirrusSearch and when that became the only copy it started erroring.

Example: https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/45288/consoleFull

Event Timeline

Restricted Application added a project: Discovery-Search. · View Herald TranscriptApr 16 2019, 5:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Ha78na added a subscriber: Ha78na.Apr 16 2019, 5:05 PM

Change 504413 had a related patch set uploaded (by Jforrester; owner: Smalyshev):
[mediawiki/extensions/WikibaseCirrusSearch@master] Remove auto_generate_phrase_queries

https://gerrit.wikimedia.org/r/504413

Change 504413 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] Remove auto_generate_phrase_queries

https://gerrit.wikimedia.org/r/504413

Jdforrester-WMF closed this task as Resolved.Apr 16 2019, 10:30 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF reassigned this task from Jdforrester-WMF to Smalyshev.
Jdforrester-WMF removed a project: Patch-For-Review.

Change 504582 had a related patch set uploaded (by Jforrester; owner: Smalyshev):
[mediawiki/extensions/WikibaseCirrusSearch@wmf/1.34.0-wmf.1] Remove auto_generate_phrase_queries

https://gerrit.wikimedia.org/r/504582

Change 504582 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@wmf/1.34.0-wmf.1] Remove auto_generate_phrase_queries

https://gerrit.wikimedia.org/r/504582