Page MenuHomePhabricator

Elasticsearch 6: auto_generate_phrase_queries is deprecated and ineffective
Closed, ResolvedPublic

Description

https://www.elastic.co/guide/en/elasticsearch/reference/current/breaking-changes-6.0.html :

The auto_generate_phrase_queries parameter for the query_string query has been removed, use an explicit quoted query instead. If provided, it will be ignored and issue a deprecation warning.

We should first remove it from the code since it's ineffective. We then figure out if we need to find alternatives.
This option was mostly used to improve precision in case of acronyms searches or words with dash.

A query like N.A.S.A missions with auto_generate_phrase_queries is using a filter like "N.A.S.A" missions without this option we are running
N A S A missions.

Finding ideal solutions is out of the scope of this ticket another task need to be created for this.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 26 2019, 9:32 AM
Restricted Application added a project: Discovery-Search. · View Herald TranscriptMar 26 2019, 9:33 AM
dcausse updated the task description. (Show Details)Mar 26 2019, 9:33 AM
dcausse triaged this task as Medium priority.
dcausse moved this task from elastic / cirrus to Current work on the Discovery-Search board.

Change 500493 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Stop using auto_generate_phrase_queries

https://gerrit.wikimedia.org/r/500493

debt closed this task as Resolved.Apr 5 2019, 10:36 PM

Change 500493 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Stop using auto_generate_phrase_queries

https://gerrit.wikimedia.org/r/500493