Page MenuHomePhabricator

Make PHP 8.0 voting on MW master
Open, Needs TriagePublic

Description

Status as of 2022-07-27: Partially done.

See also: T274965: Make PHP 8.0 voting on currently supported MW release branches

Related Objects

StatusSubtypeAssignedTask
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenEBernhardson
ResolvedEBernhardson
Resolved dcausse
Resolved dcausse
Resolved dcausse
Resolved dcausse
Resolved dcausse
OpenNone
ResolvedEBernhardson
DuplicateNone
ResolvedEBernhardson
ResolvedEJoseph
ResolvedEBernhardson
DuplicateNone
ResolvedGehel
ResolvedEJoseph
Resolvedbking
Resolvedbking
ResolvedRKemper
ResolvedRKemper
ResolvedRKemper
ResolvedRKemper
ResolvedGehel
Openbking
Resolvedbking
Resolvedbking
Resolvedbking
Resolvedbking
Resolvedbking
Resolvedbking
ResolvedEBernhardson
ResolvedEBernhardson
ResolvedTJones
Resolved Zbyszko
DeclinedNone
DeclinedJenlenfantwright
OpenTJones
DeclinedNone
Resolvedbd808
DeclinedNone
ResolvedEBernhardson
DeclinedNone
Resolved dcausse
ResolvedEBernhardson
ResolvedEBernhardson
OpenEBernhardson
OpenEBernhardson
OpenNone
OpenNone
OpenNone

Event Timeline

Reedy changed the task status from Open to Stalled.Feb 9 2022, 12:39 AM

(perhaps a stupid question): I see that mediawiki-quibble-composer-mysql is passing ( https://integration.wikimedia.org/ci/job/mediawiki-quibble-composer-mysql-php80-docker/67/console ), the tests that seem to be failing are those that require vendor.git or more specificly dev dependencies of vendor.git (If I understand correctly).

Is there anything stopping us from making mediawiki-quibble-composer-mysql voting, as a starting place?

(perhaps a stupid question): I see that mediawiki-quibble-composer-mysql is passing ( https://integration.wikimedia.org/ci/job/mediawiki-quibble-composer-mysql-php80-docker/67/console ), the tests that seem to be failing are those that require vendor.git (If I understand correctly).

Is there anything stopping us from making mediawiki-quibble-composer-mysql voting, as a starting place?

I don't think so, no. Tim basically confirmed this was working in T283275#7639285 after some fixes.

The big known problems are vendor related (elasticsearch etc).

It would/could help prevent some future regressions on PHP 8.

If we can do the same on supported release branches too (if that job passes there too?), that'd be cool.

Looks like mediawiki-quibble-composertest-php80-docker passes on release branches (because of stripped vendor).

I think promoting that at the same time (for release branches) would be good too.

Looks like mediawiki-quibble-composertest-php80-docker passes on release branches (because of stripped vendor).

I think promoting that at the same time (for release branches) would be good too.

Scrap that. We already have.

Reedy changed the task status from Stalled to Open.Thu, Jul 21, 10:57 PM

I guess we could have a file in vendor.git with overrides for php 8, and if quibble detects its on php8, it runs composer require $LISTOFOVERRIDES

Change 815985 had a related patch set uploaded (by Reedy; author: Reedy):

[integration/config@master] Promote mediawiki-quibble-composer-mysql-php80-docker

https://gerrit.wikimedia.org/r/815985

Change 816062 had a related patch set uploaded (by Brian Wolff; author: Brian Wolff):

[integration/config@master] Make composer-php80 run on gate-and-submit for MW core

https://gerrit.wikimedia.org/r/816062

Change 815985 abandoned by Reedy:

[integration/config@master] Promote mediawiki-quibble-composer-mysql-php80-docker

Reason:

https://gerrit.wikimedia.org/r/815985

Well looks like it does not pass on 1.35 yet. Somehow on 1.37 it seems to consistently segfault.

Well looks like it does not pass on 1.35 yet. Somehow on 1.37 it seems to consistently segfault.

Some of those are at T274966: Make MW 1.35 tests pass on PHP 8.0.

Change 816062 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/core] Add a non-vendor php80 job for main branch

https://gerrit.wikimedia.org/r/816062

Mentioned in SAL (#wikimedia-releng) [2022-07-27T13:55:56Z] <James_F> Zuul: [mediawiki/core] Add a non-vendor php80 job for main branch T300463

Mentioned in SAL (#wikimedia-releng) [2022-07-27T13:55:56Z] <James_F> Zuul: [mediawiki/core] Add a non-vendor php80 job for main branch T300463

There are flaky Segmentation fault fails, see T315167