Page MenuHomePhabricator

Make PHP 8.0 voting on MW master
Closed, ResolvedPublic

Description

Status as of 2022-09-30: Done for core; skins and extensions to come.

See also: T274965: Make PHP 8.0 voting on currently supported MW release branches

Related Objects

StatusSubtypeAssignedTask
ResolvedNone
ResolvedJdforrester-WMF
ResolvedNone
ResolvedEBernhardson
ResolvedGehel
ResolvedEBernhardson
ResolvedEBernhardson
Resolveddcausse
Resolveddcausse
Resolveddcausse
Resolveddcausse
Resolveddcausse
OpenNone
ResolvedEBernhardson
DuplicateNone
ResolvedEBernhardson
Resolved EJoseph
ResolvedEBernhardson
DuplicateNone
ResolvedGehel
Resolved EJoseph
Resolvedbking
Resolvedbking
ResolvedRKemper
ResolvedRKemper
ResolvedRKemper
ResolvedRKemper
ResolvedGehel
Resolvedbking
Resolvedbking
Resolvedbking
Resolvedbking
Resolvedbking
Resolvedbking
Resolvedbking
ResolvedEBernhardson
ResolvedEBernhardson
ResolvedTJones
Resolved Zbyszko
DeclinedNone
DeclinedNone
ResolvedTJones
ResolvedEBernhardson
DeclinedNone
Resolvedbd808
DeclinedNone
ResolvedEBernhardson
DeclinedNone
Resolveddcausse
ResolvedEBernhardson
ResolvedEBernhardson
ResolvedEBernhardson
Resolvedbking
ResolvedGehel
ResolvedGehel
ResolvedRKemper
ResolvedBUG REPORTEBernhardson
ResolvedEBernhardson
ResolvedRKemper
ResolvedEBernhardson
Resolvedkostajh
ResolvedJdforrester-WMF
ResolvedJdforrester-WMF
ResolvedJdforrester-WMF
ResolvedJoe
ResolvedDzahn
Resolvedhashar
ResolvedJdforrester-WMF
ResolvedLadsgroup
ResolvedMoritzMuehlenhoff
Resolvedjijiki
ResolvedMoritzMuehlenhoff
ResolvedTrizek-WMF
ResolvedDzahn
Resolved Gilles
ResolvedDzahn
ResolvedRequestPapaul
Resolvedjijiki
DeclinedNone
ResolvedDzahn
ResolvedDzahn
ResolvedPapaul
Resolved Cmjohnson
ResolvedRequest Cmjohnson
ResolvedRequestPapaul
ResolvedAndrew
ResolvedArielGlenn
ResolvedDzahn
ResolvedLegoktm
ResolvedPapaul
ResolvedDzahn
Declined Gilles
ResolvedVolans
ResolvedDzahn
ResolvedLegoktm
ResolvedPleaseStand
ResolvedJoe
Resolvedtstarling
ResolvedArielGlenn
ResolvedJoe
Resolvedtstarling
ResolvedJdforrester-WMF
ResolvedJdforrester-WMF
ResolvedLegoktm
ResolvedJdforrester-WMF
ResolvedDaimona
ResolvedDaimona
ResolvedJdforrester-WMF
ResolvedJoe
ResolvedJMeybohm
ResolvedJoe
ResolvedJoe
ResolvedJoe
ResolvedJoe
ResolvedKrinkle
ResolvedJoe
ResolvedClement_Goubert
ResolvedClement_Goubert
ResolvedClement_Goubert
ResolvedMainframe98
ResolvedJoe
ResolvedZabe
ResolvedJdforrester-WMF

Event Timeline

Reedy changed the task status from Open to Stalled.Feb 9 2022, 12:39 AM

(perhaps a stupid question): I see that mediawiki-quibble-composer-mysql is passing ( https://integration.wikimedia.org/ci/job/mediawiki-quibble-composer-mysql-php80-docker/67/console ), the tests that seem to be failing are those that require vendor.git or more specificly dev dependencies of vendor.git (If I understand correctly).

Is there anything stopping us from making mediawiki-quibble-composer-mysql voting, as a starting place?

(perhaps a stupid question): I see that mediawiki-quibble-composer-mysql is passing ( https://integration.wikimedia.org/ci/job/mediawiki-quibble-composer-mysql-php80-docker/67/console ), the tests that seem to be failing are those that require vendor.git (If I understand correctly).

Is there anything stopping us from making mediawiki-quibble-composer-mysql voting, as a starting place?

I don't think so, no. Tim basically confirmed this was working in T283275#7639285 after some fixes.

The big known problems are vendor related (elasticsearch etc).

It would/could help prevent some future regressions on PHP 8.

If we can do the same on supported release branches too (if that job passes there too?), that'd be cool.

Looks like mediawiki-quibble-composertest-php80-docker passes on release branches (because of stripped vendor).

I think promoting that at the same time (for release branches) would be good too.

Looks like mediawiki-quibble-composertest-php80-docker passes on release branches (because of stripped vendor).

I think promoting that at the same time (for release branches) would be good too.

Scrap that. We already have.

Reedy changed the task status from Stalled to Open.Jul 21 2022, 10:57 PM

I guess we could have a file in vendor.git with overrides for php 8, and if quibble detects its on php8, it runs composer require $LISTOFOVERRIDES

Change 815985 had a related patch set uploaded (by Reedy; author: Reedy):

[integration/config@master] Promote mediawiki-quibble-composer-mysql-php80-docker

https://gerrit.wikimedia.org/r/815985

Change 816062 had a related patch set uploaded (by Brian Wolff; author: Brian Wolff):

[integration/config@master] Make composer-php80 run on gate-and-submit for MW core

https://gerrit.wikimedia.org/r/816062

Change 815985 abandoned by Reedy:

[integration/config@master] Promote mediawiki-quibble-composer-mysql-php80-docker

Reason:

https://gerrit.wikimedia.org/r/815985

Well looks like it does not pass on 1.35 yet. Somehow on 1.37 it seems to consistently segfault.

Well looks like it does not pass on 1.35 yet. Somehow on 1.37 it seems to consistently segfault.

Some of those are at T274966: Make MW 1.35 tests pass on PHP 8.0.

Change 816062 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/core] Add a non-vendor php80 job for main branch

https://gerrit.wikimedia.org/r/816062

Mentioned in SAL (#wikimedia-releng) [2022-07-27T13:55:56Z] <James_F> Zuul: [mediawiki/core] Add a non-vendor php80 job for main branch T300463

Mentioned in SAL (#wikimedia-releng) [2022-07-27T13:55:56Z] <James_F> Zuul: [mediawiki/core] Add a non-vendor php80 job for main branch T300463

There are flaky Segmentation fault fails, see T315167

Change 836977 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: [mediawiki/core] Upgrade PHP 8.0 and 8.1 jobs to full vendor jobs

https://gerrit.wikimedia.org/r/836977

Change 836979 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: Make PHP 8.0 and PHP 8.1 voting for all skins and extensions

https://gerrit.wikimedia.org/r/836979

Change 836977 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/core] Upgrade PHP 8.0 and 8.1 jobs to full vendor jobs

https://gerrit.wikimedia.org/r/836977

Mentioned in SAL (#wikimedia-releng) [2022-09-30T02:30:34Z] <James_F> Zuul: [mediawiki/core] Upgrade PHP 8.0 and 8.1 jobs to full vendor jobs for T300463 and T316078

Change 836979 merged by jenkins-bot:

[integration/config@master] Zuul: Make PHP 8.0 and PHP 8.1 voting for all skins and extensions

https://gerrit.wikimedia.org/r/836979

Mentioned in SAL (#wikimedia-releng) [2022-09-30T16:46:38Z] <James_F> Zuul: Make PHP 8.0 and PHP 8.1 voting for all skins and extensions in master for T300463 and T316078

Jdforrester-WMF claimed this task.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Now done everywhere.

Change 1000928 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/vendor@master] composer: Disable linting the Match.php file that breaks PHP 8.0

https://gerrit.wikimedia.org/r/1000928

Change 1000929 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: [mediawiki/vendor] Test composer lint with PHP 8.0+ too

https://gerrit.wikimedia.org/r/1000929

Change 1000928 merged by jenkins-bot:

[mediawiki/vendor@master] composer: Disable linting the Match.php file that breaks PHP 8.0

https://gerrit.wikimedia.org/r/1000928

Change 1000929 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/vendor] Test composer lint with PHP 8.0+ too

https://gerrit.wikimedia.org/r/1000929