Page MenuHomePhabricator
Create Task
Maniphest T300463

Make PHP 8.0 voting on MW master
Closed, ResolvedPublic
Actions

Description

Status as of 2022-09-30: Done for core; skins and extensions to come.

See also: T274965: Make PHP 8.0 voting on currently supported MW release branches

Details

ProjectBranchLines +/-Subject
integration/configmaster+50 -15Zuul: Make PHP 8.0 and PHP 8.1 voting for all skins and extensions
integration/configmaster+6 -10Zuul: [mediawiki/core] Upgrade PHP 8.0 and 8.1 jobs to full vendor jobs
integration/configmaster+4 -0Zuul: [mediawiki/core] Add a non-vendor php80 job for main branch
integration/configmaster+0 -0Promote mediawiki-quibble-composer-mysql-php80-docker
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT248925 Make MediaWiki release tarball compatible with PHP 8.0
 ResolvedJdforrester-WMFT300463 Make PHP 8.0 voting on MW master
 ResolvedNoneT283275 Make MW master tests pass on PHP 8.0
 ResolvedEBernhardsonT271777 Bump rufin/elastica (and related libraries) to versions that support PHP 8.0
 ResolvedGehelT263142 [EPIC] Upgrade Elasticsearch to version 7.10
 ResolvedEBernhardsonT218994 Deprecation warning on elasticsearch 6
ResolvedEBernhardsonT218995 re-enable deprecation warning logger on elasticsearch once issues are solved
 ResolveddcausseT219265 Elasticsearch 6: _retry_on_conflict is deprecated
 ResolveddcausseT219266 Elasticsearch 6 nested_path and nested_filter are deprecated
 ResolveddcausseT219267 Elasticsearch 6: auto_generate_phrase_queries is deprecated and ineffective
 ResolveddcausseT219268 Elasticsearch 6: the classic similarity is deprecated
 ResolveddcausseT219533 Reindex space less languages wikis to use BM25
 OpenNoneT219534 Test MLR models for zhwiki, jawiki and kowiki
 ResolvedEBernhardsonT219269 Elasticsearch 6: silence deprecation warnings to avoid logspam
 DuplicateNoneT215615 Stop using negative scores for deboosting statements
 ResolvedEBernhardsonT288764 Set include_type_name in all get requests
 Resolved• EJosephT288765 Always provide minimum_should_match in bool queries
 ResolvedEBernhardsonT306123 Ensure mjolnir models have positive scores
 DuplicateNoneT273814 Create ElasticSearch 7.10 image in releng/dev-images
 ResolvedGehelT295666 Upgrade Cirrus elasticsearch clusters to 6.8.23
 Resolved• EJosephT294499 Upgrade Cirrus elasticsearch plugins to 6.8.23
 ResolvedbkingT301954 Upgrade deployment-prep to elasticsearch 6.8.23
 ResolvedbkingT301955 Upgrade relforge to elasticsearch 6.8.23
 ResolvedRKemperT278378 Pull Elasticsearch config out of Spicerack
 ResolvedRKemperT301956 Upgrade cloudelastic to elasticsearch 6.8.23
 ResolvedRKemperT301958 Upgrade Search elasticsearch cluster / codfw to elasticsearch 6.8.23
 ResolvedRKemperT301959 Upgrade Search elasticsearch cluster / eqiad to elasticsearch 6.8.23
 ResolvedGehelT304570 elasticsearch: make rolling upgrade proceed to second host after shards are stable
 ResolvedbkingT289135 Upgrade Cirrus Elasticsearch clusters to Debian Bullseye
 ResolvedbkingT299797 Deploy new bullseye elastic cluster nodes on deployment-prep
 ResolvedbkingT301408 Enable search team SRE access to deployment-prep VMs
 ResolvedbkingT307510 Update tls proxy config for Bullseye
 ResolvedbkingT308770 Reimage relforge elastic hosts from Stretch to Bullseye
 ResolvedbkingT309343 Upgrade cloudelastic clusters to Debian Bullseye
 ResolvedbkingT312298 Update NIC firmware on all Elastic PowerEdge R440 elastic hosts
 ResolvedEBernhardsonT295736 Evaluate deployed elasticsearch plugins for 7.10 compatability
 ResolvedEBernhardsonT295734 Bring up two copies of the CirrusSearch browser integration env in cloud
 ResolvedTJonesT300302 Test Elastic 6.8 language analyzers
 Resolved• ZbyszkoT300833 Address "Log4shell" vulnerability in Elasticsearch 7.10.2
 DeclinedNoneT301724 Sunset ApiFeatureUsage
 DeclinedNoneT302638 Sunset ApiFeatureUsage (TDMP)
 ResolvedTJonesT301131 Test Elastic 7.10 language analyzers
 ResolvedEBernhardsonT317200 Reindex all wikis to fix nnbsp regression
 DeclinedNoneT303443 Ensure that all applications depending on the Search Elasticsearch cluster are compatible with Elasticsearch 7.10
 Resolvedbd808T303444 Ensure Toolhub is compatible with Elasticsearch 7.10
 DeclinedNoneT303445 Ensure Phabricator is compatible with Elasticsearch 7.10
 ResolvedEBernhardsonT304290 Create docker elasticsearch images with wmf search plugins
 DeclinedNoneT304569 Remove row/rack awareness in Elasticsearch config
 ResolveddcausseT305428 Upgrade the Translate TTM Elasticsearch implementation to elasticsearch 6.8 and onwards
ResolvedEBernhardsonT306644 re-run wbsearchentities optimization process
ResolvedEBernhardsonT307931 Run CirrusSearch test suite against Elasticsearch 7.10
 ResolvedEBernhardsonT308676 Elasticsearch 7.10.2 rollout plan
 ResolvedbkingT315604 Upgrade relforge cluster to 7.10.2
 ResolvedGehelT316159 Upgrade cloudelastic cluster to 7.10.2
 ResolvedGehelT316240 Upgrade deployment-prep to Elasticsearch 7.10.2
 ResolvedRKemperT316719 Upgrade codfw cluster to Elasticsearch 7.10.2
 ResolvedBUG REPORTEBernhardsonT317381 Reduction in helpfulness and quantity of autocomplete search results
 ResolvedEBernhardsonT317374 Search now caps total results count at 10k because of elasticsearch 7 upgrade
 ResolvedRKemperT317686 Upgrade eqiad cluster to Elasticsearch 7.10.2
 ResolvedEBernhardsonT313434 Migrate apifeatureusage to elasticsearch 7
 ResolvedkostajhT317513 Flow is incompatible with Elastica - Remove ElasticSearch integration / Flow search
 ResolvedJdforrester-WMFT313563 Bump lcobucci/jwt & league/uri-components for php8
 ResolvedJdforrester-WMFT313564 Bump onoi/message-reporter in vendor.git to 1.4.2 for php 8 support
 ResolvedJdforrester-WMFT261872 Drop PHP 7.2 & 7.3 support from MediaWiki master branch, once Wikimedia production is on 7.4
 ResolvedJoeT271736 Migrate WMF production from PHP 7.2 to PHP 7.4
 ResolvedDzahnT245757 Upgrade MediaWiki clusters to Debian Buster (debian 10)
 ResolvedhasharT252434 Test MW code in buster as well as stretch
 ResolvedJdforrester-WMFT250514 Create buster-based images for quibble
 ResolvedLadsgroupT279068 Wikibase data-client bridge selenium failure on buster but not stretch
 ResolvedMoritzMuehlenhoffT250515 Please provide our special component/php72 in buster-wikimedia
 ResolvedjijikiT264991 Upgrade the MediaWiki servers to ICU 63
 ResolvedMoritzMuehlenhoffT253377 WMF deployed EasyTimeline extension depends on Ploticus package which is not available in Debian Buster (but available again in Debian Bullseye)
 ResolvedTrizek-WMFT267145 CommRel support for ICU 63 upgrade
 ResolvedDzahnT267248 create mwdebug1003 - ganeti VM with buster and appserver role
 Resolved• GillesT268188 Release WikimediaDebug for mwdebug1003 addition
 ResolvedDzahnT267607 upgrade mwmaint servers to buster
ResolvedRequestPapaulT275928 decommission mwmaint2001.codfw.wmnet
 ResolvedjijikiT268524 Upgrade Parsoid servers to buster
DeclinedNoneT245888 Rename wtp* servers to parse* (Parsoid PHP servers)
 ResolvedDzahnT268248 upgrade scandium to buster
 ResolvedDzahnT265963 Replace production deployment servers and update them to Buster
Unknown Object (Task)
 ResolvedPapaulT266363 (Need By: TBD) rack/setup/install deploy2002
 ResolvedCmjohnsonT265653 (Need By: TBD) setup/install deploy1002
 ResolvedRequestCmjohnsonT275831 decommission deploy1001.eqiad.wmnet
 ResolvedRequestPapaulT275832 decommission deploy2001.codfw.wmnet
 ResolvedAndrewT269004 Upgrade labweb servers to buster
 ResolvedArielGlennT269377 Upgrade snapshot hosts to Buster
 ResolvedDzahnT270517 Investigate opcache hit rate on Buster appserver
 ResolvedLegoktmT273312 Investigate possible performance degradation on mediawiki servers after Debian Buster upgrade
 ResolvedPapaulT273803 mw2220 - broken IPMI / mgmt
ResolvedDzahnT274023 Convert mwdebug VMs to debian buster
 Declined• GillesT274026 Add 3 new canaries to WikimediaDebug
 ResolvedVolansT274689 sre.hosts.decomission -> generate_dns_snippets - > Cumin execution failed
 ResolvedDzahnT274403 mw1379 - down after reboot attempt and DRAC can't powercycle
 ResolvedLegoktmT275752 Jobrunner timeouts on cross-DC file uploads because of HTTP/2
 ResolvedPleaseStandT291127 MediaWiki session management does not work on split PHP 7.4 and < PHP 7.4 cluster
 ResolvedJoeT293450 Allow coexisting php version in our puppet code
 ResolvedtstarlingT295578 Test running php7.2 and php7.4 in parallel on the beta cluster
 ResolvedArielGlennT295580 Test php7.4 for dumps generation
 ResolvedJoeT293451 Allow sending traffic to php 7.2 or 7.4 selectively in the apache configuration for MediaWiki
 ResolvedtstarlingT263437 Allow easier ICU transitions in MediaWiki (change how sortkey collation is managed in the categorylinks table)
 ResolvedJdforrester-WMFT293924 Also run PHP 7.4 jobs on wmf branch patches
 ResolvedJdforrester-WMFT293851 Re-build all CI images of PHP 7.4 from sury's package to Wikimedia's one, to assure us that it will work
 ResolvedLegoktmT293449 Package php 7.4 for wikimedia production
 ResolvedJdforrester-WMFT295285 Upgrade primary branch of all Wikimedia-deployed repos to a version of mediawiki-tools-phan including T270553
 ResolvedDaimonaT295286 Release mediawiki-tools-phan 0.11.1
 ResolvedDaimonaT270553 Should mediawiki/mediawiki-phan-config ship a target php version to support running with newer php on the developer side?
 ResolvedJdforrester-WMFT314896 WikiEditor edit sampling code triggers 'PHP Deprecated: Invalid characters passed for attempted conversion, these have been ignored' on PHP7.4+
ResolvedJoeT293996 Build MediaWiki images for kubernetes based on php 7.4
 ResolvedJMeybohmT295725 Stop loading wddx PHP extension
 ResolvedJoeT306042 Serve beta cluster via PHP 7.4 by default
 ResolvedJoeT311386 Install php 7.4 in production
 ResolvedJoeT312634 Properly support php7.4 across the observability stack
 ResolvedJoeT313505 Remove prometheus-phpfpm-exporter from physical hosts
 ResolvedKrinkleT311388 Allow assigning each user to a specific php engine by setting a PHP_ENGINE cookie
 ResolvedJoeT311479 Split edge caches between php versions
 ResolvedClement_GoubertT312638 Parsoid migration to php 7.4
 ResolvedClement_GoubertT307219 Put parse parse10[01-24] in production
 ResolvedClement_GoubertT318946 Parsoid migration: Cleanup
 ResolvedMainframe98T312653 Add "php 7.4" option to the Wikimedia Debug extension
 ResolvedJoeT318894 Remove php 7.2 from production
 ResolvedZabeT316518 Run phan jobs for MediaWiki core on master + WMF branches using PHP 7.4, not just 7.2
 ResolvedJdforrester-WMFT315167 CI job mediawiki-quibble-composer-mysql-php80-docker on mediawiki/core gate-and-submit is flaky failing with Segmentation fault

Event Timeline

Reedy created this task.Jan 30 2022, 5:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 30 2022, 5:20 PM
Reedy added a subtask: T283275: Make MW master tests pass on PHP 8.0.Jan 30 2022, 5:20 PM
Reedy added a parent task: T248925: Make MediaWiki release tarball compatible with PHP 8.0.
Amire80 awarded a token.Jan 30 2022, 6:30 PM
Reedy changed the task status from Open to Stalled.Feb 9 2022, 12:39 AM
Reedy moved this task from Backlog to MediaWiki core on the PHP 8.0 support board.Mar 28 2022, 3:15 PM
Reedy mentioned this in T312971: Enable PHP 8 CI for ProofreadPage.Jul 21 2022, 8:13 PM
Bawolff added a subscriber: Bawolff.EditedJul 21 2022, 10:21 PM

(perhaps a stupid question): I see that mediawiki-quibble-composer-mysql is passing ( https://integration.wikimedia.org/ci/job/mediawiki-quibble-composer-mysql-php80-docker/67/console ), the tests that seem to be failing are those that require vendor.git or more specificly dev dependencies of vendor.git (If I understand correctly).

Is there anything stopping us from making mediawiki-quibble-composer-mysql voting, as a starting place?

Reedy added a comment.Jul 21 2022, 10:45 PM
In T300463#8096279, @Bawolff wrote:

(perhaps a stupid question): I see that mediawiki-quibble-composer-mysql is passing ( https://integration.wikimedia.org/ci/job/mediawiki-quibble-composer-mysql-php80-docker/67/console ), the tests that seem to be failing are those that require vendor.git (If I understand correctly).

Is there anything stopping us from making mediawiki-quibble-composer-mysql voting, as a starting place?

I don't think so, no. Tim basically confirmed this was working in T283275#7639285 after some fixes.

The big known problems are vendor related (elasticsearch etc).

It would/could help prevent some future regressions on PHP 8.

If we can do the same on supported release branches too (if that job passes there too?), that'd be cool.

Reedy added a comment.Jul 21 2022, 10:55 PM

Looks like mediawiki-quibble-composertest-php80-docker passes on release branches (because of stripped vendor).

I think promoting that at the same time (for release branches) would be good too.

Reedy added a comment.Jul 21 2022, 10:56 PM
In T300463#8096390, @Reedy wrote:

Looks like mediawiki-quibble-composertest-php80-docker passes on release branches (because of stripped vendor).

I think promoting that at the same time (for release branches) would be good too.

Scrap that. We already have.

Reedy changed the task status from Stalled to Open.Jul 21 2022, 10:57 PM
Bawolff added a comment.Jul 21 2022, 11:50 PM

I guess we could have a file in vendor.git with overrides for php 8, and if quibble detects its on php8, it runs composer require $LISTOFOVERRIDES

gerritbot added a comment.Jul 22 2022, 12:09 AM

Change 815985 had a related patch set uploaded (by Reedy; author: Reedy):

[integration/config@master] Promote mediawiki-quibble-composer-mysql-php80-docker

https://gerrit.wikimedia.org/r/815985

gerritbot added a project: Patch-For-Review.Jul 22 2022, 12:09 AM

Change 816062 had a related patch set uploaded (by Brian Wolff; author: Brian Wolff):

[integration/config@master] Make composer-php80 run on gate-and-submit for MW core

https://gerrit.wikimedia.org/r/816062

gerritbot added a comment.Jul 22 2022, 12:14 AM

Change 815985 abandoned by Reedy:

[integration/config@master] Promote mediawiki-quibble-composer-mysql-php80-docker

Reason:

https://gerrit.wikimedia.org/r/815985

Bawolff added a comment.EditedJul 22 2022, 1:38 AM

Well looks like it does not pass on 1.35 yet. Somehow on 1.37 it seems to consistently segfault.

Reedy added a comment.Jul 23 2022, 5:22 PM
In T300463#8096655, @Bawolff wrote:

Well looks like it does not pass on 1.35 yet. Somehow on 1.37 it seems to consistently segfault.

Some of those are at T274966: Make MW 1.35 tests pass on PHP 8.0.

gerritbot added a comment.Jul 27 2022, 1:55 PM

Change 816062 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/core] Add a non-vendor php80 job for main branch

https://gerrit.wikimedia.org/r/816062

Stashbot added a comment.Jul 27 2022, 1:55 PM

Mentioned in SAL (#wikimedia-releng) [2022-07-27T13:55:56Z] <James_F> Zuul: [mediawiki/core] Add a non-vendor php80 job for main branch T300463

Jdforrester-WMF updated the task description. (Show Details)Jul 27 2022, 1:56 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 27 2022, 2:31 PM
Umherirrender added a subscriber: Umherirrender.Aug 13 2022, 7:53 PM
In T300463#8108195, @Stashbot wrote:

Mentioned in SAL (#wikimedia-releng) [2022-07-27T13:55:56Z] <James_F> Zuul: [mediawiki/core] Add a non-vendor php80 job for main branch T300463

There are flaky Segmentation fault fails, see T315167

hashar added a subtask: T315167: CI job mediawiki-quibble-composer-mysql-php80-docker on mediawiki/core gate-and-submit is flaky failing with Segmentation fault.Aug 16 2022, 9:51 AM
Jdforrester-WMF closed subtask T315167: CI job mediawiki-quibble-composer-mysql-php80-docker on mediawiki/core gate-and-submit is flaky failing with Segmentation fault as Resolved.Aug 24 2022, 12:54 PM
Jdforrester-WMF reopened subtask T315167: CI job mediawiki-quibble-composer-mysql-php80-docker on mediawiki/core gate-and-submit is flaky failing with Segmentation fault as Open.Aug 25 2022, 9:21 AM
Umherirrender removed a subscriber: Umherirrender.Aug 31 2022, 8:04 PM
Jdforrester-WMF changed the status of subtask T315167: CI job mediawiki-quibble-composer-mysql-php80-docker on mediawiki/core gate-and-submit is flaky failing with Segmentation fault from Open to Stalled.Sep 28 2022, 8:25 PM
Jdforrester-WMF closed subtask T283275: Make MW master tests pass on PHP 8.0 as Resolved.Sep 30 2022, 2:06 AM
Reedy closed subtask T313564: Bump onoi/message-reporter in vendor.git to 1.4.2 for php 8 support as Resolved.Sep 30 2022, 2:23 AM
Reedy closed subtask T313563: Bump lcobucci/jwt & league/uri-components for php8 as Resolved.
gerritbot added a comment.Sep 30 2022, 2:25 AM

Change 836977 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: [mediawiki/core] Upgrade PHP 8.0 and 8.1 jobs to full vendor jobs

https://gerrit.wikimedia.org/r/836977

gerritbot added a project: Patch-For-Review.Sep 30 2022, 2:25 AM

Change 836979 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: Make PHP 8.0 and PHP 8.1 voting for all skins and extensions

https://gerrit.wikimedia.org/r/836979

gerritbot added a comment.Sep 30 2022, 2:29 AM

Change 836977 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/core] Upgrade PHP 8.0 and 8.1 jobs to full vendor jobs

https://gerrit.wikimedia.org/r/836977

Stashbot added a comment.Sep 30 2022, 2:30 AM

Mentioned in SAL (#wikimedia-releng) [2022-09-30T02:30:34Z] <James_F> Zuul: [mediawiki/core] Upgrade PHP 8.0 and 8.1 jobs to full vendor jobs for T300463 and T316078

Stashbot mentioned this in T316078: Make PHP 8.1 voting on development (master) branch of MW ecosystem (core, extensions, skins, libraries).Sep 30 2022, 2:30 AM
Jdforrester-WMF updated the task description. (Show Details)Sep 30 2022, 2:37 AM
kostajh awarded a token.Sep 30 2022, 1:13 PM
Jdforrester-WMF closed subtask T315167: CI job mediawiki-quibble-composer-mysql-php80-docker on mediawiki/core gate-and-submit is flaky failing with Segmentation fault as Resolved.Sep 30 2022, 3:45 PM
gerritbot added a comment.Sep 30 2022, 3:51 PM

Change 836979 merged by jenkins-bot:

[integration/config@master] Zuul: Make PHP 8.0 and PHP 8.1 voting for all skins and extensions

https://gerrit.wikimedia.org/r/836979

Maintenance_bot removed a project: Patch-For-Review.Sep 30 2022, 4:31 PM
Stashbot added a comment.Sep 30 2022, 4:46 PM

Mentioned in SAL (#wikimedia-releng) [2022-09-30T16:46:38Z] <James_F> Zuul: Make PHP 8.0 and PHP 8.1 voting for all skins and extensions in master for T300463 and T316078

Jdforrester-WMF closed this task as Resolved.Sep 30 2022, 6:16 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Now done everywhere.

Umherirrender mentioned this in T323056: STVTallierTest::testFinishTally() fails under PHP 8.0 and later.Nov 14 2022, 6:24 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL