Page MenuHomePhabricator
Create Task
Maniphest T300463

Make PHP 8.0 voting on MW master
Open, Needs TriagePublic
Actions

Description

Status as of 2022-07-27: Partially done.

See also: T274965: Make PHP 8.0 voting on currently supported MW release branches

Details

ProjectBranchLines +/-Subject
integration/configmaster+4 -0Zuul: [mediawiki/core] Add a non-vendor php80 job for main branch
integration/configmaster+0 -0Promote mediawiki-quibble-composer-mysql-php80-docker
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT248925 Make MediaWiki compatible with PHP 8
 OpenNoneT300463 Make PHP 8.0 voting on MW master
 OpenNoneT283275 Make MW master tests pass on PHP 8.0
 OpenNoneT271777 Bump rufin/elastica (and related libraries) to versions that support PHP 8.0
 OpenNoneT263142 [EPIC] Upgrade Elasticsearch to version 7.10
 OpenEBernhardsonT218994 Deprecation warning on elasticsearch 6
ResolvedEBernhardsonT218995 re-enable deprecation warning logger on elasticsearch once issues are solved
 Resolved• dcausseT219265 Elasticsearch 6: _retry_on_conflict is deprecated
 Resolved• dcausseT219266 Elasticsearch 6 nested_path and nested_filter are deprecated
 Resolved• dcausseT219267 Elasticsearch 6: auto_generate_phrase_queries is deprecated and ineffective
 Resolved• dcausseT219268 Elasticsearch 6: the classic similarity is deprecated
 Resolved• dcausseT219533 Reindex space less languages wikis to use BM25
 OpenNoneT219534 Test MLR models for zhwiki, jawiki and kowiki
 ResolvedEBernhardsonT219269 Elasticsearch 6: silence deprecation warnings to avoid logspam
 DuplicateNoneT215615 Stop using negative scores for deboosting statements
 ResolvedEBernhardsonT288764 Set include_type_name in all get requests
 ResolvedEJosephT288765 Always provide minimum_should_match in bool queries
 ResolvedEBernhardsonT306123 Ensure mjolnir models have positive scores
 DuplicateNoneT273814 Create ElasticSearch 7.10 image in releng/dev-images
 ResolvedGehelT295666 Upgrade Cirrus elasticsearch clusters to 6.8.23
 ResolvedEJosephT294499 Upgrade Cirrus elasticsearch plugins to 6.8.23
 ResolvedbkingT301954 Upgrade deployment-prep to elasticsearch 6.8.23
 ResolvedbkingT301955 Upgrade relforge to elasticsearch 6.8.23
 ResolvedRKemperT278378 Pull Elasticsearch config out of Spicerack
 ResolvedRKemperT301956 Upgrade cloudelastic to elasticsearch 6.8.23
 ResolvedRKemperT301958 Upgrade Search elasticsearch cluster / codfw to elasticsearch 6.8.23
 ResolvedRKemperT301959 Upgrade Search elasticsearch cluster / eqiad to elasticsearch 6.8.23
 ResolvedGehelT304570 elasticsearch: make rolling upgrade proceed to second host after shards are stable
 OpenbkingT289135 Upgrade Cirrus Elasticsearch clusters to Debian Bullseye
 ResolvedbkingT299797 Deploy new bullseye elastic cluster nodes on deployment-prep
 ResolvedbkingT301408 Enable search team SRE access to deployment-prep VMs
 ResolvedbkingT307510 Update tls proxy config for Bullseye
 ResolvedbkingT308770 Reimage relforge elastic hosts from Stretch to Bullseye
 ResolvedbkingT309343 Upgrade cloudelastic clusters to Debian Bullseye
 ResolvedbkingT312298 Update NIC firmware on all Elastic PowerEdge R440 elastic hosts
 ResolvedEBernhardsonT295736 Evaluate deployed elasticsearch plugins for 7.10 compatability
 ResolvedEBernhardsonT295734 Bring up two copies of the CirrusSearch browser integration env in cloud
 ResolvedTJonesT300302 Test Elastic 6.8 language analyzers
 Resolved• ZbyszkoT300833 Address "Log4shell" vulnerability in Elasticsearch 7.10.2
 DeclinedNoneT301724 Sunset ApiFeatureUsage
 DeclinedJenlenfantwrightT302638 Sunset ApiFeatureUsage (TDMP)
 OpenTJonesT301131 Test Elastic 7.10 language analyzers
 DeclinedNoneT303443 Ensure that all applications depending on the Search Elasticsearch cluster are compatible with Elasticsearch 7.10
 Resolvedbd808T303444 Ensure Toolhub is compatible with Elasticsearch 7.10
 DeclinedNoneT303445 Ensure Phabricator is compatible with Elasticsearch 7.10
 ResolvedEBernhardsonT304290 Create docker elasticsearch images with wmf search plugins
 DeclinedNoneT304569 Remove row/rack awareness in Elasticsearch config
 Resolved• dcausseT305428 Upgrade the Translate TTM Elasticsearch implementation to elasticsearch 6.8 and onwards
ResolvedEBernhardsonT306644 re-run wbsearchentities optimization process
ResolvedEBernhardsonT307931 Run CirrusSearch test suite against Elasticsearch 7.10
 OpenEBernhardsonT308676 Elasticsearch 7.10.2 rollout plan
 OpenEBernhardsonT313434 Migrate apifeatureusage to elasticsearch 7
 OpenNoneT313563 Bump lcobucci/jwt & league/uri-components for php8
 OpenNoneT313564 Bump onoi/message-reporter in vendor.git to 1.4.2 for php 8 support
 OpenNoneT315167 CI job mediawiki-quibble-composer-mysql-php80-docker on mediawiki/core gate-and-submit is flaky failing with Segmentation fault

Event Timeline

Reedy created this task.Jan 30 2022, 5:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 30 2022, 5:20 PM
Reedy added a subtask: T283275: Make MW master tests pass on PHP 8.0.Jan 30 2022, 5:20 PM
Reedy added a parent task: T248925: Make MediaWiki compatible with PHP 8.
Amire80 awarded a token.Jan 30 2022, 6:30 PM
Reedy changed the task status from Open to Stalled.Feb 9 2022, 12:39 AM
Reedy moved this task from Backlog to MediaWiki core on the PHP 8.0 support board.Mar 28 2022, 3:15 PM
Reedy mentioned this in T312971: Enable PHP 8 CI for ProofreadPage.Thu, Jul 21, 8:13 PM
Bawolff added a subscriber: Bawolff.EditedThu, Jul 21, 10:21 PM

(perhaps a stupid question): I see that mediawiki-quibble-composer-mysql is passing ( https://integration.wikimedia.org/ci/job/mediawiki-quibble-composer-mysql-php80-docker/67/console ), the tests that seem to be failing are those that require vendor.git or more specificly dev dependencies of vendor.git (If I understand correctly).

Is there anything stopping us from making mediawiki-quibble-composer-mysql voting, as a starting place?

Reedy added a comment.Thu, Jul 21, 10:45 PM
In T300463#8096279, @Bawolff wrote:

(perhaps a stupid question): I see that mediawiki-quibble-composer-mysql is passing ( https://integration.wikimedia.org/ci/job/mediawiki-quibble-composer-mysql-php80-docker/67/console ), the tests that seem to be failing are those that require vendor.git (If I understand correctly).

Is there anything stopping us from making mediawiki-quibble-composer-mysql voting, as a starting place?

I don't think so, no. Tim basically confirmed this was working in T283275#7639285 after some fixes.

The big known problems are vendor related (elasticsearch etc).

It would/could help prevent some future regressions on PHP 8.

If we can do the same on supported release branches too (if that job passes there too?), that'd be cool.

Reedy added a comment.Thu, Jul 21, 10:55 PM

Looks like mediawiki-quibble-composertest-php80-docker passes on release branches (because of stripped vendor).

I think promoting that at the same time (for release branches) would be good too.

Reedy added a comment.Thu, Jul 21, 10:56 PM
In T300463#8096390, @Reedy wrote:

Looks like mediawiki-quibble-composertest-php80-docker passes on release branches (because of stripped vendor).

I think promoting that at the same time (for release branches) would be good too.

Scrap that. We already have.

Reedy changed the task status from Stalled to Open.Thu, Jul 21, 10:57 PM
Bawolff added a comment.Thu, Jul 21, 11:50 PM

I guess we could have a file in vendor.git with overrides for php 8, and if quibble detects its on php8, it runs composer require $LISTOFOVERRIDES

gerritbot added a comment.Fri, Jul 22, 12:09 AM

Change 815985 had a related patch set uploaded (by Reedy; author: Reedy):

[integration/config@master] Promote mediawiki-quibble-composer-mysql-php80-docker

https://gerrit.wikimedia.org/r/815985

gerritbot added a project: Patch-For-Review.Fri, Jul 22, 12:09 AM

Change 816062 had a related patch set uploaded (by Brian Wolff; author: Brian Wolff):

[integration/config@master] Make composer-php80 run on gate-and-submit for MW core

https://gerrit.wikimedia.org/r/816062

gerritbot added a comment.Fri, Jul 22, 12:14 AM

Change 815985 abandoned by Reedy:

[integration/config@master] Promote mediawiki-quibble-composer-mysql-php80-docker

Reason:

https://gerrit.wikimedia.org/r/815985

Bawolff added a comment.EditedFri, Jul 22, 1:38 AM

Well looks like it does not pass on 1.35 yet. Somehow on 1.37 it seems to consistently segfault.

Reedy added a comment.Sat, Jul 23, 5:22 PM
In T300463#8096655, @Bawolff wrote:

Well looks like it does not pass on 1.35 yet. Somehow on 1.37 it seems to consistently segfault.

Some of those are at T274966: Make MW 1.35 tests pass on PHP 8.0.

gerritbot added a comment.Wed, Jul 27, 1:55 PM

Change 816062 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/core] Add a non-vendor php80 job for main branch

https://gerrit.wikimedia.org/r/816062

Stashbot added a comment.Wed, Jul 27, 1:55 PM

Mentioned in SAL (#wikimedia-releng) [2022-07-27T13:55:56Z] <James_F> Zuul: [mediawiki/core] Add a non-vendor php80 job for main branch T300463

Jdforrester-WMF updated the task description. (Show Details)Wed, Jul 27, 1:56 PM
Maintenance_bot removed a project: Patch-For-Review.Wed, Jul 27, 2:31 PM
Umherirrender added a subscriber: Umherirrender.Sat, Aug 13, 7:53 PM
In T300463#8108195, @Stashbot wrote:

Mentioned in SAL (#wikimedia-releng) [2022-07-27T13:55:56Z] <James_F> Zuul: [mediawiki/core] Add a non-vendor php80 job for main branch T300463

There are flaky Segmentation fault fails, see T315167

hashar added a subtask: T315167: CI job mediawiki-quibble-composer-mysql-php80-docker on mediawiki/core gate-and-submit is flaky failing with Segmentation fault.Tue, Aug 16, 9:51 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL