Add "php 7.4" option to the Wikimedia Debug extension
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Joe
	Jul 8 2022, 2:46 PM

Description

We need to add an option to the interface of the extension to allow selecting php 7.4 - a radio button would be ok.

Then we need to work on the backend, basically adding to modules/profile/files/trafficserver/x-wikimedia-debug-routing.lua some lines to add PHP_ENGINE=7.4 to the cookies in the request if we find the relevant string.

Details

Subject	Repo	Branch	Lines +/-
Remove temporary "php74" option	performance/WikimediaDebug	master	+0 -9
trafficserver: allow x-wikimedia-debug to pick a php backend	operations/puppet	production	+51 -1
Add missing reset for php74	performance/WikimediaDebug	master	+4 -2
popup: Let options continue to render under the main toggle	performance/WikimediaDebug	master	+5 -15
Add switch for serving content via PHP 7.4	performance/WikimediaDebug	master	+11 -2

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		None	T248925 Make MediaWiki release tarball compatible with PHP 8.0
Resolved		Jdforrester-WMF	T300463 Make PHP 8.0 voting on MW master
Resolved		Jdforrester-WMF	T313563 Bump lcobucci/jwt & league/uri-components for php8
Resolved		Jdforrester-WMF	T313564 Bump onoi/message-reporter in vendor.git to 1.4.2 for php 8 support
Resolved		Jdforrester-WMF	T247658 Make Wikimedia Production MediaWiki compatible with PHP 7.4
Resolved		• toan	T243590 Fix WikibaseDataModel CI for php 7.4
Resolved		Lucas_Werkmeister_WMDE	T316923 Restore skipped test in ReferenceListTest.php
Resolved		Joe	T318918 Undeploy patch to use old PHP serialization in PHP 7.4
Resolved		Jdforrester-WMF	T264168 Drop PHP 7.2 support from Wikibase master branch, once Wikimedia production is on 7.4
Resolved		Ladsgroup	T270740 Drop hacky support for doctrine/dbal class renaming
Invalid		None	T303505 [S] Remove Deprecated methods "serialize" and "unserialize" after php production upgrade to PHP 7.4
Resolved		Reedy	T251043 Cleanup css-sanitizer when it only requires PHP >= 7.4
Open		None	T166010 The Great Namespaceization Effort
Resolved		tstarling	T277618 var_dump() on various objects writes gigabytes of data and takes minutes to run
Resolved		Jdforrester-WMF	T261872 Drop PHP 7.2 & 7.3 support from MediaWiki master branch, once Wikimedia production is on 7.4
Resolved	PRODUCTION ERROR	Legoktm	T293568 PHP Notice: Undefined offset in wikimedia/remex-html when rendering rest.php error page
Resolved		tstarling	T297667 mysqli/mysqlnd memory leak
Resolved		Joe	T271736 Migrate WMF production from PHP 7.2 to PHP 7.4
Resolved		Mainframe98	T312653 Add "php 7.4" option to the Wikimedia Debug extension

Event Timeline

Joe created this task.Jul 8 2022, 2:46 PM

Reedy updated the task description. (Show Details)Jul 8 2022, 6:01 PM

Krinkle added a project: WikimediaDebug.Jul 8 2022, 9:44 PM

Mainframe98 mentioned this in T312694: Support WebExtensions Manifest v3.Jul 9 2022, 10:00 AM

Change 812444 had a related patch set uploaded (by Mainframe98; author: Mainframe98):

[performance/WikimediaDebug@master] Add switch for serving content via PHP 7.4

https://gerrit.wikimedia.org/r/812444

gerritbot added a project: Patch-For-Review.Jul 9 2022, 11:24 AM

I'd appreciate another pair of eyes on the patch I uploaded. I cannot get the debug header to actually contain anything but the debug host; none of the other options such as readonly have any effect. This was already like this in 2.4.6, so it's not something I did.

Instructions on how to test it are in the readme.

In T312653#8067203, @Mainframe98 wrote:

I cannot get the debug header to actually contain anything but the debug host; none of the other options such as readonly have any effect. This was already like this in 2.4.6, so it's not something I did. […]

I've checked the other three, and those appear to work fine, e.g. inline profile, XHGui, and Verbose log. There appears to be something funky with the readonly option indeed.

Change 812444 merged by jenkins-bot:

[performance/WikimediaDebug@master] Add switch for serving content via PHP 7.4

https://gerrit.wikimedia.org/r/812444

Change 816230 had a related patch set uploaded (by Krinkle; author: Krinkle):

[performance/WikimediaDebug@master] popup: Let options continue to render under the main toggle

https://gerrit.wikimedia.org/r/816230

Change 816230 merged by jenkins-bot:

[performance/WikimediaDebug@master] popup: Let options continue to render under the main toggle

https://gerrit.wikimedia.org/r/816230

Change 816233 had a related patch set uploaded (by Krinkle; author: Krinkle):

[performance/WikimediaDebug@master] Add missing reset for php74

https://gerrit.wikimedia.org/r/816233

Change 816233 merged by jenkins-bot:

[performance/WikimediaDebug@master] Add missing reset for php74

https://gerrit.wikimedia.org/r/816233

Maintenance_bot removed a project: Patch-For-Review.Jul 23 2022, 7:30 AM

Hi! When do you think we can make a release of the extension? What will be sent over the wire?

Krinkle mentioned this in T314108: Release WikimediaDebug 2.5.0.Jul 29 2022, 4:40 AM

Krinkle removed a subtask: T314108: Release WikimediaDebug 2.5.0.

In T312653#8111239, @Joe wrote:

Hi! When do you think we can make a release of the extension? What will be sent over the wire?

Submitted to web stores yesterday (T314108) and is live now. It sets a php74 attribute, similar to other XWD attributes. E.g.

X-Wikimedia-Debug; backend=; php74
X-Wikimedia-Debug: backend=mwdebug1001.eqiad.wmnet; php74
X-Wikimedia-Debug: backend=mwdebug1001.eqiad.wmnet; log; php74; querysort

Change 819510 had a related patch set uploaded (by Giuseppe Lavagetto; author: Giuseppe Lavagetto):

[operations/puppet@production] trafficserver: allow x-wikimedia-debug to pick a php backend

https://gerrit.wikimedia.org/r/819510

gerritbot added a project: Patch-For-Review.Aug 2 2022, 9:58 AM

Change 819510 merged by Giuseppe Lavagetto:

[operations/puppet@production] trafficserver: allow x-wikimedia-debug to pick a php backend

https://gerrit.wikimedia.org/r/819510

Krinkle closed this task as Resolved.Aug 9 2022, 10:55 AM

Change 836924 had a related patch set uploaded (by Krinkle; author: Krinkle):

[performance/WikimediaDebug@master] Remove temporary "php74" option

https://gerrit.wikimedia.org/r/836924

Change 836924 merged by jenkins-bot: