Page MenuHomePhabricator
Create Task
Maniphest T318918

Undeploy patch to use old PHP serialization in PHP 7.4
Closed, ResolvedPublic
Actions

Description

As part of the production migration to PHP 7.4 (sharing some caches with PHP 7.2), we patched our PHP 7.4 to emit 7.2-compatible serialization.

In T316601#8198429, @tstarling wrote:

I think I can patch PHP 7.4 so that its serialize() is backwards compatible. Just like so, effectively a partial revert of nikic's implementation patch. A patched PHP binary would be able to read the new format, but would not write it. So we would migrate fully to the patched PHP 7.4, then when we are sure there will be no need to revert back to PHP 7.2, we would revert the patch.

This worked, but broke some tests that expected PHP 7.4 to emit the new serialization.

In T316601#8207954, @hashar wrote:

For information: after I have deployed our patched php7.4 to CI, a Wikibase test started failing. The test asserts against serialize() output based on version_compare( phpversion(), '7.4', '>=' ) ) but since our 7.4 yields the previous serialization format the assertion fails. We talked about it and will mark the test skipped until we switch to the un patched 7.4. T243590#8207874

Once the migration to PHP 7.4 in production is finished (T271736 or T318894), we should remove this patch again, and use the new serialization.

Details

SubjectRepoBranchLines +/-
jjb: update jobs for newer Wikimedia's php 7.4integration/configmaster+42 -42
dockerfiles: [php74] Re-build to pick up newer version of Wikimedia's PHPintegration/configmaster+90 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedJdforrester-WMFT247658 Make Wikimedia Production MediaWiki compatible with PHP 7.4
 Resolved• toanT243590 Fix WikibaseDataModel CI for php 7.4
 ResolvedLucas_Werkmeister_WMDET316923 Restore skipped test in ReferenceListTest.php
 ResolvedJoeT318918 Undeploy patch to use old PHP serialization in PHP 7.4
 ResolvedJoeT271736 Migrate WMF production from PHP 7.2 to PHP 7.4
 ResolvedDzahnT245757 Upgrade MediaWiki clusters to Debian Buster (debian 10)
 ResolvedhasharT252434 Test MW code in buster as well as stretch
 ResolvedJdforrester-WMFT250514 Create buster-based images for quibble
 ResolvedLadsgroupT279068 Wikibase data-client bridge selenium failure on buster but not stretch
 ResolvedMoritzMuehlenhoffT250515 Please provide our special component/php72 in buster-wikimedia
 ResolvedjijikiT264991 Upgrade the MediaWiki servers to ICU 63
 ResolvedMoritzMuehlenhoffT253377 WMF deployed EasyTimeline extension depends on Ploticus package which is not available in Debian Buster (but available again in Debian Bullseye)
 ResolvedTrizek-WMFT267145 CommRel support for ICU 63 upgrade
 ResolvedDzahnT267248 create mwdebug1003 - ganeti VM with buster and appserver role
 Resolved• GillesT268188 Release WikimediaDebug for mwdebug1003 addition
 ResolvedDzahnT267607 upgrade mwmaint servers to buster
ResolvedRequestPapaulT275928 decommission mwmaint2001.codfw.wmnet
 ResolvedjijikiT268524 Upgrade Parsoid servers to buster
DeclinedNoneT245888 Rename wtp* servers to parse* (Parsoid PHP servers)
 ResolvedDzahnT268248 upgrade scandium to buster
 ResolvedDzahnT265963 Replace production deployment servers and update them to Buster
Unknown Object (Task)
 ResolvedPapaulT266363 (Need By: TBD) rack/setup/install deploy2002
 Resolved• CmjohnsonT265653 (Need By: TBD) setup/install deploy1002
 ResolvedRequest• CmjohnsonT275831 decommission deploy1001.eqiad.wmnet
 ResolvedRequestPapaulT275832 decommission deploy2001.codfw.wmnet
 ResolvedAndrewT269004 Upgrade labweb servers to buster
 ResolvedArielGlennT269377 Upgrade snapshot hosts to Buster
 ResolvedDzahnT270517 Investigate opcache hit rate on Buster appserver
 ResolvedLegoktmT273312 Investigate possible performance degradation on mediawiki servers after Debian Buster upgrade
 ResolvedPapaulT273803 mw2220 - broken IPMI / mgmt
ResolvedDzahnT274023 Convert mwdebug VMs to debian buster
 Declined• GillesT274026 Add 3 new canaries to WikimediaDebug
 ResolvedVolansT274689 sre.hosts.decomission -> generate_dns_snippets - > Cumin execution failed
 ResolvedDzahnT274403 mw1379 - down after reboot attempt and DRAC can't powercycle
 ResolvedLegoktmT275752 Jobrunner timeouts on cross-DC file uploads because of HTTP/2
 ResolvedPleaseStandT291127 MediaWiki session management does not work on split PHP 7.4 and < PHP 7.4 cluster
 ResolvedJoeT293450 Allow coexisting php version in our puppet code
 ResolvedtstarlingT295578 Test running php7.2 and php7.4 in parallel on the beta cluster
 ResolvedArielGlennT295580 Test php7.4 for dumps generation
 ResolvedJoeT293451 Allow sending traffic to php 7.2 or 7.4 selectively in the apache configuration for MediaWiki
 ResolvedtstarlingT263437 Allow easier ICU transitions in MediaWiki (change how sortkey collation is managed in the categorylinks table)
 ResolvedJdforrester-WMFT293924 Also run PHP 7.4 jobs on wmf branch patches
 ResolvedJdforrester-WMFT293851 Re-build all CI images of PHP 7.4 from sury's package to Wikimedia's one, to assure us that it will work
 ResolvedLegoktmT293449 Package php 7.4 for wikimedia production
 ResolvedJdforrester-WMFT295285 Upgrade primary branch of all Wikimedia-deployed repos to a version of mediawiki-tools-phan including T270553
 ResolvedDaimonaT295286 Release mediawiki-tools-phan 0.11.1
 ResolvedDaimonaT270553 Should mediawiki/mediawiki-phan-config ship a target php version to support running with newer php on the developer side?
 ResolvedJdforrester-WMFT314896 WikiEditor edit sampling code triggers 'PHP Deprecated: Invalid characters passed for attempted conversion, these have been ignored' on PHP7.4+
ResolvedJoeT293996 Build MediaWiki images for kubernetes based on php 7.4
 ResolvedJMeybohmT295725 Stop loading wddx PHP extension
 ResolvedJoeT306042 Serve beta cluster via PHP 7.4 by default
 ResolvedJoeT311386 Install php 7.4 in production
 ResolvedJoeT312634 Properly support php7.4 across the observability stack
 ResolvedJoeT313505 Remove prometheus-phpfpm-exporter from physical hosts
 ResolvedKrinkleT311388 Allow assigning each user to a specific php engine by setting a PHP_ENGINE cookie
 ResolvedJoeT311479 Split edge caches between php versions
 ResolvedClement_GoubertT312638 Parsoid migration to php 7.4
 ResolvedClement_GoubertT307219 Put parse parse10[01-24] in production
 ResolvedClement_GoubertT318946 Parsoid migration: Cleanup
 ResolvedMainframe98T312653 Add "php 7.4" option to the Wikimedia Debug extension
 ResolvedJoeT318894 Remove php 7.2 from production

Event Timeline

Lucas_Werkmeister_WMDE created this task.Sep 29 2022, 10:54 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 29 2022, 10:54 AM
Lucas_Werkmeister_WMDE added a comment.Sep 29 2022, 10:55 AM

Just filing this task for tracking, since I couldn’t find an existing task for it. Not sure which tags / projects it should have, to be honest.

Lucas_Werkmeister_WMDE added a subtask: T271736: Migrate WMF production from PHP 7.2 to PHP 7.4.Sep 29 2022, 10:55 AM
taavi added projects: SRE, serviceops.Sep 29 2022, 10:56 AM
Lucas_Werkmeister_WMDE mentioned this in T316601: PHP Warning: Erroneous data format for unserializing 'Wikimedia\Rdbms\MySQLPrimaryPos'.Sep 29 2022, 10:56 AM
Lucas_Werkmeister_WMDE added a parent task: T316923: Restore skipped test in ReferenceListTest.php.
Lucas_Werkmeister_WMDE mentioned this in T305785: Wikibase Snak hashes (and thus "mainsnak", "references" and "qualifiers" hashes) depend on legacy PHP serialization.Sep 29 2022, 10:58 AM
Zabe subscribed.Sep 29 2022, 11:02 AM
Lucas_Werkmeister_WMDE added a project: Continuous-Integration-Infrastructure.Sep 29 2022, 11:02 AM

Adding Continuous-Integration-Infrastructure (or should it be Continuous-Integration-Config?) since the patched PHP is also used in CI. (I assume that doesn’t need a separate task, but feel free to create one if I’m wrong.)

Jdforrester-WMF added a parent task: T305785: Wikibase Snak hashes (and thus "mainsnak", "references" and "qualifiers" hashes) depend on legacy PHP serialization.Sep 30 2022, 6:48 PM
Joe triaged this task as High priority.Oct 3 2022, 8:29 AM
Joe moved this task from Incoming 🐫 to API Gateway 🥌 on the serviceops board.
Lucas_Werkmeister_WMDE mentioned this in T301248: Handle deprecation of Serializable interface in WikibaseLexeme.Oct 5 2022, 9:11 AM
Joe claimed this task.Oct 6 2022, 5:46 AM
Joe moved this task from API Gateway 🥌 to Doing 😎 on the serviceops board.
Stashbot added a comment.Oct 6 2022, 8:59 AM

Mentioned in SAL (#wikimedia-operations) [2022-10-06T08:59:23Z] <_joe_> uploaded new php 7.4 packages T318918

Stashbot added a comment.Oct 6 2022, 9:21 AM

Mentioned in SAL (#wikimedia-operations) [2022-10-06T09:21:34Z] <_joe_> installed the upgraded php package to mw1414, T318918

Stashbot added a comment.Oct 6 2022, 10:51 AM

Mentioned in SAL (#wikimedia-operations) [2022-10-06T10:51:39Z] <_joe_> installing the upgraded php package everywhere, T318918

Joe closed this task as Resolved.Oct 6 2022, 11:21 AM
Joe closed subtask T271736: Migrate WMF production from PHP 7.2 to PHP 7.4 as Resolved.Oct 6 2022, 11:30 AM
Lucas_Werkmeister_WMDE reopened this task as Open.Oct 6 2022, 12:52 PM

As far as I can tell, this is done in production (thanks Joe!), but not yet in CI – a change I just uploaded for T316923 is still failing in CI due to the different serialization (console).

gerritbot added a comment.Oct 6 2022, 12:56 PM

Change 839517 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] dockerfiles: [php74] Re-build to pick up newer version of Wikimedia's PHP

https://gerrit.wikimedia.org/r/839517

gerritbot added a project: Patch-For-Review.Oct 6 2022, 12:56 PM
gerritbot added a comment.Oct 6 2022, 1:00 PM

Change 839517 merged by jenkins-bot:

[integration/config@master] dockerfiles: [php74] Re-build to pick up newer version of Wikimedia's PHP

https://gerrit.wikimedia.org/r/839517

Stashbot added a comment.Oct 6 2022, 1:00 PM

Mentioned in SAL (#wikimedia-releng) [2022-10-06T13:00:53Z] <James_F> Docker: Building and publishing php74:0.3.2 and cascade for T318918

gerritbot added a comment.Oct 6 2022, 1:15 PM

Change 839520 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] jjb: update jobs for newer Wikimedia's php 7.4

https://gerrit.wikimedia.org/r/839520

gerritbot added a comment.Oct 6 2022, 1:21 PM

Change 839520 merged by jenkins-bot:

[integration/config@master] jjb: update jobs for newer Wikimedia's php 7.4

https://gerrit.wikimedia.org/r/839520

Maintenance_bot removed a project: Patch-For-Review.Oct 6 2022, 1:31 PM
hashar added a comment.Oct 6 2022, 2:00 PM

James has made the necessary CI updates and I have deployed them.

Joe closed this task as Resolved.Oct 6 2022, 2:04 PM
Joe added a subscriber: LucasWerkmeister.

Sorry @LucasWerkmeister I assumed this task was about updating production. Re-resolving then :)

Lucas_Werkmeister_WMDE added a comment.Oct 6 2022, 2:08 PM

The change for T316923 is passing in CI now (currently going through test-and-submit), so I think this is indeed done. Thanks a lot everyone! \o/

Lucas_Werkmeister_WMDE removed a subscriber: LucasWerkmeister.Oct 6 2022, 2:11 PM
Jdforrester-WMF removed a parent task: T305785: Wikibase Snak hashes (and thus "mainsnak", "references" and "qualifiers" hashes) depend on legacy PHP serialization.Oct 13 2022, 1:04 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL