Page MenuHomePhabricator

Split edge caches between php versions
Closed, ResolvedPublic

Description

Given we are going to run multiple versions of php in parallel, it might be smart to separate caches between them for the time being.

This can be accomplished by adding a Vary: header to our responses, and a corresponding faux header to the requests.

The way this is done is as follows:

  • Set the faux request header in varnish if we have a cookie PHP_ENGINE
  • Change the responses in ATS to add a Vary: header

This is similar to what we did in https://gerrit.wikimedia.org/r/c/operations/puppet/+/478680, with the added complication we now use ATS on the backend.

Related Objects

StatusSubtypeAssignedTask
ResolvedNone
ResolvedJdforrester-WMF
ResolvedJdforrester-WMF
ResolvedJdforrester-WMF
ResolvedJdforrester-WMF
Resolved toan
ResolvedLucas_Werkmeister_WMDE
ResolvedJoe
ResolvedJdforrester-WMF
ResolvedLadsgroup
InvalidNone
ResolvedReedy
OpenNone
Resolvedtstarling
ResolvedJdforrester-WMF
ResolvedPRODUCTION ERRORLegoktm
Resolvedtstarling
ResolvedJoe
ResolvedJoe

Event Timeline

Joe triaged this task as High priority.Jun 28 2022, 9:03 AM
Krinkle closed this task as Resolved.EditedSep 26 2022, 8:22 PM
Krinkle claimed this task.
Krinkle reassigned this task from Krinkle to Joe.
Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.
Krinkle subscribed.

Given the rollout of the PHP74 cookie campaign, I assume this has since been resolved.

For future reference, a pointer to where and how the code is this time around, may be useful though. @Joe Can you provide a link?