Maniphest T251043

Cleanup css-sanitizer when it only requires PHP >= 7.4
Open, Stalled, Needs TriagePublic
Actions

Tags

Subscribers

Jdforrester-WMF

Assigned To

None

Authored By

	Reedy
	Apr 25 2020, 8:46 PM

Description

Due to T250934: css-sanitizer PHP 7.4 failure due to SeekableIterator::seek() signature change we had to poke the phan config as a workaround

When the library only needs PHP >=7.4, we can remove this config hack and add the type hint

Details

	Project	Branch	Lines +/-	Subject
	css-sanitizer	master	+6 -0	Set phan allow_method_param_type_widening = true
	css-sanitizer	master	+1 -7	Add int type hint to seek function

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Stalled		None	T251043 Cleanup css-sanitizer when it only requires PHP >= 7.4
		Resolved		Reedy	T250934 css-sanitizer PHP 7.4 failure due to SeekableIterator::seek() signature change

Event Timeline

Reedy created this task.Apr 25 2020, 8:46 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 25 2020, 8:46 PM

Reedy added a subtask: T250934: css-sanitizer PHP 7.4 failure due to SeekableIterator::seek() signature change.Apr 25 2020, 8:46 PM

Change 592182 had a related patch set uploaded (by Reedy; owner: Reedy):
[css-sanitizer@master] Add int type hint to seek function

https://gerrit.wikimedia.org/r/592182

gerritbot added a project: Patch-For-Review.Apr 25 2020, 8:47 PM

Marking stalled against whenever we bump required PHP version >= 7.4 for MW core et al

Change 592465 had a related patch set uploaded (by Reedy; owner: Reedy):
[css-sanitizer@master] Set phan allow_method_param_type_widening = true

https://gerrit.wikimedia.org/r/592465

Reedy moved this task from Backlog to Wikimedia production on the PHP 7.4 support board.Apr 26 2020, 11:04 PM

Change 592465 merged by jenkins-bot:
[css-sanitizer@master] Set phan allow_method_param_type_widening = true

https://gerrit.wikimedia.org/r/592465

Reedy closed subtask T250934: css-sanitizer PHP 7.4 failure due to SeekableIterator::seek() signature change as Resolved.Apr 27 2020, 4:13 PM

Reedy added a parent task: T247658: Make Wikimedia Production MediaWiki compatible with PHP 7.4.

Reedy mentioned this in rCSSS9b47fecc4338: Set phan allow_method_param_type_widening = true.Apr 27 2020, 10:10 PM

This doesn't block anything, least of all making MW work in 7.4+.

Jdforrester-WMF removed a parent task: T247658: Make Wikimedia Production MediaWiki compatible with PHP 7.4.May 26 2020, 3:58 PM