Page MenuHomePhabricator
Create Task
Maniphest T251043

Cleanup css-sanitizer when it only requires PHP >= 7.4
Open, Stalled, Needs TriagePublic
Actions

Description

Due to T250934: css-sanitizer PHP 7.4 failure due to SeekableIterator::seek() signature change we had to poke the phan config as a workaround

When the library only needs PHP >=7.4, we can remove this config hack and add the type hint

Details

ProjectBranchLines +/-Subject
css-sanitizermaster+6 -0Set phan allow_method_param_type_widening = true
css-sanitizermaster+1 -7Add int type hint to seek function
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 StalledNoneT251043 Cleanup css-sanitizer when it only requires PHP >= 7.4
 ResolvedReedyT250934 css-sanitizer PHP 7.4 failure due to SeekableIterator::seek() signature change
 StalledNoneT278139 Drop PHP 7.3 support in MediaWiki when appropriate
 StalledNoneT261872 Drop PHP 7.2 support from MediaWiki master branch, once Wikimedia production is on 7.4
 OpenNoneT271736 Migrate WMF production from PHP 7.2 to PHP 7.4
 ResolvedDzahnT245757 Upgrade MediaWiki clusters to Debian Buster (debian 10)
 ResolvedhasharT252434 Test MW code in buster as well as stretch
 ResolvedJdforrester-WMFT250514 Create buster-based images for quibble
 ResolvedLadsgroupT279068 Wikibase data-client bridge selenium failure on buster but not stretch
 ResolvedMoritzMuehlenhoffT250515 Please provide our special component/php72 in buster-wikimedia
 ResolvedjijikiT264991 Upgrade the MediaWiki servers to ICU 63
 ResolvedMoritzMuehlenhoffT253377 WMF deployed EasyTimeline extension depends on Ploticus package which is not available in Debian Buster (but available again in Debian Bullseye)
 ResolvedTrizek-WMFT267145 CommRel support for ICU 63 upgrade
 ResolvedDzahnT267248 create mwdebug1003 - ganeti VM with buster and appserver role
 Resolved• GillesT268188 Release WikimediaDebug for mwdebug1003 addition
 ResolvedDzahnT267607 upgrade mwmaint servers to buster
ResolvedRequestPapaulT275928 decommission mwmaint2001.codfw.wmnet
 ResolvedjijikiT268524 Upgrade Parsoid servers to buster
DeclinedNoneT245888 Rename wtp* servers to parse* (Parsoid PHP servers)
 ResolvedDzahnT268248 upgrade scandium to buster
 ResolvedDzahnT265963 Replace production deployment servers and update them to Buster
Unknown Object (Task)
 ResolvedPapaulT266363 (Need By: TBD) rack/setup/install deploy2002
 ResolvedCmjohnsonT265653 (Need By: TBD) setup/install deploy1002
 ResolvedRequestCmjohnsonT275831 decommission deploy1001.eqiad.wmnet
 ResolvedRequestPapaulT275832 decommission deploy2001.codfw.wmnet
 ResolvedAndrewT269004 Upgrade labweb servers to buster
 ResolvedArielGlennT269377 Upgrade snapshot hosts to Buster
 ResolvedDzahnT270517 Investigate opcache hit rate on Buster appserver
 ResolvedLegoktmT273312 Investigate possible performance degradation on mediawiki servers after Debian Buster upgrade
 ResolvedPapaulT273803 mw2220 - broken IPMI / mgmt
ResolvedDzahnT274023 Convert mwdebug VMs to debian buster
 Declined• GillesT274026 Add 3 new canaries to WikimediaDebug
 ResolvedVolansT274689 sre.hosts.decomission -> generate_dns_snippets - > Cumin execution failed
 ResolvedDzahnT274403 mw1379 - down after reboot attempt and DRAC can't powercycle
 ResolvedLegoktmT275752 Jobrunner timeouts on cross-DC file uploads because of HTTP/2
 ResolvedPleaseStandT291127 MediaWiki session management does not work on split PHP 7.4 and < PHP 7.4 cluster
 OpenNoneT292552 Rename articles and users to prepare for PHP 7.3 unicode changes
 ResolvedJoeT293450 Allow coexisting php version in our puppet code
 OpenJMeybohmT295578 Test running php7.2 and php7.4 in parallel on the beta cluster
 ResolvedArielGlennT295580 Test php7.4 for dumps generation
 OpenNoneT293451 Allow sending traffic to php 7.2 or 7.4 selectively in the apache configuration for MediaWiki
 ResolvedtstarlingT263437 Allow easier ICU transitions in MediaWiki (change how sortkey collation is managed in the categorylinks table)
 OpenJdforrester-WMFT293924 Also run PHP 7.4 jobs on wmf branch patches
 OpenJdforrester-WMFT293851 Re-build all CI images of PHP 7.4 from sury's package to Wikimedia's one, to assure us that it will work
 ResolvedLegoktmT293449 Package php 7.4 for wikimedia production
 OpenLegoktmT243847 Add pcov PHP extension to wikimedia apt so it can be used in Wikimedia CI
 OpenJdforrester-WMFT295285 Upgrade primary branch of all Wikimedia-deployed repos to a version of mediawiki-tools-phan including T270553
 ResolvedDaimonaT295286 Release mediawiki-tools-phan 0.11.1
 ResolvedDaimonaT270553 Should mediawiki/mediawiki-phan-config ship a target php version to support running with newer php on the developer side?
 ResolvedJoeT293996 Build MediaWiki images for kubernetes based on php 7.4
 ResolvedJMeybohmT295725 Stop loading wddx PHP extension
 OpenNoneT306042 Serve beta cluster via PHP 7.4 by default
 ResolvedKrinkleT298914 Decide from which release branch we should drop PHP 7.3 support

Event Timeline

Reedy created this task.Apr 25 2020, 8:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 25 2020, 8:46 PM
Reedy added a subtask: T250934: css-sanitizer PHP 7.4 failure due to SeekableIterator::seek() signature change.Apr 25 2020, 8:46 PM
gerritbot added a comment.Apr 25 2020, 8:47 PM

Change 592182 had a related patch set uploaded (by Reedy; owner: Reedy):
[css-sanitizer@master] Add int type hint to seek function

https://gerrit.wikimedia.org/r/592182

gerritbot added a project: Patch-For-Review.Apr 25 2020, 8:47 PM
Reedy changed the task status from Open to Stalled.Apr 25 2020, 8:47 PM

Marking stalled against whenever we bump required PHP version >= 7.4 for MW core et al

gerritbot added a comment.Apr 25 2020, 8:54 PM

Change 592465 had a related patch set uploaded (by Reedy; owner: Reedy):
[css-sanitizer@master] Set phan allow_method_param_type_widening = true

https://gerrit.wikimedia.org/r/592465

Reedy moved this task from Backlog to Wikimedia production on the PHP 7.4 support board.Apr 26 2020, 11:04 PM
gerritbot added a comment.Apr 27 2020, 4:10 PM

Change 592465 merged by jenkins-bot:
[css-sanitizer@master] Set phan allow_method_param_type_widening = true

https://gerrit.wikimedia.org/r/592465

Reedy closed subtask T250934: css-sanitizer PHP 7.4 failure due to SeekableIterator::seek() signature change as Resolved.Apr 27 2020, 4:13 PM
Reedy added a parent task: T247658: Make Wikimedia Production MediaWiki compatible with PHP 7.4.
Reedy mentioned this in rCSSS9b47fecc4338: Set phan allow_method_param_type_widening = true.Apr 27 2020, 10:10 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.May 26 2020, 3:58 PM

This doesn't block anything, least of all making MW work in 7.4+.

Jdforrester-WMF removed a parent task: T247658: Make Wikimedia Production MediaWiki compatible with PHP 7.4.May 26 2020, 3:58 PM
Izno moved this task from Unsorted to Blocked on the css-sanitizer board.Mar 18 2021, 5:49 PM
Ricordisamoa added a subscriber: Ricordisamoa.Jun 7 2021, 4:33 PM
Izno added a subtask: T278139: Drop PHP 7.3 support in MediaWiki when appropriate.Oct 22 2021, 4:35 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL