Page MenuHomePhabricator

Cleanup css-sanitizer when it only requires PHP >= 7.4
Open, Stalled, Needs TriagePublic

Description

Due to T250934: css-sanitizer PHP 7.4 failure due to SeekableIterator::seek() signature change we had to poke the phan config as a workaround

When the library only needs PHP >=7.4, we can remove this config hack and add the type hint

Related Objects

StatusSubtypeAssignedTask
StalledNone
ResolvedReedy
StalledNone
StalledNone
OpenNone
ResolvedDzahn
Resolvedhashar
ResolvedJdforrester-WMF
ResolvedLadsgroup
ResolvedMoritzMuehlenhoff
Resolvedjijiki
ResolvedMoritzMuehlenhoff
ResolvedTrizek-WMF
ResolvedDzahn
Resolved Gilles
ResolvedDzahn
ResolvedRequestPapaul
Resolvedjijiki
DeclinedNone
ResolvedDzahn
ResolvedDzahn
ResolvedPapaul
ResolvedCmjohnson
ResolvedRequestCmjohnson
ResolvedRequestPapaul
ResolvedAndrew
ResolvedArielGlenn
ResolvedDzahn
ResolvedLegoktm
ResolvedPapaul
ResolvedDzahn
Declined Gilles
ResolvedVolans
ResolvedDzahn
ResolvedLegoktm
ResolvedPleaseStand
OpenNone
ResolvedJoe
OpenJMeybohm
ResolvedArielGlenn
OpenNone
Resolvedtstarling
OpenJdforrester-WMF
OpenJdforrester-WMF
ResolvedLegoktm
OpenLegoktm
OpenJdforrester-WMF
ResolvedDaimona
ResolvedDaimona
ResolvedJoe
ResolvedJMeybohm
OpenNone
ResolvedKrinkle

Event Timeline

Change 592182 had a related patch set uploaded (by Reedy; owner: Reedy):
[css-sanitizer@master] Add int type hint to seek function

https://gerrit.wikimedia.org/r/592182

Reedy changed the task status from Open to Stalled.Apr 25 2020, 8:47 PM

Marking stalled against whenever we bump required PHP version >= 7.4 for MW core et al

Change 592465 had a related patch set uploaded (by Reedy; owner: Reedy):
[css-sanitizer@master] Set phan allow_method_param_type_widening = true

https://gerrit.wikimedia.org/r/592465

Change 592465 merged by jenkins-bot:
[css-sanitizer@master] Set phan allow_method_param_type_widening = true

https://gerrit.wikimedia.org/r/592465

This doesn't block anything, least of all making MW work in 7.4+.