Page MenuHomePhabricator

Cleanup css-sanitizer when it only requires PHP >= 7.4
Open, Stalled, Needs TriagePublic


Due to T250934: css-sanitizer PHP 7.4 failure due to SeekableIterator::seek() signature change we had to poke the phan config as a workaround

When the library only needs PHP >=7.4, we can remove this config hack and add the type hint

Event Timeline

Reedy created this task.Apr 25 2020, 8:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 25 2020, 8:46 PM

Change 592182 had a related patch set uploaded (by Reedy; owner: Reedy):
[css-sanitizer@master] Add int type hint to seek function

Reedy changed the task status from Open to Stalled.Apr 25 2020, 8:47 PM

Marking stalled against whenever we bump required PHP version >= 7.4 for MW core et al

Change 592465 had a related patch set uploaded (by Reedy; owner: Reedy):
[css-sanitizer@master] Set phan allow_method_param_type_widening = true

Change 592465 merged by jenkins-bot:
[css-sanitizer@master] Set phan allow_method_param_type_widening = true

This doesn't block anything, least of all making MW work in 7.4+.