Page MenuHomePhabricator
Create Task
Maniphest T314896

WikiEditor edit sampling code triggers 'PHP Deprecated: Invalid characters passed for attempted conversion, these have been ignored' on PHP7.4+
Closed, ResolvedPublic
Actions

Description

Found when trying to enable PHP 7.4 as voting in Wikimedia production branches.

The inEventSample() code just blindly passes through the $sessionId input, but EventLogging expects this to be a hex string as it immediately uses it as such, and with PHP 7.4+ this is now enforced:

https://www.php.net/manual/en/migration74.deprecated.php#migration74.deprecated.core.invalid-base-characters

Details

SubjectRepoBranchLines +/-
inEventSample: Avoid invalid character warning from sampling code, hash into hexmediawiki/extensions/WikiEditorwmf/1.39.0-wmf.23+5 -1
inEventSample: Avoid invalid character warning from sampling code, hash into hexmediawiki/extensions/WikiEditormaster+5 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT248925 Make MediaWiki release tarball compatible with PHP 8.0
 ResolvedJdforrester-WMFT300463 Make PHP 8.0 voting on MW master
 ResolvedJdforrester-WMFT313563 Bump lcobucci/jwt & league/uri-components for php8
 ResolvedJdforrester-WMFT313564 Bump onoi/message-reporter in vendor.git to 1.4.2 for php 8 support
 ResolvedJdforrester-WMFT247658 Make Wikimedia Production MediaWiki compatible with PHP 7.4
 Resolved• toanT243590 Fix WikibaseDataModel CI for php 7.4
 ResolvedLucas_Werkmeister_WMDET316923 Restore skipped test in ReferenceListTest.php
 ResolvedJoeT318918 Undeploy patch to use old PHP serialization in PHP 7.4
 ResolvedJdforrester-WMFT264168 Drop PHP 7.2 support from Wikibase master branch, once Wikimedia production is on 7.4
 ResolvedLadsgroupT270740 Drop hacky support for doctrine/dbal class renaming
 InvalidNoneT303505 [S] Remove Deprecated methods "serialize" and "unserialize" after php production upgrade to PHP 7.4
 ResolvedReedyT251043 Cleanup css-sanitizer when it only requires PHP >= 7.4
 OpenNoneT166010 The Great Namespaceization Effort
 Resolved• tstarlingT277618 var_dump() on various objects writes gigabytes of data and takes minutes to run
 ResolvedJdforrester-WMFT261872 Drop PHP 7.2 & 7.3 support from MediaWiki master branch, once Wikimedia production is on 7.4
 ResolvedPRODUCTION ERRORLegoktmT293568 PHP Notice: Undefined offset in wikimedia/remex-html when rendering rest.php error page
 Resolved• tstarlingT297667 mysqli/mysqlnd memory leak
 ResolvedJoeT271736 Migrate WMF production from PHP 7.2 to PHP 7.4
 ResolvedJdforrester-WMFT293924 Also run PHP 7.4 jobs on wmf branch patches
 ResolvedJdforrester-WMFT314896 WikiEditor edit sampling code triggers 'PHP Deprecated: Invalid characters passed for attempted conversion, these have been ignored' on PHP7.4+

Event Timeline

Jdforrester-WMF created this task.Aug 9 2022, 9:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 9 2022, 9:49 PM
gerritbot added a comment.Aug 9 2022, 9:50 PM

Change 821797 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiEditor@master] inEventSample: Avoid invalid character warning from sampling code, hash into hex

https://gerrit.wikimedia.org/r/821797

gerritbot added a project: Patch-For-Review.Aug 9 2022, 9:50 PM
Jdforrester-WMF added a parent task: T293924: Also run PHP 7.4 jobs on wmf branch patches.Aug 9 2022, 9:54 PM
Jdforrester-WMF added projects: Editing-team, Editing-Team-Request.
gerritbot added a comment.Aug 10 2022, 3:00 PM

Change 821797 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] inEventSample: Avoid invalid character warning from sampling code, hash into hex

https://gerrit.wikimedia.org/r/821797

Maintenance_bot removed a project: Patch-For-Review.Aug 10 2022, 3:30 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 10 2022, 4:00 PM
gerritbot added a comment.Aug 10 2022, 6:13 PM

Change 821745 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiEditor@wmf/1.39.0-wmf.23] inEventSample: Avoid invalid character warning from sampling code, hash into hex

https://gerrit.wikimedia.org/r/821745

gerritbot added a project: Patch-For-Review.Aug 10 2022, 6:13 PM
gerritbot added a comment.Aug 15 2022, 2:51 PM

Change 821745 abandoned by Jforrester:

[mediawiki/extensions/WikiEditor@wmf/1.39.0-wmf.23] inEventSample: Avoid invalid character warning from sampling code, hash into hex

Reason:

Eh, let's just wait for the train.

https://gerrit.wikimedia.org/r/821745

Maintenance_bot removed a project: Patch-For-Review.Aug 15 2022, 3:30 PM
Jdforrester-WMF closed this task as Resolved.Aug 29 2022, 12:13 PM

Yup, fixed.

happy5214 moved this task from Backlog to Closed on the WikiEditor (2010) board.Jul 31 2023, 9:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits