Page MenuHomePhabricator
Create Task
Maniphest T248925

Make MediaWiki compatible with PHP 8
Open, Needs TriagePublic
Actions

Description

This is a base task for PHP 8.0 support.

Details

ProjectBranchLines +/-Subject
mediawiki/coreREL1_35+1 -1Remove final modifier on private function
mediawiki/coremaster+1 -1Remove final modifier on private function
mediawiki/coremaster+11 -6FileBackend: Avoid undefined offset notices
mediawiki/coremaster+5 -3GlobalFunctions: Fix wfPercent() with negative accuracy
mediawiki/coremaster+2 -3tests: Simplify ButtonAuthenticationRequestTest
mediawiki/coremaster+22 -4UploadedFileStream: PHP 8 compatibility
mediawiki/coremaster+20 -19tests: Make static/non-static functions match
mediawiki/coremaster+1 -1uuid: explicitly cast floor() parameter to a float in GlobalIdGenerator
mediawiki/coremaster+24 -10Pbkdf2Password: Fix error handling on PHP 8
Customize query in gerrit

Related Objects
Search...

Event Timeline

MaxSem created this task.Mar 30 2020, 9:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 30 2020, 9:31 PM
gerritbot added a comment.Mar 30 2020, 9:37 PM

Change 584715 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/core@master] GlobalIdGenerator: explicitly cast parameter to floor()

https://gerrit.wikimedia.org/r/584715

gerritbot added a project: Patch-For-Review.Mar 30 2020, 9:37 PM

Change 584716 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/core@master] tests: Make some signatures match base class/trait

https://gerrit.wikimedia.org/r/584716

gerritbot added a comment.Mar 31 2020, 6:44 PM

Change 585018 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/core@master] UploadedFileStream: PHP 8 compatibility

https://gerrit.wikimedia.org/r/585018

Anomie added a project: Platform Team Workboards (External Code Reviews).Mar 31 2020, 7:34 PM
Anomie added a subscriber: Anomie.

Putting on Platform Team Workboards (External Code Reviews) for https://gerrit.wikimedia.org/r/585018.

Anomie moved this task from External Code Review Needed to External Code Review In Progress on the Platform Team Workboards (External Code Reviews) board.Mar 31 2020, 7:34 PM
gerritbot added a comment.Apr 7 2020, 4:07 PM

Change 587287 had a related patch set uploaded (by TK-999; owner: TK-999):
[mediawiki/core@master] Pbkdf2Password: Fix error handling on PHP 8

https://gerrit.wikimedia.org/r/587287

TK-999 added a subscriber: TK-999.Apr 7 2020, 4:09 PM
gerritbot added a comment.Apr 7 2020, 6:12 PM

Change 587287 merged by jenkins-bot:
[mediawiki/core@master] Pbkdf2Password: Fix error handling on PHP 8

https://gerrit.wikimedia.org/r/587287

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.28; 2020-04-14).Apr 7 2020, 7:00 PM
gerritbot added a comment.Apr 9 2020, 1:07 AM

Change 584715 merged by jenkins-bot:
[mediawiki/core@master] uuid: explicitly cast floor() parameter to a float in GlobalIdGenerator

https://gerrit.wikimedia.org/r/584715

gerritbot added a comment.Apr 28 2020, 4:12 PM

Change 592994 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/core@master] tests: Simplify ButtonAuthenticationRequestTest

https://gerrit.wikimedia.org/r/592994

gerritbot added a comment.Apr 28 2020, 9:40 PM

Change 593068 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/core@master] GlobalFunctions: Fix wfPercent() with negative accuracy

https://gerrit.wikimedia.org/r/593068

gerritbot added a comment.Apr 30 2020, 2:18 PM

Change 584716 merged by jenkins-bot:
[mediawiki/core@master] tests: Make static/non-static functions match

https://gerrit.wikimedia.org/r/584716

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.31; 2020-05-05); removed MW-1.35-notes (1.35.0-wmf.28; 2020-04-14).Apr 30 2020, 3:01 PM
gerritbot added a comment.Apr 30 2020, 5:25 PM

Change 585018 merged by jenkins-bot:
[mediawiki/core@master] UploadedFileStream: PHP 8 compatibility

https://gerrit.wikimedia.org/r/585018

gerritbot added a comment.Apr 30 2020, 5:27 PM

Change 592994 merged by jenkins-bot:
[mediawiki/core@master] tests: Simplify ButtonAuthenticationRequestTest

https://gerrit.wikimedia.org/r/592994

gerritbot added a comment.May 5 2020, 7:53 AM

Change 594410 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/core@master] FileBackend: Avoid undefined offset notices

https://gerrit.wikimedia.org/r/594410

MaxSem moved this task from Backlog to MediaWiki core on the PHP 8.0 support board.May 7 2020, 2:26 PM
gerritbot added a comment.May 8 2020, 3:45 PM

Change 593068 merged by jenkins-bot:
[mediawiki/core@master] GlobalFunctions: Fix wfPercent() with negative accuracy

https://gerrit.wikimedia.org/r/593068

gerritbot added a comment.May 8 2020, 3:46 PM

Change 594410 merged by jenkins-bot:
[mediawiki/core@master] FileBackend: Avoid undefined offset notices

https://gerrit.wikimedia.org/r/594410

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.32; 2020-05-12); removed MW-1.35-notes (1.35.0-wmf.31; 2020-05-05).May 8 2020, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 8 2020, 4:10 PM
Naike added subscribers: AMooney, Naike.Jun 5 2020, 3:27 PM

@AMooney, this task is unassigned. Should it be in the External Review Needed column?

Florian added a subscriber: Florian.Jul 11 2020, 12:30 PM
Pchelolo removed a project: Platform Team Workboards (External Code Reviews).Aug 7 2020, 7:48 PM
Akuckartz edited projects, added MediaWiki-Stakeholders-Group; removed MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), MediaWiki-General, PHP 8.0 support.Aug 9 2020, 9:30 PM
Akuckartz added projects: MediaWiki-General, PHP 8.0 support, MW-1.35-notes (1.35.0-wmf.32; 2020-05-12).Aug 9 2020, 9:38 PM
Akuckartz awarded a token.
gerritbot added a comment.Sep 6 2020, 4:19 PM

Change 625463 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Remove final modifier on private function

https://gerrit.wikimedia.org/r/625463

gerritbot added a project: Patch-For-Review.Sep 6 2020, 4:19 PM
gerritbot added a comment.Sep 6 2020, 5:05 PM

Change 625463 merged by jenkins-bot:
[mediawiki/core@master] Remove final modifier on private function

https://gerrit.wikimedia.org/r/625463

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.8; 2020-09-08).Sep 6 2020, 6:00 PM
Florian added a subtask: T264502: Uncaught ValueError: strcspn(): Argument #4 ($length) must be contained in argument #1 ($str).Oct 3 2020, 3:07 PM
Reedy closed subtask T264502: Uncaught ValueError: strcspn(): Argument #4 ($length) must be contained in argument #1 ($str) as Resolved.Oct 5 2020, 12:15 AM
gerritbot added a comment.Oct 5 2020, 12:17 AM

Change 632009 had a related patch set uploaded (by Reedy; owner: Ammarpad):
[mediawiki/core@REL1_35] Remove final modifier on private function

https://gerrit.wikimedia.org/r/632009

gerritbot added a comment.Oct 5 2020, 12:25 AM

Change 632009 merged by jenkins-bot:
[mediawiki/core@REL1_35] Remove final modifier on private function

https://gerrit.wikimedia.org/r/632009

DannyS712 added subscribers: Ammarpad, Reedy, DannyS712.EditedOct 5 2020, 12:34 AM

@Ammarpad @Reedy I'm note expert on how phan stubs are used, but https://gerrit.wikimedia.org/g/mediawiki/core/+/22febcecc591d8ad5050837c24dcaf15cbc5ebd8/.phan/internal_stubs/excimer.php includes 2 private final functions
Do those need to be removed?

ReleaseTaggerBot edited projects, added MW-1.35-notes; removed MW-1.35-notes (1.35.0-wmf.32; 2020-05-12).Oct 5 2020, 1:01 AM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:01 PM
thiemowmde added a subscriber: thiemowmde.Oct 24 2020, 10:30 AM

In case it helps, I wrote a blog post about PHP 8 focusing on breaking changes relevant for MediaWiki development: http://maettig.com/2020-09-21-prepare-for-php-8

Reedy removed a project: Patch-For-Review.Wed, Oct 28, 12:35 AM
Reedy mentioned this in T266626: Excimer PHP 8.0 support.Wed, Oct 28, 12:41 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL