Page MenuHomePhabricator
Create Task
Maniphest T248925

Make MediaWiki compatible with PHP 8
Open, Needs TriagePublic
Actions

Description

This is a base task for PHP 8.0 support.

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+4 -3objectcache: Fix non-numeric string check in HashBagOStuff for PHP 8
mediawiki/coreREL1_35+3 -2Upgrade wikimedia/less.php from 3.0.0 to 3.1.0
mediawiki/vendorREL1_35+4 K -4 KUpgrade wikimedia/less.php from 3.0.0 to 3.1.0
mediawiki/coreREL1_35+1 -1Fix CacheTime::getCacheExpiry for php8
mediawiki/coremaster+1 -1Fix CacheTime::getCacheExpiry for php8
mediawiki/coreREL1_35+4 -3objectcache: Fix non-numeric string check in HashBagOStuff for PHP 8
mediawiki/coreREL1_35+1 -1Special:Contributions reports negative namespace error on php8
mediawiki/coremaster+4 -0Set empty closures in DatabaseTest to fix php8 tests
mediawiki/coreREL1_35+4 -0Set empty closures in DatabaseTest to fix php8 tests
mediawiki/coremaster+1 -1Special:Contributions reports negative namespace error on php8
integration/configmaster+1 -0Zuul: [mediawiki/core] Add composer (not vendor) experimental PHP 8.0 job
mediawiki/coremaster+2 -1Upgrade wikimedia/less.php from 3.0.0 to 3.1.0
mediawiki/vendormaster+4 K -4 KUpgrade wikimedia/less.php from 3.0.0 to 3.1.0
mediawiki/services/parsoidREL1_35+1 -1TestRunner: Fix base_convert() call on PHP 8
mediawiki/extensions/GoogleLoginmaster+49 -34Make compatible with PHP8: can't use "match" any more
mediawiki/extensions/Translatemaster+14 -14Make compatible with PHP8: can't use "match" any more
mediawiki/extensions/Expressionsmaster+21 -20Make compatible with PHP8: can't use "match" any more
mediawiki/services/parsoidmaster+1 -1TestRunner: Fix base_convert() call on PHP 8
mediawiki/coreREL1_35+9 -9tests: Fix queryFlags parameter type in RevisionStoreDbTestBase
mediawiki/coreREL1_35+183 -0tests: Fix method signature mismatches
mediawiki/coremaster+2 -2tests: Fix method signature mismatches
mediawiki/coremaster+9 -9tests: Fix queryFlags parameter type in RevisionStoreDbTestBase
mediawiki/coreREL1_35+1 -1Remove final modifier on private function
mediawiki/coremaster+1 -1Remove final modifier on private function
mediawiki/coremaster+11 -6FileBackend: Avoid undefined offset notices
mediawiki/coremaster+5 -3GlobalFunctions: Fix wfPercent() with negative accuracy
mediawiki/coremaster+2 -3tests: Simplify ButtonAuthenticationRequestTest
mediawiki/coremaster+22 -4UploadedFileStream: PHP 8 compatibility
mediawiki/coremaster+20 -19tests: Make static/non-static functions match
mediawiki/coremaster+1 -1uuid: explicitly cast floor() parameter to a float in GlobalIdGenerator
mediawiki/coremaster+24 -10Pbkdf2Password: Fix error handling on PHP 8
Show related patches Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT248925 Make MediaWiki compatible with PHP 8
 ResolvedJdforrester-WMFT250298 Provide PHP 8 CI infrastructure and jobs
 ResolvedFlorianT264502 Uncaught ValueError: strcspn(): Argument #4 ($length) must be contained in argument #1 ($str)
 ResolvedReedyT268846 Update MediaWiki to a new wikimedia/testing-access-wrapper release
 OpenNoneT268847 PHP 8: libxml_disable_entity_loader() is deprecated
 ResolvedTK-999T268852 PHP 8: parse_url() change causes a parser test failure
 ResolvedNoneT269068 Upgrade everything to use composer/semver 3.0.0 or above
 ResolvedJdforrester-WMFT269464 Release MediaWiki CodeSniffer 34.0.0
 ResolvedAddshoreT266823 Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer
 ResolvedLucas_Werkmeister_WMDET268826 EntitySchema: Replace wikibase-codesniffer with mediawiki-codesniffer v33
ResolvedLucas_Werkmeister_WMDET268827 Wikibase: Replace wikibase-codesniffer with mediawiki-codesniffer v33
ResolvedItamarWMDET268828 WikibaseCirrusSearch: Replace wikibase-codesniffer with mediawiki-codesniffer v33
ResolvedSilvan_WMDET268829 WikibaseLexeme: Replace wikibase-codesniffer with mediawiki-codesniffer v33
ResolvedTonina_Zhelyazkova_WMDET268830 WikibaseLexemeCirrusSearch: Replace wikibase-codesniffer with mediawiki-codesniffer v33
ResolvedLucas_Werkmeister_WMDET268831 WikibaseQualityConstraints: Replace wikibase-codesniffer with mediawiki-codesniffer v33
ResolvedDaimonaT269495 Release a version of mediawiki-phan-config that is compatible with PHP 8.0
 ResolvedReedyT242751 Update monolog/monolog to 2.1.1 or later
 ResolvedReedyT271575 Test, pass, release, and upgrade all home-grown PHP libraries for MediaWiki on PHP 8.0

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a project: Patch-For-Review.Nov 26 2020, 6:04 PM
TK-999 added a subtask: T268846: Update MediaWiki to a new wikimedia/testing-access-wrapper release.Nov 26 2020, 6:10 PM
TK-999 added a subtask: T268847: PHP 8: libxml_disable_entity_loader() is deprecated.Nov 26 2020, 6:29 PM
gerritbot added a comment.Nov 26 2020, 6:41 PM

Change 643764 had a related patch set uploaded (by TK-999; owner: TK-999):
[mediawiki/core@master] tests: Fix queryFlags parameter type in RevisionStoreDbTestBase

https://gerrit.wikimedia.org/r/643764

gerritbot added a comment.Nov 26 2020, 7:38 PM

Change 643764 merged by jenkins-bot:
[mediawiki/core@master] tests: Fix queryFlags parameter type in RevisionStoreDbTestBase

https://gerrit.wikimedia.org/r/643764

Reedy added a comment.Nov 26 2020, 7:41 PM

Some of these want backporting to 1.35 as we want that to support php 8

gerritbot added a comment.Nov 26 2020, 7:47 PM

Change 643761 merged by jenkins-bot:
[mediawiki/core@master] tests: Fix method signature mismatches

https://gerrit.wikimedia.org/r/643761

TK-999 added a comment.Nov 26 2020, 7:49 PM

@Reedy Currently I'm not sure if we can even get the test suite to run on PHP 8 without upgrading PHPUnit first (there are some errors from generated mock code). I monkey-patched PHPUnit 9 over master to work around that for now on my local machine.

TK-999 added a comment.Nov 26 2020, 7:56 PM

More specifically, any PHPUnit mock/stub encountered by tests throws an error like:

1) ActorMigrationTest::testInsertRoundTrip with data set "normal" ('actormigration1', 'am1_user', 'am1_id', false)
ParseError: syntax error, unexpected token "match"

/Users/mateszabo/Wikia/mwdev/mediawiki/tests/phpunit/includes/ActorMigrationTest.php:545
/Users/mateszabo/Wikia/mwdev/mediawiki/tests/phpunit/MediaWikiIntegrationTestCase.php:437
/Users/mateszabo/Wikia/mwdev/mediawiki/maintenance/doMaintenance.php:106

on PHP 8 + MW master.

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.20; 2020-12-01); removed MW-1.36-notes (1.36.0-wmf.8; 2020-09-08).Nov 26 2020, 8:00 PM
thiemowmde added a comment.Nov 26 2020, 8:05 PM

unexpected token "match"

Yea, see http://maettig.com/2020-09-21-prepare-for-php-8. Functions named match might be one of the bigger PHP 7→8 problems we have. I started renaming some already. Here is the rest: https://codesearch.wmcloud.org/search/?q=function%20match%5Cb&files=%5C.php%24. This doesn't cover Wikia codebases, unfortunately.

TK-999 added a comment.Nov 26 2020, 8:26 PM
In T248925#6651992, @thiemowmde wrote:

unexpected token "match"

Yea, see http://maettig.com/2020-09-21-prepare-for-php-8. Functions named match might be one of the bigger PHP 7→8 problems we have. I started renaming some already. Here is the rest: https://codesearch.wmcloud.org/search/?q=function%20match%5Cb&files=%5C.php%24. This doesn't cover Wikia codebases, unfortunately.

Yup, the problem is that the problematic code is within the mock code autogenerated by PHPUnit, so I don't see how it can be avoided without going through the hassle of upgrading PHPUnit (v9 brings another slew of breaking changes)

Krinkle added a subscriber: Krinkle.EditedNov 26 2020, 8:44 PM

Relevant:

PHPUnit 9 is compatible with PHP8, but dropped PHP7.2 and older.

It looks like WordPress will be using PHPUnit 7 (or 8?) with patches for PHP8, rather than the approach we took in the past where we used multiple PHPUnit versions side-by-side with local traits to emulate the newer version on the old version.

gerritbot added a comment.Nov 26 2020, 9:18 PM

Change 643485 had a related patch set uploaded (by Reedy; owner: TK-999):
[mediawiki/core@REL1_35] tests: Fix queryFlags parameter type in RevisionStoreDbTestBase

https://gerrit.wikimedia.org/r/643485

gerritbot added a comment.Nov 26 2020, 9:19 PM

Change 643786 had a related patch set uploaded (by Reedy; owner: TK-999):
[mediawiki/core@REL1_35] tests: Fix method signature mismatches

https://gerrit.wikimedia.org/r/643786

gerritbot added a comment.Nov 26 2020, 9:21 PM

Change 643786 abandoned by Reedy:
[mediawiki/core@REL1_35] tests: Fix method signature mismatches

Reason:
Neither of these are needed. One new file, other changes not in REL1_35, added in 6eea7d7ed51c4e04ef25e42b8f2021bc4cb10932

https://gerrit.wikimedia.org/r/643786

Reedy added a comment.Nov 26 2020, 9:22 PM
In T248925#6651971, @TK-999 wrote:

@Reedy Currently I'm not sure if we can even get the test suite to run on PHP 8 without upgrading PHPUnit first (there are some errors from generated mock code). I monkey-patched PHPUnit 9 over master to work around that for now on my local machine.

I still want to pro-actively want to backport them as we're making them; if they don't cause breaking changes etc (and obviously work on PHP 7). Means we don't have to find them later, or re-make them etc

gerritbot added a comment.Nov 26 2020, 9:29 PM

Change 643485 merged by jenkins-bot:
[mediawiki/core@REL1_35] tests: Fix queryFlags parameter type in RevisionStoreDbTestBase

https://gerrit.wikimedia.org/r/643485

TK-999 added a subtask: T268852: PHP 8: parse_url() change causes a parser test failure.Nov 26 2020, 9:41 PM
Reedy closed subtask T268852: PHP 8: parse_url() change causes a parser test failure as Resolved.Nov 26 2020, 11:18 PM
gerritbot added a comment.Nov 27 2020, 12:18 AM

Change 643782 had a related patch set uploaded (by TK-999; owner: TK-999):
[mediawiki/services/parsoid@master] TestRunner: Fix base_convert() call on PHP 8

https://gerrit.wikimedia.org/r/643782

gerritbot added a comment.Nov 27 2020, 12:48 AM

Change 643791 had a related patch set uploaded (by Reedy; owner: TK-999):
[mediawiki/services/parsoid@REL1_35] TestRunner: Fix base_convert() call on PHP 8

https://gerrit.wikimedia.org/r/643791

gerritbot added a comment.Nov 27 2020, 1:04 AM

Change 643782 merged by jenkins-bot:
[mediawiki/services/parsoid@master] TestRunner: Fix base_convert() call on PHP 8

https://gerrit.wikimedia.org/r/643782

gerritbot added a comment.Nov 27 2020, 7:57 AM

Change 640555 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Translate@master] Make compatible with PHP8: can't use "match" any more

https://gerrit.wikimedia.org/r/640555

gerritbot added a comment.Nov 27 2020, 7:57 AM

Change 640554 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Expressions@master] Make compatible with PHP8: can't use "match" any more

https://gerrit.wikimedia.org/r/640554

Jdforrester-WMF closed subtask T268846: Update MediaWiki to a new wikimedia/testing-access-wrapper release as Resolved.Nov 27 2020, 11:12 PM
gerritbot added a comment.Nov 27 2020, 11:38 PM

Change 640554 merged by jenkins-bot:
[mediawiki/extensions/Expressions@master] Make compatible with PHP8: can't use "match" any more

https://gerrit.wikimedia.org/r/640554

MacFan4000 added a subscriber: MacFan4000.Nov 29 2020, 6:52 PM
gerritbot added a comment.Nov 30 2020, 7:30 AM

Change 640555 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Make compatible with PHP8: can't use "match" any more

https://gerrit.wikimedia.org/r/640555

Daimona added a subscriber: Daimona.Nov 30 2020, 8:56 PM
Krinkle removed a subscriber: Krinkle.Dec 3 2020, 3:06 AM
gerritbot added a comment.Dec 4 2020, 12:39 PM

Change 645338 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/GoogleLogin@master] Make compatible with PHP8: can't use "match" any more

https://gerrit.wikimedia.org/r/645338

JeroenDeDauw added a subscriber: JeroenDeDauw.EditedDec 4 2020, 5:33 PM

Does anyone know to which degrees MW 1.35 and master run on PHP 8.0? (I understand there is no official support)

Reedy added a comment.Dec 4 2020, 5:41 PM
In T248925#6669721, @JeroenDeDauw wrote:

Does anyone know to which degrees MW 1.35 and master run on PHP 8.0? (I understand there is no official support)

Master and REL1_35 (ie the branch, not 1.35.0) of MW core will be similar

I don't know if it's well tested, but it does seem "test" related code is probably more problematic than normal workflow.

Testing appreciated. Feel free to report bugs or submit changesets to fix issues

Jdforrester-WMF closed subtask T250298: Provide PHP 8 CI infrastructure and jobs as Resolved.Dec 4 2020, 7:35 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.Dec 6 2020, 6:06 PM

monolog/monolog 2.0.2 requires php ^7.2 -> your PHP version (8.0.0) does not satisfy that requirement

Fun.

Jdforrester-WMF added a subtask: T242751: Update monolog/monolog to 2.1.1 or later.Dec 6 2020, 6:12 PM
Reedy added a comment.Dec 6 2020, 6:15 PM
In T248925#6672023, @Jdforrester-WMF wrote:

monolog/monolog 2.0.2 requires php ^7.2 -> your PHP version (8.0.0) does not satisfy that requirement

Fun.

Heh. At least we're not on 1.25 anymore!

gerritbot added a comment.Dec 6 2020, 6:18 PM

Change 645338 merged by jenkins-bot:
[mediawiki/extensions/GoogleLogin@master] Make compatible with PHP8: can't use "match" any more

https://gerrit.wikimedia.org/r/645338

Daimona closed subtask T269495: Release a version of mediawiki-phan-config that is compatible with PHP 8.0 as Resolved.Dec 6 2020, 9:03 PM
gerritbot added a comment.Dec 11 2020, 7:42 PM

Change 648330 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/vendor@master] Upgrade wikimedia/less.php from 3.0.0 to 3.1.0

https://gerrit.wikimedia.org/r/648330

gerritbot added a comment.Dec 11 2020, 7:42 PM

Change 648331 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Upgrade wikimedia/less.php from 3.0.0 to 3.1.0

https://gerrit.wikimedia.org/r/648331

Ricordisamoa added a subscriber: Ricordisamoa.Dec 15 2020, 10:45 PM
kostajh added a subscriber: kostajh.Dec 16 2020, 6:29 PM
gerritbot added a comment.Dec 16 2020, 11:03 PM

Change 643791 merged by Legoktm:
[mediawiki/services/parsoid@REL1_35] TestRunner: Fix base_convert() call on PHP 8

https://gerrit.wikimedia.org/r/643791

gerritbot added a comment.Dec 23 2020, 12:12 AM

Change 648330 merged by jenkins-bot:
[mediawiki/vendor@master] Upgrade wikimedia/less.php from 3.0.0 to 3.1.0

https://gerrit.wikimedia.org/r/648330

gerritbot added a comment.Dec 23 2020, 12:18 AM

Change 648331 merged by Reedy:
[mediawiki/core@master] Upgrade wikimedia/less.php from 3.0.0 to 3.1.0

https://gerrit.wikimedia.org/r/648331

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.25; 2021-01-05); removed MW-1.36-notes (1.36.0-wmf.20; 2020-12-01).Dec 23 2020, 1:00 AM
JeroenDeDauw added a comment.EditedDec 23 2020, 7:18 PM
In T248925#6672023, @Jdforrester-WMF wrote:

monolog/monolog 2.0.2 requires php ^7.2 -> your PHP version (8.0.0) does not satisfy that requirement

Fun.

Exactly. Very "fun". That is my feedback so far: don't pin monolog and other dependencies, especially to something that cannot be installed with the latest PHP version. Or, at the very least, switch the pin to any more recent version than monolog 2.0.2, which all allow installation with PHP 8.

Reedy added a comment.Dec 23 2020, 7:29 PM
In T248925#6710824, @JeroenDeDauw wrote:
In T248925#6672023, @Jdforrester-WMF wrote:

monolog/monolog 2.0.2 requires php ^7.2 -> your PHP version (8.0.0) does not satisfy that requirement

Fun.

Exactly. Very "fun". That is my feedback so far: don't pin monolog and other dependencies, especially to something that cannot be installed with the latest PHP version. Or, at the very least, switch the pin to any more recent version than monolog 2.0.2, which all allow installation with PHP 8.

Doesn’t help when we have code in core that depends on classes in a 3rd party library, and we can’t easily support both versions when signatures change... so no point in letting you install it if it won’t work if you try to use it....

Jdforrester-WMF added a comment.Dec 23 2020, 7:34 PM
In T248925#6710824, @JeroenDeDauw wrote:
In T248925#6672023, @Jdforrester-WMF wrote:

monolog/monolog 2.0.2 requires php ^7.2 -> your PHP version (8.0.0) does not satisfy that requirement

Fun.

Exactly. Very "fun". That is my feedback so far: don't pin monolog and other dependencies, especially to something that cannot be installed with the latest PHP version.

Given that we've found everyone on Earth disagrees as to the exact semantics of SemVer in ways that have broken master and threatened the stability of production, including composer themselves, no.

Or, at the very least, switch the pin to any more recent version than monolog 2.0.2, which all allow installation with PHP 8.

Yes, that's the plan. :-) Unfortunately their support expanse comes at the expense of breaking changes that they don't consider breaking in their output, so we have to re-validate all the security logging etc. again.

Reedy added a comment.Dec 23 2020, 8:15 PM

Be happy were on 2.0 now too ;)

Reedy closed subtask T269068: Upgrade everything to use composer/semver 3.0.0 or above as Resolved.Dec 28 2020, 1:09 AM
alex-mashin added a subscriber: alex-mashin.Dec 30 2020, 5:54 AM
WMDE-leszek added a subscriber: WMDE-leszek.Jan 13 2021, 7:54 PM
Sam-m888 added a subscriber: Sam-m888.Jan 16 2021, 3:26 AM
Jdforrester-WMF closed subtask T242751: Update monolog/monolog to 2.1.1 or later as Resolved.Jan 17 2021, 3:40 AM
gerritbot added a comment.Jan 17 2021, 3:41 AM

Change 656593 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] Zuul: [mediawiki/core] Add composer (not vendor) experimental PHP 8.0 job

https://gerrit.wikimedia.org/r/656593

gerritbot added a comment.Jan 17 2021, 3:44 AM

Change 656593 merged by jenkins-bot:
[integration/config@master] Zuul: [mediawiki/core] Add composer (not vendor) experimental PHP 8.0 job

https://gerrit.wikimedia.org/r/656593

Stashbot added a comment.Jan 17 2021, 3:44 AM

Mentioned in SAL (#wikimedia-releng) [2021-01-17T03:44:33Z] <James_F> Zuul: [mediawiki/core] Add composer (not vendor) experimental PHP 8.0 job T248925

gerritbot added a comment.Jan 22 2021, 1:06 AM

Change 657683 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@master] Set empty closures in DatabaseTest to fix php8 tests

https://gerrit.wikimedia.org/r/657683

gerritbot added a comment.Jan 22 2021, 1:06 AM

Change 657713 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@master] Special:Contributions reports negative namespace error on php8

https://gerrit.wikimedia.org/r/657713

gerritbot added a comment.Jan 22 2021, 1:06 AM

Change 657685 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@master] Fix constructor HashBagOStuff on non-numeric strings for php8

https://gerrit.wikimedia.org/r/657685

gerritbot added a comment.Jan 22 2021, 1:24 PM

Change 657713 merged by jenkins-bot:
[mediawiki/core@master] Special:Contributions reports negative namespace error on php8

https://gerrit.wikimedia.org/r/657713

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.28; 2021-01-26); removed MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Jan 22 2021, 2:00 PM
gerritbot added a comment.Jan 31 2021, 2:57 AM

Change 660527 had a related patch set uploaded (by Reedy; owner: Umherirrender):
[mediawiki/core@REL1_35] Set empty closures in DatabaseTest to fix php8 tests

https://gerrit.wikimedia.org/r/660527

gerritbot added a comment.Jan 31 2021, 2:57 AM

Change 660527 abandoned by Reedy:
[mediawiki/core@REL1_35] Set empty closures in DatabaseTest to fix php8 tests

Reason:

https://gerrit.wikimedia.org/r/660527

gerritbot added a comment.Jan 31 2021, 2:59 AM

Change 660527 restored by Reedy:
[mediawiki/core@REL1_35] Set empty closures in DatabaseTest to fix php8 tests

https://gerrit.wikimedia.org/r/660527

gerritbot added a comment.Jan 31 2021, 3:14 AM

Change 660527 merged by jenkins-bot:
[mediawiki/core@REL1_35] Set empty closures in DatabaseTest to fix php8 tests

https://gerrit.wikimedia.org/r/660527

gerritbot added a comment.Jan 31 2021, 3:24 AM

Change 657683 merged by jenkins-bot:
[mediawiki/core@master] Set empty closures in DatabaseTest to fix php8 tests

https://gerrit.wikimedia.org/r/657683

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.29; 2021-02-02); removed MW-1.36-notes (1.36.0-wmf.28; 2021-01-26).Jan 31 2021, 4:00 AM
gerritbot added a comment.Jan 31 2021, 9:17 AM

Change 660530 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@REL1_35] Special:Contributions reports negative namespace error on php8

https://gerrit.wikimedia.org/r/660530

gerritbot added a comment.Jan 31 2021, 1:46 PM

Change 660530 merged by jenkins-bot:
[mediawiki/core@REL1_35] Special:Contributions reports negative namespace error on php8

https://gerrit.wikimedia.org/r/660530

gerritbot added a comment.Feb 1 2021, 7:43 PM

Change 657685 merged by jenkins-bot:
[mediawiki/core@master] objectcache: Fix non-numeric string check in HashBagOStuff for PHP 8

https://gerrit.wikimedia.org/r/657685

gerritbot added a comment.Feb 1 2021, 7:46 PM

Change 660929 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@REL1_35] objectcache: Fix non-numeric string check in HashBagOStuff for PHP 8

https://gerrit.wikimedia.org/r/660929

gerritbot added a comment.Feb 1 2021, 8:05 PM

Change 660626 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@master] Fix CacheTime::getCacheExpiry for php8

https://gerrit.wikimedia.org/r/660626

gerritbot added a comment.Feb 3 2021, 1:35 AM

Change 660929 merged by jenkins-bot:
[mediawiki/core@REL1_35] objectcache: Fix non-numeric string check in HashBagOStuff for PHP 8

https://gerrit.wikimedia.org/r/660929

gerritbot added a comment.Feb 4 2021, 10:39 PM

Change 660626 merged by jenkins-bot:
[mediawiki/core@master] Fix CacheTime::getCacheExpiry for php8

https://gerrit.wikimedia.org/r/660626

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.30; 2021-02-09); removed MW-1.36-notes (1.36.0-wmf.29; 2021-02-02).Feb 4 2021, 11:00 PM
gerritbot added a comment.Feb 4 2021, 11:16 PM

Change 661654 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@REL1_35] Fix CacheTime::getCacheExpiry for php8

https://gerrit.wikimedia.org/r/661654

gerritbot added a comment.Feb 5 2021, 2:22 AM

Change 661654 merged by jenkins-bot:
[mediawiki/core@REL1_35] Fix CacheTime::getCacheExpiry for php8

https://gerrit.wikimedia.org/r/661654

Umherirrender added a subscriber: Umherirrender.Feb 7 2021, 12:14 AM

Squashed a patch set together, which now passed for the composer job on master: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/662089

https://integration.wikimedia.org/ci/job/mediawiki-quibble-composer-mysql-php80-docker/16/console

That means: Closing the sub tasks should make it work for mediawiki/core as other failing tests are now passed

elasticsearch/elasticsearch needs update to also work on the vendor job (T271777)

gerritbot added a comment.Feb 7 2021, 12:48 AM

Change 662100 had a related patch set uploaded (by Reedy; owner: Jforrester):
[mediawiki/vendor@REL1_35] Upgrade wikimedia/less.php from 3.0.0 to 3.1.0

https://gerrit.wikimedia.org/r/662100

gerritbot added a comment.Feb 7 2021, 12:49 AM

Change 662055 had a related patch set uploaded (by Reedy; owner: Jforrester):
[mediawiki/core@REL1_35] Upgrade wikimedia/less.php from 3.0.0 to 3.1.0

https://gerrit.wikimedia.org/r/662055

gerritbot added a comment.Feb 7 2021, 1:02 AM

Change 662100 merged by Reedy:
[mediawiki/vendor@REL1_35] Upgrade wikimedia/less.php from 3.0.0 to 3.1.0

https://gerrit.wikimedia.org/r/662100

gerritbot added a comment.Feb 7 2021, 1:16 AM

Change 662055 merged by jenkins-bot:
[mediawiki/core@REL1_35] Upgrade wikimedia/less.php from 3.0.0 to 3.1.0

https://gerrit.wikimedia.org/r/662055

Umherirrender removed a subscriber: Umherirrender.Feb 27 2021, 9:39 PM
ReaperDawn added a subscriber: ReaperDawn.Mar 14 2021, 3:35 PM
Jdforrester-WMF closed subtask T271575: Test, pass, release, and upgrade all home-grown PHP libraries for MediaWiki on PHP 8.0 as Resolved.Mar 22 2021, 5:47 PM
Ltrlg added a subscriber: Ltrlg.Apr 14 2021, 9:03 AM
R4356th added a subscriber: R4356th.Tue, Apr 27, 4:09 PM
MPThLee added a subscriber: MPThLee.Mon, May 3, 6:50 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL