Page MenuHomePhabricator

MediaWiki session management does not work on split PHP 7.4 and < PHP 7.4 cluster
Closed, ResolvedPublic

Description

When we upgraded to PHP 7.4 on our first traffic serving server, users were reporting they were being logged out.

This is because http://bugs.php.net/78929 is not backwards compatible.

Can we implement something to make it work?

Event Timeline

RhinosF1 moved this task from Radar to Miraheze-Linked on the User-RhinosF1 board.
RhinosF1 moved this task from Backlog to MediaWiki core on the PHP 7.3 support board.
RhinosF1 moved this task from Backlog to MediaWiki core on the PHP 7.4 support board.
RhinosF1 added subscribers: Majavah, Reception123, Paladox.
Reedy renamed this task from MediaWiki session management does not work on split php7.3 & php7.4 cluster to MediaWiki session management does not work on split PHP 7.4 and < PHP 7.4 cluster.Sep 22 2021, 2:28 PM

For clarity, is it all users? Or just users with spaces in their usernames?

And what PHP version are you going from (full version) and to (full version)?

For clarity, is it all users? Or just users with spaces in their usernames?

And what PHP version are you going from (full version) and to (full version)?

Debian standard (7.3.29-1~deb10u1 -> 7.4.21) and yes the issue only affects users (so far) with spaces. Not sure if any other characters changed (non-english?)

Change 725501 had a related patch set uploaded (by PleaseStand; author: PleaseStand):

[mediawiki/core@master] Always encode spaces in cookie values as \"%20\"

https://gerrit.wikimedia.org/r/725501

Change 725501 merged by jenkins-bot:

[mediawiki/core@master] Always encode spaces in cookie values as \"%20\"

https://gerrit.wikimedia.org/r/725501

Change 731233 had a related patch set uploaded (by Reedy; author: PleaseStand):

[mediawiki/core@REL1_37] Always encode spaces in cookie values as \"%20\"

https://gerrit.wikimedia.org/r/731233

Change 731234 had a related patch set uploaded (by Reedy; author: PleaseStand):

[mediawiki/core@REL1_36] Always encode spaces in cookie values as \"%20\"

https://gerrit.wikimedia.org/r/731234

Change 731235 had a related patch set uploaded (by Reedy; author: PleaseStand):

[mediawiki/core@REL1_35] Always encode spaces in cookie values as \"%20\"

https://gerrit.wikimedia.org/r/731235

Change 731233 merged by jenkins-bot:

[mediawiki/core@REL1_37] Always encode spaces in cookie values as \"%20\"

https://gerrit.wikimedia.org/r/731233

Change 731235 merged by jenkins-bot:

[mediawiki/core@REL1_35] Always encode spaces in cookie values as \"%20\"

https://gerrit.wikimedia.org/r/731235

Change 731234 merged by jenkins-bot:

[mediawiki/core@REL1_36] Always encode spaces in cookie values as \"%20\"

https://gerrit.wikimedia.org/r/731234

Reedy assigned this task to PleaseStand.

Patches have been deployed by me but I still couldn't log in on test3.miraheze.org

Patches have been deployed by me but I still couldn't log in on test3.miraheze.org

Noting that means nothing to anyone here.

Any bad cookies will stay bad, those aren't going to be fixed.. They'll have to log out and back in again at least...

Patches have been deployed by me but I still couldn't log in on test3.miraheze.org

Noting that means nothing to anyone here.

Any bad cookies will stay bad, those aren't going to be fixed.. They'll have to log out and back in again at least...

Tried in incognito so none were there.