Page MenuHomePhabricator

Bump lcobucci/jwt & league/uri-components for php8
Closed, ResolvedPublic

Description

These are both deps of Extension:OAuth

preventing tests from running in php 8.

Related Objects

StatusSubtypeAssignedTask
ResolvedNone
ResolvedJdforrester-WMF
ResolvedJdforrester-WMF
ResolvedJdforrester-WMF
ResolvedJoe
ResolvedDzahn
Resolvedhashar
ResolvedJdforrester-WMF
ResolvedLadsgroup
ResolvedMoritzMuehlenhoff
Resolvedjijiki
ResolvedMoritzMuehlenhoff
ResolvedTrizek-WMF
ResolvedDzahn
Resolved Gilles
ResolvedDzahn
ResolvedRequestPapaul
Resolvedjijiki
DeclinedNone
ResolvedDzahn
ResolvedDzahn
ResolvedPapaul
ResolvedCmjohnson
ResolvedRequestCmjohnson
ResolvedRequestPapaul
ResolvedAndrew
ResolvedArielGlenn
ResolvedDzahn
ResolvedLegoktm
ResolvedPapaul
ResolvedDzahn
Declined Gilles
ResolvedVolans
ResolvedDzahn
ResolvedLegoktm
ResolvedPleaseStand
ResolvedJoe
Resolvedtstarling
ResolvedArielGlenn
ResolvedJoe
Resolvedtstarling
ResolvedJdforrester-WMF
ResolvedJdforrester-WMF
ResolvedLegoktm
ResolvedJdforrester-WMF
ResolvedDaimona
ResolvedDaimona
ResolvedJdforrester-WMF
ResolvedJoe
ResolvedJMeybohm
ResolvedJoe
ResolvedJoe
ResolvedJoe
ResolvedJoe
ResolvedKrinkle
ResolvedJoe
ResolvedClement_Goubert
ResolvedClement_Goubert
ResolvedClement_Goubert
ResolvedMainframe98
ResolvedJoe
ResolvedZabe

Event Timeline

For lcobucci/jwt this is probably easier done when we've bumped to PHP 7.4 in WMF prod (and therefore MW master).

3.4.6 supports php: ^5.6 || ^7.0
4.0.4 supports php: ^7.4 || ^8.0
4.1.5 supports php: ^7.4 || ^8.0

league/uri-components is unfortunately rather similar.

That is, unless we can depend on multiple versions of these libraries fine (in this case, can the dependancies we depend on, depend on multiple versions of those...)

league/oauth2-server has "lcobucci/jwt": "^3.4.6 || ^4.0.4",

league/uri-components is only in suggest of league/uri-component... So maybe we could just drop it

Change 836847 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/vendor@master] Update lcobucci/jwt and league/uri-components for PHP 8.0 compat

https://gerrit.wikimedia.org/r/836847

Change 836847 merged by jenkins-bot:

[mediawiki/vendor@master] Raise lcobucci/jwt to v4.1.5 and league/uri-components to v2.4.1 for PHP 8.0 compat

https://gerrit.wikimedia.org/r/836847