Page MenuHomePhabricator
Create Task
Maniphest T293449

Package php 7.4 for wikimedia production
Closed, ResolvedPublic
Actions

Description

We need to package php 7.4 and all the extensions we use for production (including luasandbox and wikidiff2) and upload it to reprepro, to its own component I guess for php 7.4.

It would be great if we managed to build the packages so that php 7.2 and php 7.4 can coexist on the same application server, like debian tries to do.

  • php7.4
  • dh-php (just for build dependencies)
  • php-defaults (just for build dependencies)
  • php-apcu
  • php-excimer
  • php-geoip
  • php-igbinary
  • php-luasandbox
  • php-memcached
  • php-msgpack
  • php-redis
  • php-tideways
  • php-wikidiff2
  • php-wmerrors
  • php-xdebug

Skipping:

  • php-mongodb was previously packaged for 7.2, but we don't need it anymore.
  • php-mailparse is only packaged for Phabricator
  • php-apcu-bc provides compat apc_* functions

Details

SubjectRepoBranchLines +/-
package_builder: Add hook for building PHP 7.4 packagesoperations/puppetproduction+22 -2
aptrepo: Add component/php74operations/puppetproduction+2 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT248925 Make MediaWiki release tarball compatible with PHP 8.0
 ResolvedJdforrester-WMFT300463 Make PHP 8.0 voting on MW master
 ResolvedJdforrester-WMFT313563 Bump lcobucci/jwt & league/uri-components for php8
 ResolvedJdforrester-WMFT313564 Bump onoi/message-reporter in vendor.git to 1.4.2 for php 8 support
 ResolvedJdforrester-WMFT247658 Make Wikimedia Production MediaWiki compatible with PHP 7.4
 Resolved• toanT243590 Fix WikibaseDataModel CI for php 7.4
 ResolvedLucas_Werkmeister_WMDET316923 Restore skipped test in ReferenceListTest.php
 ResolvedJoeT318918 Undeploy patch to use old PHP serialization in PHP 7.4
 ResolvedJdforrester-WMFT264168 Drop PHP 7.2 support from Wikibase master branch, once Wikimedia production is on 7.4
 ResolvedLadsgroupT270740 Drop hacky support for doctrine/dbal class renaming
 InvalidNoneT303505 [S] Remove Deprecated methods "serialize" and "unserialize" after php production upgrade to PHP 7.4
 ResolvedReedyT251043 Cleanup css-sanitizer when it only requires PHP >= 7.4
 OpenNoneT166010 The Great Namespaceization Effort
 ResolvedtstarlingT277618 var_dump() on various objects writes gigabytes of data and takes minutes to run
 ResolvedJdforrester-WMFT261872 Drop PHP 7.2 & 7.3 support from MediaWiki master branch, once Wikimedia production is on 7.4
 ResolvedPRODUCTION ERRORLegoktmT293568 PHP Notice: Undefined offset in wikimedia/remex-html when rendering rest.php error page
 ResolvedtstarlingT297667 mysqli/mysqlnd memory leak
 ResolvedJoeT271736 Migrate WMF production from PHP 7.2 to PHP 7.4
 ResolvedJdforrester-WMFT293924 Also run PHP 7.4 jobs on wmf branch patches
 ResolvedJdforrester-WMFT293851 Re-build all CI images of PHP 7.4 from sury's package to Wikimedia's one, to assure us that it will work
 ResolvedLegoktmT293449 Package php 7.4 for wikimedia production
 ResolvedJdforrester-WMFT295285 Upgrade primary branch of all Wikimedia-deployed repos to a version of mediawiki-tools-phan including T270553
 ResolvedDaimonaT295286 Release mediawiki-tools-phan 0.11.1
 ResolvedDaimonaT270553 Should mediawiki/mediawiki-phan-config ship a target php version to support running with newer php on the developer side?
 ResolvedJdforrester-WMFT314896 WikiEditor edit sampling code triggers 'PHP Deprecated: Invalid characters passed for attempted conversion, these have been ignored' on PHP7.4+

Event Timeline

Joe triaged this task as Medium priority.Oct 15 2021, 9:08 AM
Joe created this task.
Reedy awarded a token.Oct 15 2021, 9:21 AM
Ladsgroup awarded a token.Oct 15 2021, 12:08 PM
gerritbot added a comment.Oct 19 2021, 10:18 PM

Change 732096 had a related patch set uploaded (by Legoktm; author: Legoktm):

[operations/puppet@production] aptrepo: Add component/php74

https://gerrit.wikimedia.org/r/732096

gerritbot added a project: Patch-For-Review.Oct 19 2021, 10:18 PM

Change 732097 had a related patch set uploaded (by Legoktm; author: Legoktm):

[operations/puppet@production] package_builder: Add hook for building PHP 7.4 packages

https://gerrit.wikimedia.org/r/732097

gerritbot added a comment.Oct 19 2021, 10:41 PM

Change 732096 merged by Legoktm:

[operations/puppet@production] aptrepo: Add component/php74

https://gerrit.wikimedia.org/r/732096

Jdforrester-WMF added a parent task: T293851: Re-build all CI images of PHP 7.4 from sury's package to Wikimedia's one, to assure us that it will work.Oct 20 2021, 2:38 AM
gerritbot added a comment.Oct 20 2021, 4:49 PM

Change 732097 merged by Legoktm:

[operations/puppet@production] package_builder: Add hook for building PHP 7.4 packages

https://gerrit.wikimedia.org/r/732097

Legoktm claimed this task.Oct 20 2021, 5:09 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 20 2021, 5:11 PM
Legoktm updated the task description. (Show Details)Oct 20 2021, 5:12 PM
Reedy added a comment.Oct 20 2021, 6:24 PM

Are we still installing php-mongodb? I can't see it obviously in puppet... If it is/was still in use, I'm guessing it was potentially xhgui stuff from Performance-Team.

php-tidy probably can be answered by the Parsing people, but I don't think we're still installing it (at least, explicitly) either based on puppet

Dzahn added a comment.Oct 20 2021, 6:27 PM
In T293449#7445553, @Reedy wrote:

Are we still installing php-mongodb? I can't see it obviously in puppet... If it is/was still in use, I'm guessing it was potentially xhgui stuff from Performance-Team.

No, not anymore. Removed in https://gerrit.wikimedia.org/r/c/operations/puppet/+/620729 https://gerrit.wikimedia.org/r/c/operations/puppet/+/654923

https://debmonitor.wikimedia.org/search?q=php-mongodb

Dzahn added a comment.Oct 20 2021, 6:31 PM
In T293449#7445553, @Reedy wrote:

php-tidy probably can be answered by the Parsing people, but I don't think we're still installing it (at least, explicitly) either based on puppet

T216490 , https://gerrit.wikimedia.org/r/c/mediawiki/vagrant/+/491998/

Legoktm added a comment.Oct 20 2021, 6:31 PM

I copied the list out of what is currently packaged in the php72 component: https://apt-browser.toolforge.org/buster-wikimedia/component/php72/

In T293449#7445553, @Reedy wrote:

Are we still installing php-mongodb? I can't see it obviously in puppet... If it is/was still in use, I'm guessing it was potentially xhgui stuff from Performance-Team.

No, looks like it was removed in T180761 / rOPUPabc9e7d757c0: mediawiki: remove mongodb PHP extension from appservers. debmonitor finds nothing as well.

php-tidy probably can be answered by the Parsing people, but I don't think we're still installing it (at least, explicitly) either based on puppet

It's installed in a bunch of CI images:

Screenshot 2021-10-20 at 11-29-41 php7 2-tidy - DebMonitor.png (1×1 px, 291 KB)

Also...I misread, tidy is part of the main PHP package, so it's going to be built regardless, will remove it from the list.

Legoktm updated the task description. (Show Details)Oct 20 2021, 6:32 PM
Stashbot added a comment.Oct 20 2021, 8:25 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-20T20:25:52Z] <legoktm> uploaded php7.4 on buster to apt.wm.o (T293449)

Legoktm updated the task description. (Show Details)Oct 20 2021, 8:32 PM
Legoktm added a comment.Oct 20 2021, 10:29 PM

It would be great if we managed to build the packages so that php 7.2 and php 7.4 can coexist on the same application server, like debian tries to do.

For PHP itself and the core extensions, this is taken care of. For out of tree extensions, this is trickier. The way Ondřej does it is having php7.2 and php7.4 in the same component, and each php-foo extension contains both the 7.2 and 7.4 .so and .ini files. The downside of this is that the php7.2 packages are now partially dependent upon 7.4.

The other idea I had is to rename the binary packages to php7.4-foo. This will require patching dh-php since it doesn't expect that naming scheme but that seems rather trivial. I intend to pursue this strategy until I hit something that makes it impractical.

Legoktm updated the task description. (Show Details)Oct 20 2021, 10:59 PM
Legoktm updated the task description. (Show Details)Oct 20 2021, 11:43 PM
Legoktm updated the task description. (Show Details)Oct 20 2021, 11:56 PM
Legoktm updated the task description. (Show Details)Oct 21 2021, 1:16 AM
Legoktm closed this task as Resolved.Oct 21 2021, 1:31 AM

All packages listed have been uploaded, I ran core's parser tests and PHPUnit tests against the new PHP 7.4 packages and all passed. Note that for everything, you need to explicitly install php7.4-{name}. Installing php-{name} might (it depends) get you the wrong thing.

Dzahn awarded a token.Oct 21 2021, 11:53 PM
Legoktm added a comment.Oct 25 2021, 8:21 PM

We needed ast and imagick for CI, so I've uploaded php7.4- versions of those too.

Legoktm added a comment.Nov 12 2021, 8:07 PM

The tricks I used to build these differently named PHP 7.4 packages is now documented at https://wikitech.wikimedia.org/wiki/PHP_packaging

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits