Page MenuHomePhabricator

Run phan jobs for MediaWiki core on master + WMF branches using PHP 7.4, not just 7.2
Closed, ResolvedPublic

Description

This currently doesn't pass, though only trivially.

00:02:19.395 
00:02:19.395 includes/libs/rdbms/dbal/MWMySQLPlatform.php:8 PhanCommentAbstractOnInheritedMethod Class \Wikimedia\Rdbms\MWMySQLPlatform inherits a method \Doctrine\DBAL\Platforms\AbstractPlatform::createReservedKeywordsList declared at vendor/doctrine/dbal/src/Platforms/AbstractPlatform.php:3521 marked as @abstract in phpdoc but does not override it
00:02:19.395 includes/libs/rdbms/dbal/MWMySQLPlatformCompat.php:15 PhanCommentAbstractOnInheritedMethod Class \Wikimedia\Rdbms\MWMySQLPlatformCompat inherits a method \Doctrine\DBAL\Platforms\AbstractPlatform::createReservedKeywordsList declared at vendor/doctrine/dbal/src/Platforms/AbstractPlatform.php:3521 marked as @abstract in phpdoc but does not override it
00:02:19.395 includes/libs/rdbms/dbal/MWMySQLPlatformCompat.php:21 PhanCommentAbstractOnInheritedMethod Class \Wikimedia\Rdbms\MWMySQLPlatformCompat,1 inherits a method \Doctrine\DBAL\Platforms\AbstractPlatform::createReservedKeywordsList declared at vendor/doctrine/dbal/src/Platforms/AbstractPlatform.php:3521 marked as @abstract in phpdoc but does not override it
00:02:19.395 includes/libs/rdbms/dbal/MWPostgreSqlPlatform.php:10 PhanCommentAbstractOnInheritedMethod Class \Wikimedia\Rdbms\MWPostgreSqlPlatform inherits a method \Doctrine\DBAL\Platforms\AbstractPlatform::createReservedKeywordsList declared at vendor/doctrine/dbal/src/Platforms/AbstractPlatform.php:3521 marked as @abstract in phpdoc but does not override it
00:02:19.395 includes/libs/rdbms/dbal/MWPostgreSqlPlatformCompat.php:10 PhanCommentAbstractOnInheritedMethod Class \Wikimedia\Rdbms\MWPostgreSqlPlatformCompat inherits a method \Doctrine\DBAL\Platforms\AbstractPlatform::createReservedKeywordsList declared at vendor/doctrine/dbal/src/Platforms/AbstractPlatform.php:3521 marked as @abstract in phpdoc but does not override it
00:02:19.395 includes/libs/rdbms/dbal/MWPostgreSqlPlatformCompat.php:16 PhanUndeclaredExtendedClass Class extends undeclared class \Doctrine\DBAL\Platforms\PostgreSqlPlatform

Bah, this is the DBAL 2.x/3.x issue. :-(

Event Timeline

Change 827489 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: [mediawiki/core] Don't run phan on PHP 7.4, it doesn't pass

https://gerrit.wikimedia.org/r/827489

Change 827489 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/core] Don't run phan on PHP 7.4, it doesn't pass

https://gerrit.wikimedia.org/r/827489

Mentioned in SAL (#wikimedia-releng) [2022-08-29T12:34:08Z] <James_F> Zuul: [mediawiki/core] Don't run phan on PHP 7.4, it doesn't pass; for T316518

Change 827505 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Fix PostgreSQLPlatform class name

https://gerrit.wikimedia.org/r/827505

Change 830230 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Suppress php 7.4 phan false positive

https://gerrit.wikimedia.org/r/830230

Change 830221 had a related patch set uploaded (by Zabe; author: Zabe):

[integration/config@master] Zuul: [mediawiki/core] run phan on PHP 7.4

https://gerrit.wikimedia.org/r/830221

Change 827505 abandoned by Zabe:

[mediawiki/core@master] Fix PostgreSQLPlatform class name

Reason:

https://gerrit.wikimedia.org/r/827505

Change 830230 merged by jenkins-bot:

[mediawiki/core@master] Suppress php 7.4 phan false positive

https://gerrit.wikimedia.org/r/830230

Change 830221 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/core] run phan on PHP 7.4

https://gerrit.wikimedia.org/r/830221

Mentioned in SAL (#wikimedia-releng) [2022-09-19T15:36:45Z] <James_F> Zuul: [mediawiki/core] run phan on PHP 7.4 for T316518

Jdforrester-WMF assigned this task to Zabe.