Page MenuHomePhabricator

Flow is incompatible with Elastica - Remove ElasticSearch integration / Flow search
Closed, ResolvedPublic

Description

With the upgrade to CirrusSearch/Elastica for ElasticSearch 7.10, a few Flow codepaths are now referencing invalid Elastica libraries. This hasn't blown up in production because apparently Flow search was not deployed (or was undeployed?), see T76823: Basic search on Flow board (tracking) and T62493: StructuredDiscussions posts are not indexed in builtin search among others.

Some options:

  1. Remove the undeployed code
  2. Adapt the undeployed code to the new version of Elastica
  3. Rewrite the Phan stubs to pretend that the old Elastica libraries exist

I'm in favor of option 1, given the status of Flow.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I think we should just drop all the never(-deployed) Flow search code rather than try to re-write.

I think we should just drop all the never(-deployed) Flow search code rather than try to re-write.

Yep, making a patch for that.

Change 831242 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/Flow@master] [WIP] Remove ElasticSearch integration

https://gerrit.wikimedia.org/r/831242

Change 831242 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Remove ElasticSearch integration

https://gerrit.wikimedia.org/r/831242

Resolved for now through removal of the code. If the feature is needed in future, that patch can be reverted and improved upon.

Aklapper renamed this task from Flow is incompatible with Elastica to Flow is incompatible with Elastica - Remove ElasticSearch integration / Flow search.Sep 12 2022, 9:26 AM