Page MenuHomePhabricator
Create Task
Maniphest T268831

WikibaseQualityConstraints: Replace wikibase-codesniffer with mediawiki-codesniffer v33
Closed, ResolvedPublic
Actions

Description

Patch-For-Review:

Details

SubjectRepoBranchLines +/-
Remove redundant phpcs rulesmediawiki/extensions/WikibaseQualityConstraintsmaster+0 -6
Remove comments about phpcs metricsmediawiki/extensions/WikibaseQualityConstraintsmaster+0 -4
Remove unused phpcs exclusionmediawiki/extensions/WikibaseQualityConstraintsmaster+0 -4
Replace wikibase-codesniffer with mediawiki-codesniffermediawiki/extensions/WikibaseQualityConstraintsmaster+109 -13
Customize query in gerrit

Related Objects
Search...

Event Timeline

ItamarWMDE created this task.Nov 26 2020, 1:54 PM
ItamarWMDE mentioned this in T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer.
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Nov 26 2020, 2:15 PM
Lucas_Werkmeister_WMDE claimed this task.Nov 30 2020, 5:19 PM
Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Nov 30 2020, 6:43 PM

Change 644306 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Replace wikibase-codesniffer with mediawiki-codesniffer

https://gerrit.wikimedia.org/r/644306

gerritbot added a project: Patch-For-Review.Nov 30 2020, 6:43 PM

Change 644307 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove unused phpcs exclusion

https://gerrit.wikimedia.org/r/644307

gerritbot added a comment.Nov 30 2020, 6:43 PM

Change 644308 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove redundant phpcs rules

https://gerrit.wikimedia.org/r/644308

gerritbot added a comment.Nov 30 2020, 6:43 PM

Change 644309 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove comments about phpcs metrics

https://gerrit.wikimedia.org/r/644309

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Nov 30 2020, 6:44 PM
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Dec 1 2020, 2:58 PM

Change 644306 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Replace wikibase-codesniffer with mediawiki-codesniffer

https://gerrit.wikimedia.org/r/644306

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.21; 2020-12-08).Dec 1 2020, 3:00 PM
gerritbot added a comment.Dec 1 2020, 4:12 PM

Change 644307 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove unused phpcs exclusion

https://gerrit.wikimedia.org/r/644307

gerritbot added a comment.Dec 1 2020, 4:12 PM

Change 644308 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove redundant phpcs rules

https://gerrit.wikimedia.org/r/644308

gerritbot added a comment.Dec 1 2020, 4:12 PM

Change 644309 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove comments about phpcs metrics

https://gerrit.wikimedia.org/r/644309

Lucas_Werkmeister_WMDE closed this task as Resolved.Dec 1 2020, 4:41 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Maintenance_bot removed a project: Patch-For-Review.Dec 1 2020, 5:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL