Page MenuHomePhabricator
Create Task
Maniphest T268827

Wikibase: Replace wikibase-codesniffer with mediawiki-codesniffer v33
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Enable MediaWiki.Commenting.PropertyDocumentationmediawiki/extensions/Wikibasemaster+439 -337
Remove or move comments in .phpcs.xmlmediawiki/extensions/Wikibasemaster+2 -15
Enable MediaWiki.Usage.ExtendClassUsage.FunctionVarUsagemediawiki/extensions/Wikibasemaster+5 -4
Enable MediaWiki.Classes.FullQualifiedClassNamemediawiki/extensions/Wikibasemaster+17 -16
Enable Generic.ControlStructures.DisallowYodaConditionsmediawiki/extensions/Wikibasemaster+4 -7
Enable MediaWiki.Usage.ForbiddenFunctions.is_resourcemediawiki/extensions/Wikibasemaster+2 -3
Remove unused phpcs exclusionmediawiki/extensions/Wikibasemaster+0 -4
Remove redundant phpcs rulesmediawiki/extensions/Wikibasemaster+0 -6
Replace wikibase-codesniffer with mediawiki-codesniffermediawiki/extensions/Wikibasemaster+156 -18
Customize query in gerrit

Related Objects
Search...

Event Timeline

ItamarWMDE created this task.Nov 26 2020, 1:54 PM
ItamarWMDE mentioned this in T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer.
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Nov 26 2020, 2:15 PM
Lucas_Werkmeister_WMDE claimed this task.Dec 1 2020, 5:00 PM
Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Dec 1 2020, 6:21 PM

Change 644579 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Replace wikibase-codesniffer with mediawiki-codesniffer

https://gerrit.wikimedia.org/r/644579

gerritbot added a project: Patch-For-Review.Dec 1 2020, 6:21 PM

Change 644580 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove unused phpcs exclusion

https://gerrit.wikimedia.org/r/644580

gerritbot added a comment.Dec 1 2020, 6:21 PM

Change 644581 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove redundant phpcs rules

https://gerrit.wikimedia.org/r/644581

gerritbot added a comment.Dec 1 2020, 6:21 PM

Change 644582 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Enable MediaWiki.Commenting.PropertyDocumentation

https://gerrit.wikimedia.org/r/644582

gerritbot added a comment.Dec 1 2020, 6:21 PM

Change 644583 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove or move comments in .phpcs.xml

https://gerrit.wikimedia.org/r/644583

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 1 2020, 6:21 PM
gerritbot added a comment.Dec 2 2020, 2:39 PM

Change 644836 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Enable Generic.ControlStructures.DisallowYodaConditions

https://gerrit.wikimedia.org/r/644836

gerritbot added a comment.Dec 2 2020, 2:39 PM

Change 644837 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Enable MediaWiki.Usage.ForbiddenFunctions.is_resource

https://gerrit.wikimedia.org/r/644837

gerritbot added a comment.Dec 2 2020, 2:39 PM

Change 644838 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Enable MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage

https://gerrit.wikimedia.org/r/644838

gerritbot added a comment.Dec 2 2020, 5:52 PM

Change 644880 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Enable MediaWiki.Classes.FullQualifiedClassName

https://gerrit.wikimedia.org/r/644880

gerritbot added a comment.Dec 4 2020, 4:34 PM

Change 644579 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Replace wikibase-codesniffer with mediawiki-codesniffer

https://gerrit.wikimedia.org/r/644579

gerritbot added a comment.Dec 4 2020, 4:36 PM

Change 644580 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove unused phpcs exclusion

https://gerrit.wikimedia.org/r/644580

gerritbot added a comment.Dec 4 2020, 4:37 PM

Change 644581 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove redundant phpcs rules

https://gerrit.wikimedia.org/r/644581

gerritbot added a comment.Dec 4 2020, 4:37 PM

Change 644836 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Enable Generic.ControlStructures.DisallowYodaConditions

https://gerrit.wikimedia.org/r/644836

gerritbot added a comment.Dec 4 2020, 4:37 PM

Change 644837 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Enable MediaWiki.Usage.ForbiddenFunctions.is_resource

https://gerrit.wikimedia.org/r/644837

gerritbot added a comment.Dec 4 2020, 4:41 PM

Change 644838 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Enable MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage

https://gerrit.wikimedia.org/r/644838

gerritbot added a comment.Dec 4 2020, 4:41 PM

Change 644880 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Enable MediaWiki.Classes.FullQualifiedClassName

https://gerrit.wikimedia.org/r/644880

gerritbot added a comment.Dec 4 2020, 4:45 PM

Change 644583 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove or move comments in .phpcs.xml

https://gerrit.wikimedia.org/r/644583

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.21; 2020-12-08).Dec 4 2020, 5:00 PM
gerritbot added a comment.Dec 4 2020, 6:25 PM

Change 644582 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Enable MediaWiki.Commenting.PropertyDocumentation

https://gerrit.wikimedia.org/r/644582

Lucas_Werkmeister_WMDE closed this task as Resolved.Dec 7 2020, 11:09 AM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits