Page MenuHomePhabricator

Ha78na (Ha78na)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Feb 5 2019, 9:14 PM (35 w, 6 d)
Availability
Available
LDAP User
Ha78na
MediaWiki User
Unknown

Recent Activity

May 2 2019

Ha78na added a comment to T219500: Unit Test: Add tests that ensures cancel/publish buttons are hidden and shown in proper modes.

The depicts work was covered in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseMediaInfo/+/504225/ the captions work is not complete.

May 2 2019, 7:53 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia
Ha78na updated the task description for T219500: Unit Test: Add tests that ensures cancel/publish buttons are hidden and shown in proper modes.
May 2 2019, 7:49 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia

Apr 29 2019

Ha78na reassigned T221676: [SDOC] There is no link to Wikidata item in depicts: when there is no label in the currently used language from Ha78na to matthiasmullie.
Apr 29 2019, 3:12 PM · Patch-For-Review, Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia
Ha78na updated subscribers of T221676: [SDOC] There is no link to Wikidata item in depicts: when there is no label in the currently used language.

Assigning to @matthiasmullie since he wrote the patch to wb we are waiting on.

Apr 29 2019, 3:12 PM · Patch-For-Review, Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia
Ha78na moved T221676: [SDOC] There is no link to Wikidata item in depicts: when there is no label in the currently used language from Code Review to Blocked on the Structured-Data-Team-Current-Work board.
Apr 29 2019, 3:11 PM · Patch-For-Review, Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia
Ha78na added a comment to T221676: [SDOC] There is no link to Wikidata item in depicts: when there is no label in the currently used language.

Blocked by https://gerrit.wikimedia.org/r/506123 (Requires wikibase team to merge)

Apr 29 2019, 3:11 PM · Patch-For-Review, Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia

Apr 24 2019

Ha78na added a comment to T217870: Update header text on UploadWizard CC0 notice .

thanks @Jdforrester-WMF --- I agree, things look correct on production

Apr 24 2019, 1:22 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Structured-Data-Team-Current-Work, Multimedia, Structured Data Engineering

Apr 23 2019

Ha78na updated subscribers of T217870: Update header text on UploadWizard CC0 notice .

I see the correct i18n values on the master branch now. Not clear on what would be the difference between this code and production at this point - @Jdforrester-WMF could you shed some light? I didn't change the key name so maybe cached lang value is appearing? Let me know how to fix.

Apr 23 2019, 10:35 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Structured-Data-Team-Current-Work, Multimedia, Structured Data Engineering
Ha78na moved T221676: [SDOC] There is no link to Wikidata item in depicts: when there is no label in the currently used language from To Do to Doing on the Structured-Data-Team-Current-Work board.
Apr 23 2019, 6:52 PM · Patch-For-Review, Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia

Apr 17 2019

Ha78na added a comment to T220613: Allow viewing of statement blocks with unsupported data types.

Tested on test-commons- works there as well. @matthiasmullie your instructions were what I needed i was formatting the datavalue wrong

Apr 17 2019, 7:17 PM · Patch-For-Review, SDC-Statements (Depicts-Crawling), Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia

Apr 16 2019

Ha78na added a comment to T216772: The panels should use column width (60%) instead of spanning across the entire screen.

@PDrouin-WMF Can we considered this finished and close/resolve this ticket?

Apr 16 2019, 10:11 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Structured-Data-Team-Current-Work, SDC-Statements (Depicts-Crawling), Multimedia, Structured Data Engineering (Depicts-Crawling), SDC Design
Ha78na added a comment to T216773: Match the spacings and paddings with the design spec.

@PDrouin-WMF do you think we could close/resolve this ticket now?

Apr 16 2019, 10:10 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Structured-Data-Team-Current-Work, SDC-Statements (Depicts-Crawling), Multimedia, Structured Data Engineering (Depicts-Crawling), SDC Design
Ha78na moved T219944: Upload Wizard depicts heading/label should match what's been updated for File Page from Needs QA to Verify on Production on the Structured-Data-Team-Current-Work board.
Apr 16 2019, 10:09 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), SDC-Statements (Depicts-Walking), Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia
Ha78na claimed T219944: Upload Wizard depicts heading/label should match what's been updated for File Page.
Apr 16 2019, 10:08 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), SDC-Statements (Depicts-Walking), Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia
Ha78na added a comment to T219944: Upload Wizard depicts heading/label should match what's been updated for File Page.

This looks correct on beta and depicts is not on for UploadWizard on test-commons yet. Moving to 'Verify on Production'.

Apr 16 2019, 10:07 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), SDC-Statements (Depicts-Walking), Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia
Ha78na added a comment to T220613: Allow viewing of statement blocks with unsupported data types.

This seems to be working fine on beta, @matthiasmullie I couldn't figure out how to test on test-commons though - couldn't get the wbsetclaim correct in the Api Sandbox. What is an example claim JSON I should submit to get into this state on some file in test commons?

Apr 16 2019, 9:57 PM · Patch-For-Review, SDC-Statements (Depicts-Crawling), Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia
Ha78na moved T221071: We don't want MediaInfo content to show up on wikis sharing Commons files from Code Review to Needs QA on the Structured-Data-Team-Current-Work board.
Apr 16 2019, 9:54 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia
Ha78na added a comment to T221071: We don't want MediaInfo content to show up on wikis sharing Commons files.

This is merged now but seems like we can't really verify/qa till this ships to prod

Apr 16 2019, 9:51 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia
Ha78na moved T221110: Cannot edit statements for certain images from Needs QA to Verify on Production on the Structured-Data-Team-Current-Work board.
Apr 16 2019, 9:43 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Structured Data Engineering, SDC-Statements (Depicts-Crawling), Structured-Data-Team-Current-Work, Multimedia
Ha78na added a comment to T221110: Cannot edit statements for certain images.

This is working properly now on Beta again.

Apr 16 2019, 9:43 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Structured Data Engineering, SDC-Statements (Depicts-Crawling), Structured-Data-Team-Current-Work, Multimedia
Ha78na claimed T221110: Cannot edit statements for certain images.
Apr 16 2019, 9:40 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Structured Data Engineering, SDC-Statements (Depicts-Crawling), Structured-Data-Team-Current-Work, Multimedia
Ha78na reassigned T221123: Adding multiple captions at once is v broken (Beta Commons) from matthiasmullie to MarkTraceur.
Apr 16 2019, 9:40 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Structured Data Engineering, Multimedia, WikibaseMediaInfo, Structured-Data-Team-Current-Work
Ha78na moved T221123: Adding multiple captions at once is v broken (Beta Commons) from Code Review to Needs QA on the Structured-Data-Team-Current-Work board.
Apr 16 2019, 9:40 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Structured Data Engineering, Multimedia, WikibaseMediaInfo, Structured-Data-Team-Current-Work
Ha78na moved T221110: Cannot edit statements for certain images from Code Review to Needs QA on the Structured-Data-Team-Current-Work board.
Apr 16 2019, 9:38 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Structured Data Engineering, SDC-Statements (Depicts-Crawling), Structured-Data-Team-Current-Work, Multimedia
Ha78na added a comment to T221110: Cannot edit statements for certain images.

Seem blocked by failures due to T221111

Apr 16 2019, 6:57 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Structured Data Engineering, SDC-Statements (Depicts-Crawling), Structured-Data-Team-Current-Work, Multimedia
Ha78na added a comment to T221071: We don't want MediaInfo content to show up on wikis sharing Commons files.

Seem blocked by failures due to T221111

Apr 16 2019, 6:55 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia
Ha78na added a comment to T221070: [EPIC] How to deal with other wikis sharing Commons content?.

nice --good move on making this!

Apr 16 2019, 5:05 PM · Structured-Data-Backlog, Structured Data Engineering
Ha78na moved T221110: Cannot edit statements for certain images from To Do to Doing on the Structured-Data-Team-Current-Work board.
Apr 16 2019, 5:04 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Structured Data Engineering, SDC-Statements (Depicts-Crawling), Structured-Data-Team-Current-Work, Multimedia
Ha78na assigned T221110: Cannot edit statements for certain images to matthiasmullie.
Apr 16 2019, 5:01 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Structured Data Engineering, SDC-Statements (Depicts-Crawling), Structured-Data-Team-Current-Work, Multimedia
Ha78na created T221110: Cannot edit statements for certain images.
Apr 16 2019, 5:01 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Structured Data Engineering, SDC-Statements (Depicts-Crawling), Structured-Data-Team-Current-Work, Multimedia
Ha78na claimed T220613: Allow viewing of statement blocks with unsupported data types.
Apr 16 2019, 4:49 PM · Patch-For-Review, SDC-Statements (Depicts-Crawling), Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia
Ha78na added a comment to T219515: Clicking 'make prominent' while depicts form is submitting gets the form into a weird state.

@PDrouin-WMF Moved this into "verify on production" column - when something passes QA feel free to move it along

Apr 16 2019, 4:18 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, SDC-Statements (Depicts-Crawling), Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia
Ha78na moved T219515: Clicking 'make prominent' while depicts form is submitting gets the form into a weird state from Needs QA to Verify on Production on the Structured-Data-Team-Current-Work board.
Apr 16 2019, 4:17 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, SDC-Statements (Depicts-Crawling), Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia
Ha78na moved T219872: P<id> and Q<id> links don't display wikidata icon from Needs QA to Verify on Production on the Structured-Data-Team-Current-Work board.
Apr 16 2019, 4:16 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, SDC-Statements (Depicts-Crawling), Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia
Ha78na claimed T219872: P<id> and Q<id> links don't display wikidata icon.

I've QA'ed this on test commons and it looks good, I see icons.

Apr 16 2019, 4:15 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, SDC-Statements (Depicts-Crawling), Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia
Ha78na moved T221021: Depicts heading text is cut off on right from Needs QA to Verify on Production on the Structured-Data-Team-Current-Work board.
Apr 16 2019, 4:12 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), SDC-Statements (Depicts-Crawling), Structured Data Engineering, Patch-For-Review, Structured-Data-Team-Current-Work, Multimedia
Ha78na assigned T221017: 'Items depicts in this File' text sometimes in German to Ramsey-WMF.
Apr 16 2019, 4:10 PM · Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia
Ha78na moved T221017: 'Items depicts in this File' text sometimes in German from To Do to Needs QA on the Structured-Data-Team-Current-Work board.
Apr 16 2019, 4:10 PM · Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia
Ha78na added a project to T221017: 'Items depicts in this File' text sometimes in German: Structured-Data-Team-Current-Work.
Apr 16 2019, 4:09 PM · Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia
Ha78na reassigned T221021: Depicts heading text is cut off on right from Edtadros to PDrouin-WMF.
Apr 16 2019, 2:36 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), SDC-Statements (Depicts-Crawling), Structured Data Engineering, Patch-For-Review, Structured-Data-Team-Current-Work, Multimedia

Apr 15 2019

Ha78na added a subtask for T220774: Add JS Unit tests to safeguard Filepage UI happy-paths [Epic]: T219500: Unit Test: Add tests that ensures cancel/publish buttons are hidden and shown in proper modes.
Apr 15 2019, 5:35 PM · Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work
Ha78na added a parent task for T219500: Unit Test: Add tests that ensures cancel/publish buttons are hidden and shown in proper modes: T220774: Add JS Unit tests to safeguard Filepage UI happy-paths [Epic].
Apr 15 2019, 5:35 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia
Ha78na created T221021: Depicts heading text is cut off on right.
Apr 15 2019, 5:29 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), SDC-Statements (Depicts-Crawling), Structured Data Engineering, Patch-For-Review, Structured-Data-Team-Current-Work, Multimedia

Apr 11 2019

Ha78na updated the task description for T219500: Unit Test: Add tests that ensures cancel/publish buttons are hidden and shown in proper modes.
Apr 11 2019, 7:27 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia
Ha78na moved T220660: Protected image captions can't be edited, API query points at null from To Do to Code Review on the Structured-Data-Team-Current-Work board.
Apr 11 2019, 3:34 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Structured Data Engineering, Multimedia, Structured-Data-Team-Current-Work
Ha78na claimed T219500: Unit Test: Add tests that ensures cancel/publish buttons are hidden and shown in proper modes.
Apr 11 2019, 1:53 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia
Ha78na moved T219500: Unit Test: Add tests that ensures cancel/publish buttons are hidden and shown in proper modes from To Do to Doing on the Structured-Data-Team-Current-Work board.
Apr 11 2019, 1:53 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia

Apr 10 2019

Ha78na committed rEWBIe1d990b9dddf: [WIP] phpunit integration tests (authored by Ha78na).
[WIP] phpunit integration tests
Apr 10 2019, 8:46 PM
Ha78na reassigned T220113: Add php integration tests for Depicts from Ha78na to Cparle.
Apr 10 2019, 7:28 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia
Ha78na committed rEWBIdc9a633857d6: [WIP] phpunit integration tests (authored by Ha78na).
[WIP] phpunit integration tests
Apr 10 2019, 7:27 PM

Apr 9 2019

Ha78na reassigned T220444: Change "remove statements" text to "remove all" on statement panels from Ha78na to Ramsey-WMF.
Apr 9 2019, 12:48 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia

Apr 8 2019

Ha78na committed rEWBI2a766a58acf5: Change 'remove statement' to 'remove all' (authored by Ha78na).
Change 'remove statement' to 'remove all'
Apr 8 2019, 8:53 PM
Ha78na committed rEWBIe017846d0d9b: Change 'remove statement' to 'remove all' (authored by Ha78na).
Change 'remove statement' to 'remove all'
Apr 8 2019, 8:33 PM
Ha78na claimed T220444: Change "remove statements" text to "remove all" on statement panels.
Apr 8 2019, 8:28 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia

Apr 5 2019

Ha78na reassigned T219771: 'Confirm you want to leave' unload message shown when it shouldn't be from Ha78na to Edtadros.
Apr 5 2019, 4:42 PM · Patch-For-Review, SDC-Statements (Depicts-Crawling), Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia

Apr 4 2019

Ha78na moved T220113: Add php integration tests for Depicts from To Do to Doing on the Structured-Data-Team-Current-Work board.
Apr 4 2019, 3:33 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia
Ha78na assigned T219292: Top-to-bottom order of primary/prominent depicts values should change on publish to Edtadros.
Apr 4 2019, 2:14 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia
Ha78na added a project to T220113: Add php integration tests for Depicts: Structured-Data-Team-Current-Work.
Apr 4 2019, 2:12 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia
Ha78na created T220113: Add php integration tests for Depicts.
Apr 4 2019, 2:09 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia

Apr 3 2019

Ha78na committed rEWBIc1ead53a28e2: Fix 'Discard Changes' and 'Leave Site' alerts (authored by Ha78na).
Fix 'Discard Changes' and 'Leave Site' alerts
Apr 3 2019, 8:13 PM
Ha78na moved T219771: 'Confirm you want to leave' unload message shown when it shouldn't be from Doing to Code Review on the Structured-Data-Team-Current-Work board.
Apr 3 2019, 8:06 PM · Patch-For-Review, SDC-Statements (Depicts-Crawling), Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia
Ha78na placed T219292: Top-to-bottom order of primary/prominent depicts values should change on publish up for grabs.
Apr 3 2019, 4:01 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia
Ha78na updated the task description for T219292: Top-to-bottom order of primary/prominent depicts values should change on publish.
Apr 3 2019, 4:01 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia

Apr 2 2019

Ha78na moved T219292: Top-to-bottom order of primary/prominent depicts values should change on publish from Code Review to Needs QA on the Structured-Data-Team-Current-Work board.
Apr 2 2019, 5:56 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia
Ha78na moved T219771: 'Confirm you want to leave' unload message shown when it shouldn't be from To Do to Doing on the Structured-Data-Team-Current-Work board.
Apr 2 2019, 4:05 PM · Patch-For-Review, SDC-Statements (Depicts-Crawling), Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia
Ha78na committed rEWBIf69b5f6334f1: Order of depicts statements sorted by prominence on publish (authored by Ha78na).
Order of depicts statements sorted by prominence on publish
Apr 2 2019, 3:54 PM
Ha78na committed rEWBI69bd516a4cd7: Order of depicts statements sorted by prominence on publish (authored by Ha78na).
Order of depicts statements sorted by prominence on publish
Apr 2 2019, 2:45 PM
Ha78na committed rEWBIe0dce2f911fb: Order of depicts statements sorted by prominence on publish (authored by Ha78na).
Order of depicts statements sorted by prominence on publish
Apr 2 2019, 2:32 PM
Ha78na moved T217845: Need to change year to 1924 for public domain images in Wikimedia Commons Upload Wizard? from Code Review to Verify on Production on the Structured-Data-Team-Current-Work board.
Apr 2 2019, 1:55 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Multimedia, Structured-Data-Team-Current-Work, Commons, UploadWizard

Apr 1 2019

Ha78na committed rEWBI8e0d86ae9555: Order of depicts statements sorted by prominence on publish (authored by Ha78na).
Order of depicts statements sorted by prominence on publish
Apr 1 2019, 6:13 PM
Ha78na moved T219292: Top-to-bottom order of primary/prominent depicts values should change on publish from Doing to Code Review on the Structured-Data-Team-Current-Work board.
Apr 1 2019, 6:12 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia

Mar 28 2019

Ha78na added a comment to T218707: [Beta] Alignment of Q numbers/Primary buttons are not to spec.

Still working on this best solution this that doesn't effect i18n support. Re-assigning to reflect who is working on it now and moving back to in progress.

Mar 28 2019, 2:51 PM · Patch-For-Review, Structured-Data-Team-Current-Work, Structured Data Engineering, SDC-Statements (Depicts-Crawling), Multimedia
Ha78na moved T218707: [Beta] Alignment of Q numbers/Primary buttons are not to spec from Code Review to Doing on the Structured-Data-Team-Current-Work board.
Mar 28 2019, 2:51 PM · Patch-For-Review, Structured-Data-Team-Current-Work, Structured Data Engineering, SDC-Statements (Depicts-Crawling), Multimedia
Ha78na reassigned T218707: [Beta] Alignment of Q numbers/Primary buttons are not to spec from Ha78na to egardner.
Mar 28 2019, 2:48 PM · Patch-For-Review, Structured-Data-Team-Current-Work, Structured Data Engineering, SDC-Statements (Depicts-Crawling), Multimedia
Ha78na added a comment to T219458: User is not asked to confirm before leaving page with unsaved edits in Depicts or Captions fields.

@Ramsey-WMF Uh oh. You are right. The work I completed for that ticket was to make sure we prompt for discarding changes from hitting 'cancel' button. I must have misinterpreted the ticket or our conversation. You can see that in the work and I did and my questions about the text. The issue described in that ticket was never occurring for me locally at at that time (or James either it looks like) and the default browser alert was opening fine.

Mar 28 2019, 1:54 PM · Multimedia, Structured-Data-Team-Current-Work
Ha78na created T219500: Unit Test: Add tests that ensures cancel/publish buttons are hidden and shown in proper modes.
Mar 28 2019, 1:38 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia

Mar 27 2019

Ha78na added a comment to T219426: Captions broken.

For posterity: this bug was regression caused by T219197 which had recently merged. We luckily noticed it on beta before it got any further.

Mar 27 2019, 11:20 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), SDC-Statements (Depicts-Crawling), Structured Data Engineering, Multimedia, Structured-Data-Team-Current-Work
Ha78na committed rEWBI705feb1329ed: Refactor panel styles to use LESS features, Flexbox (authored by egardner).
Refactor panel styles to use LESS features, Flexbox
Mar 27 2019, 11:18 PM
Ha78na added a comment to T216773: Match the spacings and paddings with the design spec.

Another update from design.

Mar 27 2019, 9:59 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Structured-Data-Team-Current-Work, SDC-Statements (Depicts-Crawling), Multimedia, Structured Data Engineering (Depicts-Crawling), SDC Design
Ha78na added a comment to T218707: [Beta] Alignment of Q numbers/Primary buttons are not to spec.

@matthiasmullie Thanks for calling this out.

Mar 27 2019, 9:20 PM · Patch-For-Review, Structured-Data-Team-Current-Work, Structured Data Engineering, SDC-Statements (Depicts-Crawling), Multimedia
Ha78na moved T218707: [Beta] Alignment of Q numbers/Primary buttons are not to spec from Doing to Code Review on the Structured-Data-Team-Current-Work board.
Mar 27 2019, 8:27 PM · Patch-For-Review, Structured-Data-Team-Current-Work, Structured Data Engineering, SDC-Statements (Depicts-Crawling), Multimedia
Ha78na committed rEWBI8b431836a60b: Refactor panel styles to use LESS features, Flexbox (authored by egardner).
Refactor panel styles to use LESS features, Flexbox
Mar 27 2019, 8:26 PM
Ha78na committed rEWBI26874fdcdd46: Refactor panel styles to use LESS features, Flexbox (authored by egardner).
Refactor panel styles to use LESS features, Flexbox
Mar 27 2019, 8:07 PM
Ha78na moved T218707: [Beta] Alignment of Q numbers/Primary buttons are not to spec from Code Review to Doing on the Structured-Data-Team-Current-Work board.
Mar 27 2019, 4:05 PM · Patch-For-Review, Structured-Data-Team-Current-Work, Structured Data Engineering, SDC-Statements (Depicts-Crawling), Multimedia
Ha78na committed rEWBIaf188eb69587: Refactor panel styles to use LESS features, Flexbox (authored by egardner).
Refactor panel styles to use LESS features, Flexbox
Mar 27 2019, 4:03 PM
Ha78na committed rEWBIf0c4d650fbcc: Refactor panel styles to use LESS features, Flexbox (authored by egardner).
Refactor panel styles to use LESS features, Flexbox
Mar 27 2019, 1:47 PM
Ha78na added a comment to T218707: [Beta] Alignment of Q numbers/Primary buttons are not to spec.
Mar 27 2019, 11:47 AM · Patch-For-Review, Structured-Data-Team-Current-Work, Structured Data Engineering, SDC-Statements (Depicts-Crawling), Multimedia

Mar 26 2019

Ha78na committed rEWBIfb0196660bb5: Add close confirm alert when canceling un-saved SDC content (authored by Ha78na).
Add close confirm alert when canceling un-saved SDC content
Mar 26 2019, 7:44 PM
Ha78na moved T219292: Top-to-bottom order of primary/prominent depicts values should change on publish from To Do to Doing on the Structured-Data-Team-Current-Work board.
Mar 26 2019, 5:54 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia
Ha78na claimed T219292: Top-to-bottom order of primary/prominent depicts values should change on publish.
Mar 26 2019, 5:53 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia
Ha78na added a comment to T215818: Improvements to the Captions mobile experience.

Sounds good!
So remaining work is to adjust the trash can. I've updated the description to reflect this.

Mar 26 2019, 3:10 PM · Multimedia, Structured Data Engineering
Ha78na updated the task description for T215818: Improvements to the Captions mobile experience.
Mar 26 2019, 3:07 PM · Multimedia, Structured Data Engineering
Ha78na added a comment to T215818: Improvements to the Captions mobile experience.

Hey! Several of these changes we got for free with the recent CSS design refactor. That work will be visible on mobile production once any of T216773, T216772, or T218707 moves to the verify column.

Mar 26 2019, 2:48 PM · Multimedia, Structured Data Engineering
Ha78na added a comment to T217584: Add new OOUI classes to php demos.

Is this ticket complete? seems like it could be closed.

Mar 26 2019, 2:41 PM · OOUI (OOUI-0.31.0), Structured Data Engineering, Multimedia
Ha78na moved T219244: Change "Make primary" to "Mark as prominent" from To Do to Code Review on the Structured-Data-Team-Current-Work board.
Mar 26 2019, 2:34 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), SDC-Statements (Depicts-Crawling), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia
Ha78na assigned T219244: Change "Make primary" to "Mark as prominent" to Jdforrester-WMF.
Mar 26 2019, 2:34 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), SDC-Statements (Depicts-Crawling), Structured Data Engineering, Structured-Data-Team-Current-Work, Multimedia
Ha78na committed rEWBI8e0620233f2a: Add close confirm alert when canceling un-saved SDC content (authored by Ha78na).
Add close confirm alert when canceling un-saved SDC content
Mar 26 2019, 1:29 AM
Ha78na moved T219197: Show "changes you made may not be saved" alert for structured data fields from Doing to Code Review on the Structured-Data-Team-Current-Work board.
Mar 26 2019, 1:26 AM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia
Ha78na added a comment to T219197: Show "changes you made may not be saved" alert for structured data fields.

Done! thanks

Mar 26 2019, 1:26 AM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Structured-Data-Team-Current-Work, Structured Data Engineering, Multimedia

Mar 25 2019

Ha78na committed rEWBI4794e25595c3: Add close confirm alert when canceling un-saved SDC content (authored by Ha78na).
Add close confirm alert when canceling un-saved SDC content
Mar 25 2019, 10:25 PM