Page MenuHomePhabricator
Create Task
Maniphest T219944

Upload Wizard depicts heading/label should match what's been updated for File Page
Closed, ResolvedPublic
Actions

Description

User story:

We have this:

Screenshot 2019-04-02 15.43.27.png (582×1 px, 74 KB)

We want this:
The text should say "Items portrayed in this file" like the File Page says now.
The "depicts" label should be visible (and italicized), like it is on File Page now.

Acceptance Criteria:

  • Upload Wizard depicts heading and label match what's been updated on File Page

Details

SubjectRepoBranchLines +/-
Improve styling of depicts widgetmediawiki/extensions/UploadWizardmaster+10 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• PDrouin-WMF created this task.Apr 2 2019, 10:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 2 2019, 10:18 PM
• PDrouin-WMF renamed this task from [Insert design/front-end thing] to Upload Wizard depicts heading/label should match what's been updated for File Page.Apr 2 2019, 10:20 PM
• PDrouin-WMF added a parent task: T215304: "Depicts walking": Add/edit depicts statements in UploadWizard.Apr 2 2019, 11:08 PM
• Ramsey-WMF assigned this task to matthiasmullie.Apr 2 2019, 11:20 PM
• Ramsey-WMF triaged this task as Medium priority.
• Ramsey-WMF moved this task from Untriaged to Triaged on the Multimedia board.
• Ramsey-WMF added projects: Structured Data Engineering, Structured-Data-Team-Current-Work, SDC-Statements (Depicts-Walking).
• Ramsey-WMF moved this task from Triaged to Next up on the Multimedia board.
matthiasmullie added a comment.EditedApr 3 2019, 7:25 AM

Quick update - patches for these already:

gerritbot added a comment.Apr 3 2019, 9:01 AM

Change 500903 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/UploadWizard@master] Improve styling of depicts widget

https://gerrit.wikimedia.org/r/500903

gerritbot added a project: Patch-For-Review.Apr 3 2019, 9:01 AM
matthiasmullie moved this task from To Do to Code Review on the Structured-Data-Team-Current-Work board.Apr 3 2019, 9:02 AM
matthiasmullie reassigned this task from matthiasmullie to Edtadros.Apr 3 2019, 3:51 PM
matthiasmullie moved this task from Code Review to Needs QA on the Structured-Data-Team-Current-Work board.
matthiasmullie subscribed.
gerritbot added a comment.Apr 3 2019, 4:35 PM

Change 500903 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Improve styling of depicts widget

https://gerrit.wikimedia.org/r/500903

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.25; 2019-04-09).Apr 3 2019, 5:01 PM
• Ha78na subscribed.Apr 16 2019, 10:07 PM

This looks correct on beta and depicts is not on for UploadWizard on test-commons yet. Moving to 'Verify on Production'.

• Ha78na claimed this task.Apr 16 2019, 10:07 PM
• Ha78na moved this task from Needs QA to Verify on Production on the Structured-Data-Team-Current-Work board.
• Ha78na added a subscriber: Edtadros.
Jdforrester-WMF removed a project: Patch-For-Review.May 1 2019, 5:51 PM
• Ramsey-WMF closed this task as Resolved.May 7 2019, 10:36 PM

All good on production

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL