Steps to replicate:
- Open mobile VE
- Make an Edit and tap on "Publish"
- Tap on "Review your changes"
- Tap on "Return to save form"
The save form is empty.
Description
Description
Details
Details
Related Objects
Related Objects
- Mentioned In
- T242477: [Regression] The alignment icons are missing inside Media Settings dialog when opening the dialog first time in a login session
- Mentioned Here
- T222489: Visual diffs not showing in mobile VE (when visual section editing is disabled)
T219680: Diff view goes empty while switching back Visual diff to wikitext diff
Event Timeline
Comment Actions
- Open mobile VE
- Make an Edit and tap on "Publish"
- Tap on "Review your changes"
- Tap on "Return to save form"
For completeness' sake: I found another step after 3. to be necessary: switch to "Visual" diff if you were viewing a "Wikitext" diff.
Given the above and T219680, there is clearly something in our visual diffs that triggers this Safari bug when we hide them. If anyone fancies investigating it, start here :) I'll just apply the same fix here as in the other task.
Comment Actions
Change 505860 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.ui.MWSaveDialog: Work around save panel disappearing on iOS Safari as well
Comment Actions
Change 505860 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.ui.MWSaveDialog: Work around save panel disappearing on iOS Safari as well
Comment Actions
@matmarex: So this is not happening anymore when I follow the original steps but while testing the fix I found another case where it seems still broken. The steps are as follows:
Steps:
- Make an edit.
- Tap on Publish.
- Tap on "Review your changes".
- After switching to the diff panel, just close it.
- Now tap on "Publish" again.
The save panel is empty again.
Comment Actions
Change 507704 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.ui.MWSaveDialog: More save panel disappearing on iOS Safari
Comment Actions
Change 507704 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.ui.MWSaveDialog: More save panel disappearing on iOS Safari
Comment Actions
Confirming the issue this task was originally written to address, and the issue @Ryasmeen identified here, have both been resolved.
However, in the process of testing in the above, a new issues seems to have emerged: T222489: Visual diffs not showing in mobile VE (when visual section editing is disabled)