Page MenuHomePhabricator
Create Task
Maniphest T221291

[Regression] Cursor moves to the beginning of the article on mobile VE while adding manual citation
Closed, ResolvedPublic
Actions

Description

Steps to replicate:

  1. Open mobile VE for any page.
  2. Place your cursor anywhere in the document.
  3. Tap on the citation option on the toolbar.
  4. Insert a citation.

The cursor moves to the beginning and the citation gets added at that position instead of the position the user intended to add at.

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (ac38ec869)mediawiki/extensions/VisualEditormaster+1 -1
Restore re-activation hackVisualEditor/VisualEditormaster+6 -0
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Apr 17 2019, 8:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 17 2019, 8:53 PM
Esanders renamed this task from [Regression] Cursor moves to the beginning of the article on mobile VE while adding citation to [Regression] Cursor moves to the beginning of the article on mobile VE while adding manual citation.Apr 22 2019, 12:32 PM

This appears to only happen with manual citations, not auto or re-use.

Esanders added a comment.Apr 22 2019, 12:44 PM

Closing the Citoid inspector does the same thing.

Esanders added a comment.Apr 22 2019, 12:54 PM

Bisect blames https://gerrit.wikimedia.org/r/#/c/VisualEditor/VisualEditor/+/502508/.

Can be tested on core mobile demo using comment inspector.

gerritbot added a comment.Apr 22 2019, 1:02 PM

Change 505633 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Restore re-activation hack

https://gerrit.wikimedia.org/r/505633

gerritbot added a project: Patch-For-Review.Apr 22 2019, 1:02 PM
Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.Apr 22 2019, 1:02 PM
Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.
Esanders claimed this task.Apr 23 2019, 2:59 PM
gerritbot added a comment.Apr 23 2019, 10:04 PM

Change 505633 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Restore re-activation hack

https://gerrit.wikimedia.org/r/505633

gerritbot added a comment.Apr 23 2019, 10:40 PM

Change 506023 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (ac38ec869)

https://gerrit.wikimedia.org/r/506023

gerritbot added a comment.Apr 24 2019, 10:55 AM

Change 506023 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (ac38ec869)

https://gerrit.wikimedia.org/r/506023

Esanders moved this task from Code review to QA on the VisualEditor (Current work) board.Apr 24 2019, 2:33 PM
Esanders added a project: Editing QA.
Ryasmeen added a comment.EditedApr 25 2019, 8:47 PM

@Esanders: The original issue is fixed but there are several new cursor issues found while testing this. Let me know if you want me to open separate tickets for each of these:

  1. When I add a new citation at the end of a line, it stays selected and it's impossible to place the cursor after it, so pressing return opens up the citation dialog again instead of going to the next line.
  1. When I am adding a citation it automatically places a new line after that. Splitting the line of a text.
  1. When I add a new citation before opening up the citation panel, it shows a weird placeholder in that position momentarily. Previously it used to show the reference note itself (number inside []), now I'm seeing three dots inside a bracket [..]. Is this expected?
Ryasmeen moved this task from QA to Stalled/Waiting on the VisualEditor (Current work) board.Apr 29 2019, 6:14 PM
Esanders added a comment.May 5 2019, 1:38 PM

3 is expected, it shows the citation is not finished yet. 1&2 should be filed as bugs.

Ladsgroup removed a project: Patch-For-Review.May 22 2019, 9:21 AM
Esanders moved this task from Stalled/Waiting to Product owner review on the VisualEditor (Current work) board.May 22 2019, 6:16 PM

The questions have been addressed, so moving back to PO review.

JTannerWMF edited projects, added Skipped QA; removed Editing QA.May 23 2019, 6:10 PM
ppelberg closed this task as Resolved.EditedJun 20 2019, 11:52 PM
In T221291#5138863, @Ryasmeen wrote:
  1. When I add a new citation at the end of a line, it stays selected and it's impossible to place the cursor after it, so pressing return opens up the citation dialog again instead of going to the next line.
  1. When I am adding a citation it automatically places a new line after that. Splitting the line of a text.

I'm closing this task and in doing so I wanted to confirm:

@Ryasmeen, per T221291#5206017, have tickets been filed for "1." and "2." above?

I didn't see anything after quickly scanning this query's results: https://phabricator.wikimedia.org/search/query/Js5Kwsh1_ltC/#R

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJun 20 2019, 11:52 PM
Esanders mentioned this in T236400: Surface not deactivating for inspector when using nullSelectionOnBlur.Oct 24 2019, 3:56 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits