Page MenuHomePhabricator

Surface not deactivating for inspector when using nullSelectionOnBlur
Closed, ResolvedPublic

Description

nullSelectionOnBlur is used for places where VE is one of multiple inputes, e.g. in Flow.

The surface is deactivated when the window opens, then re-activates as soon as a transaction happens (behaviour required for T221291), e.g a temporary annotation is applied by the link inspector, or a dummy comment inserted by the comment inspector.

In full document VE this isn't a problem because the surface is deactivated again when the focus is moved to the inspector, but when nullSelectionOnBlur is set, moving the selection to the inspector just clears the original document selection.

Expected (VE)Observed (Flow)
image.png (163×417 px, 8 KB)
image.png (159×422 px, 8 KB)
image.png (171×418 px, 6 KB)
image.png (156×418 px, 5 KB)

Note the missing grey box around the inspected object, and the incorrect position of the triangle callout with respect to the comment icon.

Event Timeline

Esanders updated the task description. (Show Details)

Change 545886 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Mark surface as "showAsDeactivated" when opening a window

https://gerrit.wikimedia.org/r/545886

Change 545886 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Mark surface as "showAsDeactivated" when opening a window

https://gerrit.wikimedia.org/r/545886

Change 541826 had a related patch set uploaded (by Bartosz Dziewoński; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (3075d3f8c)

https://gerrit.wikimedia.org/r/541826

Change 541826 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (3075d3f8c)

https://gerrit.wikimedia.org/r/541826

ppelberg claimed this task.