Page MenuHomePhabricator

Reply v2.0: Create annotated tickets for posting on-wiki
Closed, ResolvedPublic

Event Timeline

Here are the three annotated designs. I will update here if there are any tweaks:

Visual

Source

Editing a posted comment

ppelberg renamed this task from Reply v2.0: Create annotated tickets for posting on0-wiki to Reply v2.0: Create annotated tickets for posting on-wiki.Feb 26 2020, 10:39 PM

Here are the three annotated designs. I will update here if there are any tweaks:

Looking good, Jess. Two tweaks before we put these up:

  • Can you make it so the comment draft written the Source mode matches the comment written in Visual mode?
    • Thinking: I think it's important for people to be able to easily visualize what it will be like to switch between modes and I think having the comments be consistent between the two will help with this For example, the comments in either mode could read:
      • Source: "Publicly accessible, permanently installed signs are acceptable. [[Template:Cite_sign]] is one way to format the citation."
      • Visual: "Publicly accessible, permanently installed signs are acceptable. Template:Cite_sign is one way to format the citation."
  • In F31632216, can you add the signature to the preview?
Alsee added a comment.Feb 27 2020, 8:57 AM

@iamjessklein not a big deal, but I noticed the link in your example is broken. An http-type link is an external link. External links use single-brackets and a space instead of a pipe. Like this: [https://en.wikipedia.org/wiki/Template:Cite_sign Template:Cite_sign]

However there's no need to use an external link. It's much simpler as an internal link: [[Template:Cite sign]] works and doesn't even need a pipe.

However^2, the most common way we link to templates is to use a template: {{tl|Cite sign}}. That's notably shorter, and it nicely displays as {{Cite sign}}.

Thanks @ppelberg - I've updated the mocks. Good eyes @Alsee ! I've added the fix to the mockup.

ppelberg added a comment.EditedMar 4 2020, 2:30 AM

Thanks @ppelberg - I've updated the mocks. Good eyes @Alsee ! I've added the fix to the mockup.

Thanks, Jess – almost there. I see a few things I think still need fixing. Once the below is done, I think they are ready for posting.

MockupUpdates
F31649520: Visual (annotated)
1. QUESTION: should the "Intuitively "@mention" a specific contributor." annotation be beneath the "👤" icon?
F31649523: Editing comment (annotated)
1. CHANGE annotation from "Can't edit someone else's reply." to "Edit links will only appear next to comments you have written." 2. CHANGE mockup to show the workflow described in: T235593#5925107.
All mockups1. SWITCH text input mode tabs such that Source is located to the right of the Visual tab.

In the "edit my own comments" system, is 50% opacity dark enough that I can read the other person's comment? I might be trying to fix a spelling error or something in my message, and need to copy it from another comment.

Also, could there be a way to intentionally trigger Echo's mentions in this? If we're relying on Echo's normal processes, and I @ mention someone while editing the comment, it won't happen.

In the "edit my own comments" system, is 50% opacity dark enough that I can read the other person's comment? I might be trying to fix a spelling error or something in my message, and need to copy it from another comment.

Good spot, Sherry. Although, considering that, for the time being, we are going to pause development on the functionality to enable editing single comments [i], I think we can come back to the conversation about how it ought to get implemented.

Also, could there be a way to intentionally trigger Echo's mentions in this? If we're relying on Echo's normal processes, and I @ mention someone while editing the comment, it won't happen.

Another good spot. Considering the above, I've added this point as an "Open question" to this task's description: T245225


i. T242562#5977993.