Page MenuHomePhabricator

Develop a technical approach for editing a specific comment
Open, Needs TriagePublic

Description

This tasks represents the work with researching the technical constraints we will need to consider when designing a feature that will enable contributors to edit single comments posted to talk pages (e.g. How can the software reliably detect the boundaries of a comment so the proper amount of editable content is presented to contributors when they click "edit"?)

  • How to handle the number of lines within a comment change works
  • How to keep the signature out of the edit range

Event Timeline

ppelberg renamed this task from Develop an approach for editing a specific comment to Develop a technical approach for editing a specific comment.Jan 12 2020, 11:51 PM
ppelberg created this task.
ppelberg updated the task description. (Show Details)Jan 13 2020, 12:00 AM
ppelberg added a subscriber: dchan.Jan 23 2020, 7:41 PM
JTannerWMF moved this task from Incoming to Design on the Editing-team board.Feb 10 2020, 1:45 PM
marcella assigned this task to Esanders.Feb 10 2020, 2:43 PM
DLynch added a subscriber: DLynch.Feb 13 2020, 6:44 PM

There's questions regarding whether we should include any sort of "this comment was edited" notice on an edited comment. Meeting discussion leans towards "no", in part because there's no good way to link to the revision history showing the change without making a second edit to add that link in.

We've started on an approach based on David's rebalancer, which can slice a reply tree into three balanced parts based on an arbitrary selection. We still need to work out how to handle the number of lines within a comment change works, and also how to keep the signature out of the edit range (T245220).

JTannerWMF updated the task description. (Show Details)Mar 1 2020, 9:52 PM
JTannerWMF edited projects, added OWC2020 (OWC2020 Replying 2.0); removed OWC2020.

For the time being, we are going to pause development on the new workflow for editing single comments on talk pages.

Reasons

  1. We have yet to develop an approach we think would work reliably enough for people on "real" talk pages (read: talk pages on production wikis)
  2. Introducing this functionality is not a high priority at this time

Next steps

  • @Esanders, are you able to comment the approaches we've explored so far and the advantages and disadvantages with each one?