Page MenuHomePhabricator
Create Task
Maniphest T251654

Deploy Replying v2.0 as Beta Feature to partner wikis
Closed, ResolvedPublic
Actions

Description

"2.0" = DiscussionToolsEnableVisual

This task is about making the Reply tool's visual mode available within the existing DiscussionTools Beta Feature that is deployed at our four partner Wikipedias: Arabic, Dutch, French and Hungarian. More details below.

Deployment timing

  • @ppelberg to finalize and notify engineering.
    • This should be deployed today, 17-June.

Deployment details

  • In making this change, the Reply tool's visual mode will become available wherever the tool is currently available (parter wikis, beta cluster, url parameter)
    • Where "become available" means people will see the visual tab within the Reply tool's toolbar. [i]
  • In making this change, we need to preserve the ability to "turn off" the tool's visual mode if issues arise that warrant doing so

Done

  • The "Deployment details" above have been implemented

i.

Screen Shot 2020-06-02 at 4.27.24 PM.png (572×1 px, 81 KB)

Details

SubjectRepoBranchLines +/-
Set DiscussionToolsEnableVisual to true by defaultmediawiki/extensions/DiscussionToolsmaster+1 -1
Set DiscussionToolsEnableVisual to true by defaultoperations/mediawiki-configmaster+4 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT233443 [Epic] Reply Tool
 Resolved• ppelbergT251654 Deploy Replying v2.0 as Beta Feature to partner wikis
 ResolvedEsandersT250523 Determine which Reply text input should be shown by default
 ResolvedDLynchT232601 Provide a mechanism for in-surface autocomplete
 Resolved• iamjesskleinT251478 Create UI for in-surface auto-complete
 ResolvedEsandersT252460 Keep '@' prefix in username auto-complete output
 Resolved• iamjesskleinT246190 Reply v2.0: conduct usability tests (usertesting.com)
 ResolvedEsandersT234403 Create a VE-based text input for replying
 Resolved• ppelbergT236400 Surface not deactivating for inspector when using nullSelectionOnBlur
 ResolvedBUG REPORT• ppelbergT253255 Discussion tool uses content language direction for UI
 ResolvedBUG REPORTEsandersT253258 The visual mode left-justifies text on RTL wikis
 Resolved• ppelbergT246191 Reply v2.0: conduct usability test (MediaWiki)
 ResolvedEsandersT251963 Test `visual` mode through query string
 Resolved• Whatamidoing-WMFT252265 Make partner wikis aware of `dtvisual=1` and v2.0 sequence and timing
 DuplicateNoneT252029 Make partner wikis aware of v2.0 deployment sequence and timing
 Resolved• ppelbergT252931 Instrument Reply tool v2.0
 ResolvedMayakp.wikiT244498 Replies v2.0: determine what additional instrumentation is needed
 ResolvedDLynchT252924 Add fields to VisualEditorFeatureUse
ResolvedMayakp.wikiT252930 Post-deployment QA: Reply tool v2.0 instrumentation (DB)
 ResolvedRyasmeenT252927 Post-deployment QA: Reply tool v2.0 instrumentation
 ResolvedRyasmeenT252926 Pre-deployment QA: Reply tool v2.0 instrumentation
 ResolvedDLynchT252925 Apply VisualEditorFeatureUse schema changes to all editing interfaces
 ResolvedMayakp.wikiT254291 Add additional events to VisualEditorFeatureUse
 Resolved• ppelbergT255639 action: "window-open-from-tool" is showing up instead of "action": "external-link-input" when a user clicks on "Link"

Event Timeline

• ppelberg created this task.May 2 2020, 12:57 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 2 2020, 12:57 AM
• ppelberg added a subtask: T244498: Replies v2.0: determine what additional instrumentation is needed.May 2 2020, 12:58 AM
• ppelberg added a parent task: T233443: [Epic] Reply Tool.
• ppelberg added a subtask: T250523: Determine which Reply text input should be shown by default.May 2 2020, 1:00 AM
• ppelberg added a subtask: T251478: Create UI for in-surface auto-complete.
• ppelberg added a subtask: T232601: Provide a mechanism for in-surface autocomplete.
• ppelberg added a subtask: T246190: Reply v2.0: conduct usability tests (usertesting.com).
• ppelberg added a subtask: T234403: Create a VE-based text input for replying.May 2 2020, 1:03 AM
Mayakp.wiki mentioned this in T249386: Calculate adoption of Replying tool (Beta Features).May 4 2020, 6:56 PM
• ppelberg added a subtask: T246191: Reply v2.0: conduct usability test (MediaWiki).May 5 2020, 4:45 PM
• ppelberg mentioned this in T252930: Post-deployment QA: Reply tool v2.0 instrumentation (DB).May 15 2020, 11:18 PM
• ppelberg removed a subtask: T244498: Replies v2.0: determine what additional instrumentation is needed.May 15 2020, 11:36 PM
• ppelberg mentioned this in T244498: Replies v2.0: determine what additional instrumentation is needed.May 21 2020, 1:43 AM
• ppelberg added a subtask: T252931: Instrument Reply tool v2.0.
• ppelberg closed subtask T251963: Test `visual` mode through query string as Resolved.Jun 1 2020, 1:46 AM
• ppelberg moved this task from Needs Prioritization to Required for Release on the OWC2020 (OWC2020 Replying 2.0) board.Jun 3 2020, 12:13 AM
• ppelberg moved this task from Needs Discussion / Investigation to Upcoming on the Editing-team (Q3 2019-2020 Kanban Board) board.Jun 3 2020, 2:39 PM
Esanders updated the task description. (Show Details)Jun 15 2020, 6:33 PM
gerritbot added a comment.Jun 15 2020, 6:45 PM

Change 605642 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Set DiscussionToolsEnableVisual to true by default

https://gerrit.wikimedia.org/r/605642

gerritbot added a project: Patch-For-Review.Jun 15 2020, 6:45 PM
• ppelberg added a comment.Jun 15 2020, 6:53 PM

Update
Notes from this morning's standup; the below is now represented in the task description as well...

  • In making this change, the Reply tool's visual mode will become available, by default, wherever the tool is currently available (parter wikis, beta cluster, url parameter)
  • In making this change, we need to preserve the ability to "turn off" the tool's visual mode if issues arise that warrant doing so

Next steps

• ppelberg updated the task description. (Show Details)Jun 15 2020, 6:57 PM
• ppelberg mentioned this in T251478: Create UI for in-surface auto-complete.Jun 15 2020, 10:09 PM
• ppelberg closed subtask T246190: Reply v2.0: conduct usability tests (usertesting.com) as Resolved.
gerritbot added a comment.Jun 16 2020, 7:28 PM

Change 605997 had a related patch set uploaded (by Esanders; owner: Esanders):
[operations/mediawiki-config@master] Set DiscussionToolsEnableVisual to true by default

https://gerrit.wikimedia.org/r/605997

• ppelberg added a comment.Jun 17 2020, 5:39 PM
In T251654#6225251, @ppelberg wrote:

Next steps

This should be deployed today, 17-June.

• ppelberg updated the task description. (Show Details)Jun 17 2020, 5:39 PM
gerritbot added a comment.Jun 17 2020, 6:11 PM

Change 605997 merged by jenkins-bot:
[operations/mediawiki-config@master] Set DiscussionToolsEnableVisual to true by default

https://gerrit.wikimedia.org/r/605997

Stashbot added a comment.Jun 17 2020, 6:14 PM

Mentioned in SAL (#wikimedia-operations) [2020-06-17T18:14:22Z] <urbanecm@deploy1001> Synchronized wmf-config/InitialiseSettings.php: c9f6452: Set DiscussionToolsEnableVisual to true by default (T251654) (duration: 00m 56s)

matmarex moved this task from Upcoming to Ready for Sign Off on the Editing-team (Q3 2019-2020 Kanban Board) board.Jun 17 2020, 6:43 PM
matmarex removed a project: Patch-For-Review.
matmarex subscribed.

Deployed, everything looks good to me.

• ppelberg added a comment.Jun 17 2020, 6:44 PM
In T251654#6232861, @matmarex wrote:

Deployed, everything looks good to me.

Excellent.

• ppelberg closed subtask T251478: Create UI for in-surface auto-complete as Resolved.Jun 18 2020, 4:43 PM
• ppelberg added a project: Editing QA.Jun 18 2020, 10:07 PM
• ppelberg moved this task from Inbox to High Priority on the Editing QA board.
Ryasmeen subscribed.Jun 23 2020, 3:25 AM

I checked this today on all four target wikis. Verified the basic functionalities, all the options under VE mode, text formatting, link, username auto suggestions, username mention icon functionality and did a quick re-check on editor preference. Everything looks okay to me. I have found the following issue however: T256089.
Over to you @ppelberg.

• ppelberg closed this task as Resolved.Jun 24 2020, 12:18 AM
• ppelberg claimed this task.
In T251654#6247287, @Ryasmeen wrote:

I checked this today on all four target wikis. Verified the basic functionalities, all the options under VE mode, text formatting, link, username auto suggestions, username mention icon functionality and did a quick re-check on editor preference. Everything looks okay to me. I have found the following issue however: T256089.

Excellent. Closing this out. Thank you, Rummana.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJun 24 2020, 12:18 AM
• ppelberg closed subtask T246191: Reply v2.0: conduct usability test (MediaWiki) as Resolved.Jun 27 2020, 1:20 AM
• ppelberg closed subtask T234403: Create a VE-based text input for replying as Resolved.Jun 27 2020, 1:53 AM
gerritbot added a comment.Jun 29 2020, 11:54 AM

Change 605642 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Set DiscussionToolsEnableVisual to true by default

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/ /605642

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.39; 2020-06-30).Jun 29 2020, 12:00 PM
matmarex added a comment.Jun 29 2020, 12:03 PM

(This patch doesn't affect the production wikis, it only changes the defaults for hypothetical third-party users and Patchdemo)

• ppelberg closed subtask T250523: Determine which Reply text input should be shown by default as Resolved.Jun 30 2020, 5:58 PM
• ppelberg closed subtask T232601: Provide a mechanism for in-surface autocomplete as Resolved.Jul 9 2020, 2:45 AM
• ppelberg closed subtask T252931: Instrument Reply tool v2.0 as Resolved.Dec 5 2020, 12:18 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL