Page MenuHomePhabricator

Instrument Reply tool v2.0
Closed, ResolvedPublic

Event Timeline

We need to go over the events for the mode-switching and ensure that they're firing appropriately.

A quick test on beta suggests that two things are obviously wrong currently:

  1. EditAttemptStep.firstChange fires every single time you switch to source mode if there's any content in the field (but not when you switch to visual mode, regardless.
  2. There's no event fired at all for switching between modes. It should probably be consistent with whatever fires to VisualEditorFeatureUse for a switch from VE to NWE, though because of the different architecture I imagine we'll have to manually trigger the appropriate activity. event rather than relying on it coming from a Tool.

We need to go over the events for the mode-switching and ensure that they're firing appropriately.

A quick test on beta suggests that two things are obviously wrong currently:

  1. EditAttemptStep.firstChange fires every single time you switch to source mode if there's any content in the field (but not when you switch to visual mode, regardless.
  2. There's no event fired at all for switching between modes. It should probably be consistent with whatever fires to VisualEditorFeatureUse for a switch from VE to NWE, though because of the different architecture I imagine we'll have to manually trigger the appropriate activity. event rather than relying on it coming from a Tool.

The changes described above will be implemented in this newly created task: T254291.

ppelberg claimed this task.